Use msbuild project reference to establish dependency on genconsts instead of solution dependencies (#9670)

Using solution dependencies in ```bcl.sln``` seems flaky and seems like it might not establish the full ordering we need to ensure that ```Consts.cs``` exists before we build things that require it. Let's try using project references (where ```corlib.dll``` 'depends' on ```genconsts.exe```) instead. This should also insert the dependency for any project that includes Consts.cs instead of just corlib.

This PR also makes update-solution-files actually fail if ```genconsts.exe``` fails to build because it was driving me mad.

Part of #6886

1 files changed, 7 insertions, 0 deletions

diff --git a/mcs/class/System.Data.Services/System.Data.Services.csproj b/mcs/class/System.Data.Services/System.Data.Services.csproj
index 3d0bb8794b3..2e5f71bef0b 100644
--- a/mcs/class/System.Data.Services/System.Data.Services.csproj
+++ b/mcs/class/System.Data.Services/System.Data.Services.csproj
@@ -120,6 +120,13 @@
     <Compile Include="System.Data.Services\ServiceOperationRights.cs" />

     <Compile Include="System.Data.Services\SingleResultAttribute.cs" />

     <Compile Include="System.Data.Services\UpdateOperations.cs" />

+    <ProjectReference Include="$(SolutionDir)\msvc\scripts\genconsts.csproj">

+      <Name>genconsts</Name>

+      <Project>{702AE2C0-71DD-4112-9A06-E4FABCA59986}</Project>

+      <ReferenceOutputAssembly>false</ReferenceOutputAssembly>

+      <CopyToOutputDirectory>Never</CopyToOutputDirectory>

+      <Private>False</Private>

+    </ProjectReference>

   </ItemGroup>

   <ItemGroup></ItemGroup>

   <!-- @ALL_SOURCES@ -->