diff options
author | Atsushi Eno <atsushieno@gmail.com> | 2006-01-11 21:47:40 +0300 |
---|---|---|
committer | Atsushi Eno <atsushieno@gmail.com> | 2006-01-11 21:47:40 +0300 |
commit | 95eed2d2f43f85d24b993717fe7800157a678591 (patch) | |
tree | f41b72477349de5bfb7adaa0781b087a7400176d /mcs/class/System.XML/System.Xml.XPath | |
parent | 1282586feece6743d27b5005ca33c64c3bf0b821 (diff) |
2006-01-11 Atsushi Enomoto <atsushi@ximian.com>
* Iterator.cs : Nowadays removal of cloning of the argument list
in ListIterator is safe. Thanks to Joshua Tauberer for the hint.
svn path=/trunk/mcs/; revision=55394
Diffstat (limited to 'mcs/class/System.XML/System.Xml.XPath')
-rw-r--r-- | mcs/class/System.XML/System.Xml.XPath/ChangeLog | 5 | ||||
-rw-r--r-- | mcs/class/System.XML/System.Xml.XPath/Iterator.cs | 7 |
2 files changed, 6 insertions, 6 deletions
diff --git a/mcs/class/System.XML/System.Xml.XPath/ChangeLog b/mcs/class/System.XML/System.Xml.XPath/ChangeLog index 4bcca4d3dfe..ad30973bd0b 100644 --- a/mcs/class/System.XML/System.Xml.XPath/ChangeLog +++ b/mcs/class/System.XML/System.Xml.XPath/ChangeLog @@ -1,5 +1,10 @@ 2006-01-11 Atsushi Enomoto <atsushi@ximian.com> + * Iterator.cs : Nowadays removal of cloning of the argument list + in ListIterator is safe. Thanks to Joshua Tauberer for the hint. + +2006-01-11 Atsushi Enomoto <atsushi@ximian.com> + * Iterator.cs : (DescendantOrSelfIterator/DescendantIterator) the error message is for blaming custom XPathNavigator implementation, not us ;-) (see also #77194) diff --git a/mcs/class/System.XML/System.Xml.XPath/Iterator.cs b/mcs/class/System.XML/System.Xml.XPath/Iterator.cs index 993b2d89fab..eb42e055c57 100644 --- a/mcs/class/System.XML/System.Xml.XPath/Iterator.cs +++ b/mcs/class/System.XML/System.Xml.XPath/Iterator.cs @@ -1057,22 +1057,17 @@ namespace System.Xml.XPath public ListIterator (BaseIterator iter, IList list) : base (iter.NamespaceManager) { - if (!(list is ICloneable)) - throw new ArgumentException ("Target enumerator must be cloneable."); _list = list; } public ListIterator (IList list, NSResolver nsm) : base (nsm) { - if (!(list is ICloneable)) - throw new ArgumentException ("Target enumerator must be cloneable."); _list = list; } private ListIterator (ListIterator other) : base (other) { - ICloneable listClone = other._list as ICloneable; - _list = (IList) listClone.Clone (); + _list = other._list; } public override XPathNodeIterator Clone () { return new ListIterator (this); } |