diff options
| author | Sebastien Pouliot <sebastien@ximian.com> | 2004-06-15 00:43:18 +0400 |
|---|---|---|
| committer | Sebastien Pouliot <sebastien@ximian.com> | 2004-06-15 00:43:18 +0400 |
| commit | 9abca3e9dd591eb1fa9df8e055a1ef27256bcec1 (patch) | |
| tree | c8408603a25d9cbafe9f2346bce31e7fd1b15ca8 /mcs/class/System/System.Collections.Specialized | |
| parent | 0bae4d8bb16d95b96952d2d6b51aba9e4f746b0b (diff) | |
2004-06-14 Sebastien Pouliot <sebastien@ximian.com>
* NameObjectCollectionBase.cs: Now use IComparer to compare keys. This
completes a TODO and fix Remove in NameValueCollection.
svn path=/trunk/mcs/; revision=29550
Diffstat (limited to 'mcs/class/System/System.Collections.Specialized')
| -rwxr-xr-x | mcs/class/System/System.Collections.Specialized/ChangeLog | 2 | ||||
| -rw-r--r-- | mcs/class/System/System.Collections.Specialized/NameObjectCollectionBase.cs | 13 |
2 files changed, 6 insertions, 9 deletions
diff --git a/mcs/class/System/System.Collections.Specialized/ChangeLog b/mcs/class/System/System.Collections.Specialized/ChangeLog index 7366e00ad39..09d676aa18d 100755 --- a/mcs/class/System/System.Collections.Specialized/ChangeLog +++ b/mcs/class/System/System.Collections.Specialized/ChangeLog @@ -2,6 +2,8 @@ * HybridDictionary.cs: Fixed Contains for null argument (again). Return false when dictionary is empty or else throw an ArgumentNullException. + * NameObjectCollectionBase.cs: Now use IComparer to compare keys. This + completes a TODO and fix Remove in NameValueCollection. * NameValueCollection.cs: Added missing Rank check in CopyTo (Array, int). diff --git a/mcs/class/System/System.Collections.Specialized/NameObjectCollectionBase.cs b/mcs/class/System/System.Collections.Specialized/NameObjectCollectionBase.cs index d29cc29ea34..8b1ca2248f9 100644 --- a/mcs/class/System/System.Collections.Specialized/NameObjectCollectionBase.cs +++ b/mcs/class/System/System.Collections.Specialized/NameObjectCollectionBase.cs @@ -454,11 +454,7 @@ namespace System.Collections.Specialized return (m_ItemsContainer.Count>0);
// throw new Exception("Not implemented yet");
}
- /// <summary>
- ///
- /// </summary>
- /// <param name="name"></param>
- [MonoTODO]
+ protected void BaseRemove( string name )
{
int cnt = 0;
@@ -476,8 +472,7 @@ namespace System.Collections.Specialized cnt = m_ItemsArray.Count;
for (int i=0 ; i< cnt; ){
key=BaseGetKey(i);
- // TODO: consider case-sensivity
- if (String.Compare(key,name)==0){
+ if (m_comparer.Compare (key, name) == 0) {
m_ItemsArray.RemoveAt(i);
cnt--;
}
@@ -485,8 +480,8 @@ namespace System.Collections.Specialized i++;
}
-// throw new Exception("Not implemented yet");
- }
+ } +
/// <summary>
///
/// </summary>
|