From 7f0b7cf0221f9ebc1cd736f361fe814a1c31cdf9 Mon Sep 17 00:00:00 2001 From: Ludovic Henry Date: Wed, 27 Jan 2016 16:08:18 +0000 Subject: [Tests] Use explicit delegate so it appears in stacktraces In case of exception in this callback, the name of the test method will appear in the stacktrace, making debugging way easier. --- .../System.Web.Services.Protocols/SoapHttpClientProtocolTest.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'mcs/class/System.Web.Services/Test/System.Web.Services.Protocols/SoapHttpClientProtocolTest.cs') diff --git a/mcs/class/System.Web.Services/Test/System.Web.Services.Protocols/SoapHttpClientProtocolTest.cs b/mcs/class/System.Web.Services/Test/System.Web.Services.Protocols/SoapHttpClientProtocolTest.cs index 00873070036..62fae0ddfbe 100755 --- a/mcs/class/System.Web.Services/Test/System.Web.Services.Protocols/SoapHttpClientProtocolTest.cs +++ b/mcs/class/System.Web.Services/Test/System.Web.Services.Protocols/SoapHttpClientProtocolTest.cs @@ -51,7 +51,7 @@ namespace MonoTests.System.Web.Services.Protocols public void OutParametersTest () { IPEndPoint localEP = new IPEndPoint (IPAddress.Loopback, 5000); - using (SocketResponder sr = new SocketResponder (localEP, new SocketRequestHandler (OutParametersResponse))) { + using (SocketResponder sr = new SocketResponder (localEP, s => OutParametersResponse (s))) { sr.Start (); FooService service = new FooService (); @@ -74,7 +74,7 @@ namespace MonoTests.System.Web.Services.Protocols public void FaultTest () { IPEndPoint localEP = new IPEndPoint (IPAddress.Loopback, 5000); - using (SocketResponder sr = new SocketResponder (localEP, new SocketRequestHandler (FaultResponse_Qualified))) { + using (SocketResponder sr = new SocketResponder (localEP, s => FaultResponse_Qualified (s))) { sr.Start (); FooService service = new FooService (); @@ -103,7 +103,7 @@ namespace MonoTests.System.Web.Services.Protocols sr.Stop (); } - using (SocketResponder sr = new SocketResponder (localEP, new SocketRequestHandler (FaultResponse_Unqualified))) { + using (SocketResponder sr = new SocketResponder (localEP, s => FaultResponse_Unqualified (s))) { sr.Start (); FooService service = new FooService (); -- cgit v1.2.3 From 83c7edc70e732cd0416a84284e3435ccc448c489 Mon Sep 17 00:00:00 2001 From: Ludovic Henry Date: Thu, 28 Jan 2016 10:50:34 +0000 Subject: [SocketResponder] Start in constructor and Stop on Dispose In conjuction with `using` we ensure that we Start and Stop the SocketResponder correctly, and everytime --- .../SoapHttpClientProtocolTest.cs | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'mcs/class/System.Web.Services/Test/System.Web.Services.Protocols/SoapHttpClientProtocolTest.cs') diff --git a/mcs/class/System.Web.Services/Test/System.Web.Services.Protocols/SoapHttpClientProtocolTest.cs b/mcs/class/System.Web.Services/Test/System.Web.Services.Protocols/SoapHttpClientProtocolTest.cs index 62fae0ddfbe..0019e05c278 100755 --- a/mcs/class/System.Web.Services/Test/System.Web.Services.Protocols/SoapHttpClientProtocolTest.cs +++ b/mcs/class/System.Web.Services/Test/System.Web.Services.Protocols/SoapHttpClientProtocolTest.cs @@ -52,8 +52,6 @@ namespace MonoTests.System.Web.Services.Protocols { IPEndPoint localEP = new IPEndPoint (IPAddress.Loopback, 5000); using (SocketResponder sr = new SocketResponder (localEP, s => OutParametersResponse (s))) { - sr.Start (); - FooService service = new FooService (); service.Url = "http://" + IPAddress.Loopback.ToString () + ":5000/"; @@ -64,8 +62,6 @@ namespace MonoTests.System.Web.Services.Protocols Assert.AreEqual (0, a, "#A2"); Assert.IsFalse (b, "#A3"); service.Dispose (); - - sr.Stop (); } } @@ -75,8 +71,6 @@ namespace MonoTests.System.Web.Services.Protocols { IPEndPoint localEP = new IPEndPoint (IPAddress.Loopback, 5000); using (SocketResponder sr = new SocketResponder (localEP, s => FaultResponse_Qualified (s))) { - sr.Start (); - FooService service = new FooService (); service.Url = "http://" + IPAddress.Loopback.ToString () + ":5000/"; try { @@ -99,13 +93,9 @@ namespace MonoTests.System.Web.Services.Protocols Assert.AreEqual ("Failure processing request.", ex.Message, "#A9"); } service.Dispose (); - - sr.Stop (); } using (SocketResponder sr = new SocketResponder (localEP, s => FaultResponse_Unqualified (s))) { - sr.Start (); - FooService service = new FooService (); service.Url = "http://" + IPAddress.Loopback.ToString () + ":5000/"; try { @@ -128,8 +118,6 @@ namespace MonoTests.System.Web.Services.Protocols Assert.AreEqual ("Failure processing request.", ex.Message, "#B9"); } service.Dispose (); - - sr.Stop (); } } -- cgit v1.2.3