From feaf8ee391a09fbff2137905ac7139f9bacc99fa Mon Sep 17 00:00:00 2001
From: Katelyn Gadd <kg@luminance.org>
Date: Wed, 1 Aug 2018 15:30:54 -0700
Subject: Use msbuild project reference to establish dependency on genconsts
 instead of solution dependencies (#9670)

Using solution dependencies in ```bcl.sln``` seems flaky and seems like it might not establish the full ordering we need to ensure that ```Consts.cs``` exists before we build things that require it. Let's try using project references (where ```corlib.dll``` 'depends' on ```genconsts.exe```) instead. This should also insert the dependency for any project that includes Consts.cs instead of just corlib.

This PR also makes update-solution-files actually fail if ```genconsts.exe``` fails to build because it was driving me mad.

Part of #6886
---
 .../System.Web.WebPages.Deployment.csproj                          | 7 +++++++
 1 file changed, 7 insertions(+)

(limited to 'mcs/class/System.Web.WebPages.Deployment')

diff --git a/mcs/class/System.Web.WebPages.Deployment/System.Web.WebPages.Deployment.csproj b/mcs/class/System.Web.WebPages.Deployment/System.Web.WebPages.Deployment.csproj
index 3ab2b026f13..3ffd618aa04 100644
--- a/mcs/class/System.Web.WebPages.Deployment/System.Web.WebPages.Deployment.csproj
+++ b/mcs/class/System.Web.WebPages.Deployment/System.Web.WebPages.Deployment.csproj
@@ -64,6 +64,13 @@
     <Compile Include="..\..\..\external\aspnetwebstack\src\TransparentCommonAssemblyInfo.cs" />
     <Compile Include="..\..\build\common\Consts.cs" />
     <Compile Include="Assembly\AssemblyInfo.cs" />
+    <ProjectReference Include="$(SolutionDir)\msvc\scripts\genconsts.csproj">
+      <Name>genconsts</Name>
+      <Project>{702AE2C0-71DD-4112-9A06-E4FABCA59986}</Project>
+      <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
+      <CopyToOutputDirectory>Never</CopyToOutputDirectory>
+      <Private>False</Private>
+    </ProjectReference>
   </ItemGroup>
   <ItemGroup></ItemGroup>
   <!-- @ALL_SOURCES@ -->
-- 
cgit v1.2.3