diff options
author | Lluis Sanchez <lluis@xamarin.com> | 2019-05-31 09:51:40 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-05-31 09:51:40 +0300 |
commit | f391b0b867dea144eb2b3a32fd534a833c00bac3 (patch) | |
tree | a1507bec423fc6d0fc91cbc9c3f3bae159fa5d9f | |
parent | dcdca1cb620e9816f68aa2c7318db3bb102dc12f (diff) | |
parent | 29ee68bf24b0bcec9e198fe6b4b4c4245fbac893 (diff) |
Merge pull request #7742 from mono/Therzok-patch-1
[Mac] ObjCMarshalledException is still not reported right
-rw-r--r-- | main/src/addins/MacPlatform/MacPlatform.cs | 2 | ||||
-rw-r--r-- | main/tests/MacPlatform.Tests/MacPlatformTest.cs | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/main/src/addins/MacPlatform/MacPlatform.cs b/main/src/addins/MacPlatform/MacPlatform.cs index 0b9a6d51d5..d60c4f79c8 100644 --- a/main/src/addins/MacPlatform/MacPlatform.cs +++ b/main/src/addins/MacPlatform/MacPlatform.cs @@ -251,7 +251,7 @@ namespace MonoDevelop.MacIntegration try { throw new MarshalledObjCException (nsException); } catch (MarshalledObjCException e) { - LoggingService.LogInternalError ("Unhandled ObjC Exception", e); + LoggingService.LogFatalError ("Unhandled ObjC Exception", e); // Is there a way to figure out if it's going to crash us? Maybe check MarshalObjectiveCExceptionMode and MarshalManagedExceptionMode? } diff --git a/main/tests/MacPlatform.Tests/MacPlatformTest.cs b/main/tests/MacPlatform.Tests/MacPlatformTest.cs index b164e87878..c285aac1c5 100644 --- a/main/tests/MacPlatform.Tests/MacPlatformTest.cs +++ b/main/tests/MacPlatform.Tests/MacPlatformTest.cs @@ -181,7 +181,7 @@ namespace MacPlatform.Tests public void CriticalErrorsExceptionsHaveFullStacktracesInLog () { var logger = new CapturingLogger { - EnabledLevel = EnabledLoggingLevel.Error, + EnabledLevel = EnabledLoggingLevel.Fatal, }; try { @@ -192,7 +192,7 @@ namespace MacPlatform.Tests Assert.Throws<ObjCException> (() => void_objc_msgSend (ex.Handle, selector)); - var (_, message) = logger.LogMessages.Single (x => x.Level == LogLevel.Error); + var (_, message) = logger.LogMessages.Single (x => x.Level == LogLevel.Fatal); AssertMacPlatformStacktrace (message); } finally { LoggingService.RemoveLogger (logger.Name); |