String optimizations (#1881)

* [Core] Remove ToLower where applicable.

* [Core] Remove ToUpper where applicable.

* [View] Fix possible crash in no selection tolower/toupper

Instead of getting just 1 char, we get a possible huge string, depending on the caret's offset in a document.

* [Ide] Fix lots of intermediate strings being created on keybindings panel filtering

* [Ide] Remove string.ToLower where applicable.

* [Ide] Remove string.ToUpper where applicable.

* [Editor] Remove string.ToLower where applicable.

* [Addins] Remove string.ToLower string.ToUpper where applicable.

1 files changed, 1 insertions, 5 deletions

diff --git a/main/src/addins/MonoDevelop.Gettext/MonoDevelop.Gettext.Editor/POEditorWidget.cs b/main/src/addins/MonoDevelop.Gettext/MonoDevelop.Gettext.Editor/POEditorWidget.cs
index 46924c50e8..8907f4414a 100644
--- a/main/src/addins/MonoDevelop.Gettext/MonoDevelop.Gettext.Editor/POEditorWidget.cs
+++ b/main/src/addins/MonoDevelop.Gettext/MonoDevelop.Gettext.Editor/POEditorWidget.cs
@@ -752,9 +752,7 @@ namespace MonoDevelop.Gettext
 			if (RegexSearch)
 				return regex.IsMatch (text);
 		
-			if (!IsCaseSensitive)
-				text = text.ToUpper ();
-			int idx = text.IndexOf (filter);
+			int idx = text.IndexOf (filter, IsCaseSensitive ? StringComparison.Ordinal : StringComparison.OrdinalIgnoreCase);
 			if (idx >= 0) {
 				if (IsWholeWordOnly) {
 					return (idx == 0 || char.IsWhiteSpace (text[idx - 1])) &&
@@ -804,8 +802,6 @@ namespace MonoDevelop.Gettext
 		void UpdateFromCatalog ()
 		{
 			filter = this.searchEntryFilter.Entry.Text;
-			if (!IsCaseSensitive && filter != null)
-				filter = filter.ToUpper ();
 			if (RegexSearch) {
 				try {
 					RegexOptions options = RegexOptions.Compiled;