diff options
| author | Marius Ungureanu <teromario@yahoo.com> | 2017-03-28 20:47:27 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-03-28 20:47:27 +0300 |
| commit | 522676ea6126e743df6b108a194dc155f4e8519e (patch) | |
| tree | ac459b894ab7dd2beb272715b5e4a96dd86374a0 /main/src/addins/VersionControl | |
| parent | 6e309ed367ebe2719c26e80409f43e2f88a7f019 (diff) | |
Misc opt (#1960)
* [Core] Remove superfluous ToCharArray.
* [Perf] Optimize StringBuilder usage
Go through StringBuilder.Append(string) and StringBuilder.Append(object)
usages. As follows, we no longer concat strings before appending to a
stringbuilder, and we no longer box valueTypes which go through
Append(object).
* [Perf] Optimize StringBuilder.AppendLine
Most notable improvements are in AssemblyBrowser and Diff calculation.
* Fix feedback.
Diffstat (limited to 'main/src/addins/VersionControl')
2 files changed, 2 insertions, 2 deletions
diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion/SubversionRepository.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion/SubversionRepository.cs index 962742541b..23b8a6ba74 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion/SubversionRepository.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl.Subversion/MonoDevelop.VersionControl.Subversion/SubversionRepository.cs @@ -596,7 +596,7 @@ namespace MonoDevelop.VersionControl.Subversion else
relpath = diff.FileName;
relpath = relpath.Replace (Path.DirectorySeparatorChar, '/');
- patch.AppendLine ("Index: " + relpath);
+ patch.Append ("Index: ").AppendLine (relpath);
patch.AppendLine (new string ('=', 67));
patch.AppendLine (diff.Content);
}
diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl.Views/LogWidget.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl.Views/LogWidget.cs index d802e574ca..0fa3659950 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl.Views/LogWidget.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl.Views/LogWidget.cs @@ -773,7 +773,7 @@ namespace MonoDevelop.VersionControl.Views int last = 0; while (i != -1) { sb.Append (GLib.Markup.EscapeText (txt.Substring (last, i - last))); - sb.Append ("<span color='" + Styles.LogView.SearchSnippetTextColor + "'>").Append (txt, i, filter.Length).Append ("</span>"); + sb.Append ("<span color='").Append (Styles.LogView.SearchSnippetTextColor).Append ("'>").Append (txt, i, filter.Length).Append ("</span>"); last = i + filter.Length; i = txt.IndexOf (filter, last, StringComparison.CurrentCultureIgnoreCase); } |