diff options
author | iain holmes <iain@xamarin.com> | 2019-06-06 18:46:35 +0300 |
---|---|---|
committer | iain holmes <iain@xamarin.com> | 2019-06-06 18:46:35 +0300 |
commit | 788db1611148a030de9df8b2ae09eb453aa69e94 (patch) | |
tree | 9795f351a2ed1476df517d12534ca9b3f2c8ad79 /main/src/addins | |
parent | c7b4e384c9b2edeef0ca1299fa10f71fe139687e (diff) |
[Mac] Don't resize the window frame when placing the window
Calling setFrame on the NSWindow resizes the window, but not the Gtk contents causing offset issues in 8.1
There appears to be a race condition caused by making the startup sequence more async than in previous versions. This is triggered by starting MonoDevelop from Finder by double clicking on a solution file. The call to Ide.OpenFilesAsync occurs
earlier in the startup sequence now, and the call to Workbench.Present causes the error. Workbench.Show is called later in
the method by OpenWorkbenchItem, and if we remove the first call to Workbench.Present, then the workbench window opens
correctly, but slightly later. I am still tracking this down, but removing this setFrame call seems to be the least
dangerous fix for this bug until we fully understand what is going on.
Fixes VSTS #900933
Diffstat (limited to 'main/src/addins')
-rw-r--r-- | main/src/addins/MacPlatform/MacPlatform.cs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/main/src/addins/MacPlatform/MacPlatform.cs b/main/src/addins/MacPlatform/MacPlatform.cs index d60c4f79c8..90116f6d53 100644 --- a/main/src/addins/MacPlatform/MacPlatform.cs +++ b/main/src/addins/MacPlatform/MacPlatform.cs @@ -1281,7 +1281,7 @@ namespace MonoDevelop.MacIntegration y += GetTitleBarHeight (w); var dr = FromDesktopRect (new Gdk.Rectangle (x, y, width, height)); var r = w.FrameRectFor (dr); - w.SetFrame (r, true); + base.PlaceWindow (window, x, y, width, height); } |