[Ide] Optimize DockContainer.ForAll

Get rid of the intermediate list that's used to collect the widgets to use the callback on. Shaves a few milliseconds on each ForAll call (pretty often)

1 files changed, 6 insertions, 9 deletions

diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.Docking/DockContainer.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.Docking/DockContainer.cs
index 02d677b87b..a606782e93 100644
--- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.Docking/DockContainer.cs
+++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.Docking/DockContainer.cs
@@ -171,21 +171,18 @@ namespace MonoDevelop.Components.Docking
 		
 		protected override void ForAll (bool include_internals, Gtk.Callback callback)
 		{
-			List<Widget> widgets = new List<Widget> ();
 			foreach (Widget w in notebooks)
-				widgets.Add (w);
+				callback (w);
 			foreach (DockItem it in items) {
 				if (it.HasWidget && it.Widget.Parent == this) {
-					widgets.Add (it.Widget);
+					callback (it.Widget);
 					if (it.TitleTab.Parent == this)
-						widgets.Add (it.TitleTab);
+						callback (it.TitleTab);
 				}
 			}
-			foreach (var s in splitters.Where (w => w.Parent != null))
-				widgets.Add (s);
-
-			foreach (Widget w in widgets)
-				callback (w);
+			foreach (var s in splitters)
+				if (s.Parent != null)
+					callback (s);
 		}
 		
 		protected override bool OnExposeEvent (Gdk.EventExpose evnt)