diff options
author | Mike Krüger <mkrueger@xamarin.com> | 2017-02-01 18:51:26 +0300 |
---|---|---|
committer | Mike Krüger <mkrueger@xamarin.com> | 2017-02-02 11:33:22 +0300 |
commit | 2f4dd1b6027a0b803e198358b0f689ecf7ca54ff (patch) | |
tree | 43edb2486759a5ec28ff2d322358dc3c24523437 /main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion | |
parent | 26ad42f934f962a4c11f02e129e0461be2e96ed9 (diff) |
Revert "[Ide] Fixed a run completion command issue."
This reverts commit 3b426daf3a84de64a649db026c61e41b58c72c06.
Diffstat (limited to 'main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion')
3 files changed, 6 insertions, 8 deletions
diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CodeCompletionContext.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CodeCompletionContext.cs index 88df9a4a70..27de45aea2 100644 --- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CodeCompletionContext.cs +++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CodeCompletionContext.cs @@ -27,7 +27,6 @@ using System; using MonoDevelop.Projects; using Gtk; -using MonoDevelop.Core.Text; namespace MonoDevelop.Ide.CodeCompletion { @@ -41,8 +40,6 @@ namespace MonoDevelop.Ide.CodeCompletion public int TriggerTextHeight { get; set; } public int TriggerWordLength { get; set; } - public ITextSourceVersion Version { get; set; } - public override string ToString () { return string.Format ("[CodeCompletionContext: TriggerOffset={0}, TriggerLine={1}, TriggerLineOffset={2}, TriggerXCoord={3}, TriggerYCoord={4}, TriggerTextHeight={5}, TriggerWordLength={6}]", TriggerOffset, TriggerLine, TriggerLineOffset, TriggerXCoord, TriggerYCoord, TriggerTextHeight, TriggerWordLength); diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CompletionDataList.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CompletionDataList.cs index 627544b8ce..f9e54f8cb6 100644 --- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CompletionDataList.cs +++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CompletionDataList.cs @@ -81,7 +81,7 @@ namespace MonoDevelop.Ide.CodeCompletion public class CompletionDataList : List<CompletionData>, ICompletionDataList { public int TriggerWordStart { get; set; } = -1; - public int TriggerWordLength { get; set; } = -1; + public int TriggerWordLength { get; set; } public bool IsSorted { get; set; } public IComparer<CompletionData> Comparer { get; set; } diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CompletionListWindow.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CompletionListWindow.cs index 7262320522..a3f8137db4 100644 --- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CompletionListWindow.cs +++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.CodeCompletion/CompletionListWindow.cs @@ -683,8 +683,9 @@ namespace MonoDevelop.Ide.CodeCompletion AutoCompleteEmptyMatchOnCurlyBrace = list.AutoCompleteEmptyMatchOnCurlyBrace; CloseOnSquareBrackets = list.CloseOnSquareBrackets; // makes control-space in midle of words to work + string text = CompletionWidget.GetCompletionText (CodeCompletionContext); DefaultCompletionString = completionDataList.DefaultCompletionString ?? ""; - if (completionContext.TriggerWordLength == 0) { + if (text.Length == 0) { UpdateWordSelection (); initialWordLength = 0; //completionWidget.SelectedLength; @@ -702,8 +703,8 @@ namespace MonoDevelop.Ide.CodeCompletion return true; } - initialWordLength = CompletionWidget.SelectedLength > 0 ? 0 : completionContext.TriggerWordLength; - StartOffset = completionContext.TriggerOffset; + initialWordLength = CompletionWidget.SelectedLength > 0 ? 0 : text.Length; + StartOffset = CompletionWidget.CaretOffset - initialWordLength; HideWhenWordDeleted = initialWordLength != 0; ResetSizes (); UpdateWordSelection (); @@ -816,7 +817,7 @@ namespace MonoDevelop.Ide.CodeCompletion AddWordToHistory (PartialWord, cdItem.CompletionText); OnWordCompleted (new CodeCompletionContextEventArgs (CompletionWidget, CodeCompletionContext, cdItem.CompletionText)); */
- if (item.HasOverloads && declarationviewwindow != null && declarationviewwindow.CurrentOverload >= 0 && declarationviewwindow.CurrentOverload < item.OverloadedData.Count) { + if (item.HasOverloads && declarationviewwindow.CurrentOverload >= 0 && declarationviewwindow.CurrentOverload < item.OverloadedData.Count) { item.OverloadedData[declarationviewwindow.CurrentOverload].InsertCompletionText (facade, ref ka, descriptor); } else { item.InsertCompletionText (facade, ref ka, descriptor); |