Async/await optimizations (#1861)

* [Core] Async/await optimizations

Remove async/await where not needed.
Add ConfigureAwait for all awaits inside a Task.Run or wherever a method already did it.

* [Ide] Async/await optimizations

Remove async/await where not needed.
Add ConfigureAwait for all awaits inside a Task.Run or
wherever a method already did it.

* [Core] Add matching assert to Workspace.Build as Clean has one.

* [Core] Address feedback to 764e103fdc90288b0f56abafccbf95819b175200

* [Core] Address feedback to 764e103fdc90288b0f56abafccbf95819b175200

* [Core,Ide] Address feedback from PR.

* [Core, Ide] Revert async -> non-async conversion for methods which have throw statements.

* [Ide] Address feedback from PR.

1 files changed, 3 insertions, 3 deletions

diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Desktop/RecentFileStorage.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Desktop/RecentFileStorage.cs
index 06918d9e99..ce3e0d7adb 100644
--- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Desktop/RecentFileStorage.cs
+++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Desktop/RecentFileStorage.cs
@@ -239,8 +239,8 @@ namespace MonoDevelop.Ide.Desktop
 				// And we batch as many modifications as possible in a 1 second window.
 				if (recentSaveTask == null) {
 					recentSaveTask = Task.Run (async () => {
-						await Task.Delay (1000);
-						await SaveRecentFiles ();
+						await Task.Delay (1000).ConfigureAwait (false);
+						await SaveRecentFiles ().ConfigureAwait (false);
 					});
 				}
 			}
@@ -259,7 +259,7 @@ namespace MonoDevelop.Ide.Desktop
 				recentSaveTask = null;
 			}
 
-			using (var fs = await AcquireFileExclusive (filePath)) {
+			using (var fs = await AcquireFileExclusive (filePath).ConfigureAwait (false)) {
 				var list = ReadStore (fs);
 				bool modified = false;