Fixes VSTS Bug 905613: [Feedback] Cannot Copy Results of Find in Files (#7792)

…

https://devdiv.visualstudio.com/DevDiv/_workitems/edit/905613

AppendFormat was wrong there - CopyData is already formatted.
AppendFormat can easily throw an exception depending on the text
copied. This patch fixes it.

1 files changed, 9 insertions, 5 deletions

diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.FindInFiles/SearchResultWidget.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.FindInFiles/SearchResultWidget.cs
index 062551c243..c183d688ea 100644
--- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.FindInFiles/SearchResultWidget.cs
+++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.FindInFiles/SearchResultWidget.cs
@@ -630,14 +630,18 @@ namespace MonoDevelop.Ide.FindInFiles
 			var sb = new StringBuilder ();
 			foreach (TreePath p in treeviewSearchResults.Selection.GetSelectedRows (out model)) {
 				TreeIter iter;
-				if (!model.GetIter (out iter, p))
+				if (!model.GetIter (out iter, p)) {
 					continue;
+				}
 				var result = store.GetValue (iter, SearchResultColumn) as SearchResult;
-				if (result == null)
+				if (result == null) {
 					continue;
-
-				sb.AppendFormat (result.GetCopyData (this));
-				sb.AppendLine ();
+				}
+				try {
+					sb.AppendLine (result.GetCopyData (this));
+				} catch (Exception e) {
+					LoggingService.LogInternalError ("Error while getting copy data from search results", e);
+				}
 			}
 			Clipboard clipboard = Clipboard.Get (Atom.Intern ("CLIPBOARD", false));
 			clipboard.Text = sb.ToString ();