* src/addins/NUnit/Services/NUnitService.cs:

* src/addins/MonoDevelop.Autotools/TarballBuilderEditorWidget.cs:
* src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/DefaultWorkbench.cs:
* src/addins/MonoDevelop.Debugger/MonoDevelop.Debugger/DebuggingService.cs:
* src/addins/MonoDevelop.Refactoring/MonoDevelop.Refactoring/RefactoryCommands.cs:
* src/core/MonoDevelop.Ide/MonoDevelop.Components.PropertyGrid.Editors/CollectionEditor.cs:
* src/addins/MonoDevelop.Gettext/MonoDevelop.Gettext.NodeBuilders/TranslationProjectNodeBuilder.cs:
  Use ShowCustomDialog (which destroys the dialog when done) instead
  of RunCustomDialog (which doesn't).

* src/addins/MonoDevelop.WebReferences/MonoDevelop.WebReferences.Commands/WebReferenceCommandHandler.cs:
  Properly destroy the web reference dialog.

svn path=/trunk/monodevelop/; revision=157937

15 files changed, 58 insertions, 15 deletions

diff --git a/main/src/addins/MonoDevelop.Autotools/ChangeLog b/main/src/addins/MonoDevelop.Autotools/ChangeLog
index 78bed36d4b..9012cb89da 100644
--- a/main/src/addins/MonoDevelop.Autotools/ChangeLog
+++ b/main/src/addins/MonoDevelop.Autotools/ChangeLog
@@ -1,3 +1,9 @@
+2010-05-26  Lluis Sanchez Gual  <lluis@novell.com>
+
+	* TarballBuilderEditorWidget.cs: Use ShowCustomDialog (which
+	  destroys the dialog when done) instead of RunCustomDialog
+	  (which doesn't).
+
 2010-05-22  Michael Hutchinson  <mhutchinson@novell.com>
 
 	* Commands.cs:
diff --git a/main/src/addins/MonoDevelop.Autotools/TarballBuilderEditorWidget.cs b/main/src/addins/MonoDevelop.Autotools/TarballBuilderEditorWidget.cs
index 849954d888..edd2eebbdd 100644
--- a/main/src/addins/MonoDevelop.Autotools/TarballBuilderEditorWidget.cs
+++ b/main/src/addins/MonoDevelop.Autotools/TarballBuilderEditorWidget.cs
@@ -82,7 +82,7 @@ namespace MonoDevelop.Autotools
 		{
 			MakefileSwitchEditor editor = new MakefileSwitchEditor (target);
 			editor.ShowAll ();
-			MonoDevelop.Ide.MessageService.RunCustomDialog (editor, this.Toplevel as Gtk.Window);
+			MonoDevelop.Ide.MessageService.ShowCustomDialog (editor, this.Toplevel as Gtk.Window);
 		}
 	}
 }
diff --git a/main/src/addins/MonoDevelop.Debugger/ChangeLog b/main/src/addins/MonoDevelop.Debugger/ChangeLog
index c7bc3ff36e..d1d3ba1c42 100644
--- a/main/src/addins/MonoDevelop.Debugger/ChangeLog
+++ b/main/src/addins/MonoDevelop.Debugger/ChangeLog
@@ -1,3 +1,9 @@
+2010-05-26  Lluis Sanchez Gual  <lluis@novell.com>
+
+	* MonoDevelop.Debugger/DebuggingService.cs: Use
+	  ShowCustomDialog (which destroys the dialog when done)
+	  instead of RunCustomDialog (which doesn't).
+
 2010-05-25  Michael Hutchinson  <mhutchinson@novell.com>
 
 	* MonoDevelop.Debugger/DebugCommands.cs: More dialog placement
diff --git a/main/src/addins/MonoDevelop.Debugger/MonoDevelop.Debugger/DebuggingService.cs b/main/src/addins/MonoDevelop.Debugger/MonoDevelop.Debugger/DebuggingService.cs
index 40f7a75f4c..976b78a1e7 100644
--- a/main/src/addins/MonoDevelop.Debugger/MonoDevelop.Debugger/DebuggingService.cs
+++ b/main/src/addins/MonoDevelop.Debugger/MonoDevelop.Debugger/DebuggingService.cs
@@ -204,7 +204,7 @@ namespace MonoDevelop.Debugger
 		public static bool ShowBreakpointProperties (Breakpoint bp, bool editNew)
 		{
 			var dlg = new BreakpointPropertiesDialog (bp, editNew);
-			if (MessageService.RunCustomDialog (dlg) == (int) Gtk.ResponseType.Ok)
+			if (MessageService.ShowCustomDialog (dlg) == (int) Gtk.ResponseType.Ok)
 				return true;
 			return false;
 		}
@@ -276,7 +276,7 @@ namespace MonoDevelop.Debugger
 			ExpressionEvaluatorDialog dlg = new ExpressionEvaluatorDialog ();
 			if (expression != null)
 				dlg.Expression = expression;
-			MessageService.RunCustomDialog (dlg);
+			MessageService.ShowCustomDialog (dlg);
 		}
 		
 		public static void ShowExceptionCaughtDialog ()
@@ -290,7 +290,7 @@ namespace MonoDevelop.Debugger
 
 		public static void ShowExceptionsFilters ()
 		{
-			MessageService.RunCustomDialog (new ExceptionsDialog ());
+			MessageService.ShowCustomDialog (new ExceptionsDialog ());
 		}
 		
 		static void SetupSession ()
diff --git a/main/src/addins/MonoDevelop.Gettext/ChangeLog b/main/src/addins/MonoDevelop.Gettext/ChangeLog
index 31d22351d2..4ad813f4ea 100644
--- a/main/src/addins/MonoDevelop.Gettext/ChangeLog
+++ b/main/src/addins/MonoDevelop.Gettext/ChangeLog
@@ -1,3 +1,9 @@
+2010-05-26  Lluis Sanchez Gual  <lluis@novell.com>
+
+	* MonoDevelop.Gettext.NodeBuilders/TranslationProjectNodeBuilder.cs:
+	  Use ShowCustomDialog (which destroys the dialog when done)
+	  instead of RunCustomDialog (which doesn't).
+
 2010-05-22  Michael Hutchinson  <mhutchinson@novell.com>
 
 	* MonoDevelop.Gettext/GettextFeatureWidget.cs:
diff --git a/main/src/addins/MonoDevelop.Gettext/MonoDevelop.Gettext.NodeBuilders/TranslationProjectNodeBuilder.cs b/main/src/addins/MonoDevelop.Gettext/MonoDevelop.Gettext.NodeBuilders/TranslationProjectNodeBuilder.cs
index 66421c4bbb..ac4b50ce6e 100644
--- a/main/src/addins/MonoDevelop.Gettext/MonoDevelop.Gettext.NodeBuilders/TranslationProjectNodeBuilder.cs
+++ b/main/src/addins/MonoDevelop.Gettext/MonoDevelop.Gettext.NodeBuilders/TranslationProjectNodeBuilder.cs
@@ -121,7 +121,7 @@ namespace MonoDevelop.Gettext.NodeBuilders
 				TranslationProject project = CurrentNode.DataItem as TranslationProject;
 				if (project == null)
 					return;
-				MessageService.RunCustomDialog (new TranslationProjectOptionsDialog (project));
+				MessageService.ShowCustomDialog (new TranslationProjectOptionsDialog (project));
 				IdeApp.Workspace.Save ();
 			}
 			
diff --git a/main/src/addins/MonoDevelop.Refactoring/ChangeLog b/main/src/addins/MonoDevelop.Refactoring/ChangeLog
index a4ec4f9c24..49be513145 100644
--- a/main/src/addins/MonoDevelop.Refactoring/ChangeLog
+++ b/main/src/addins/MonoDevelop.Refactoring/ChangeLog
@@ -1,3 +1,9 @@
+2010-05-26  Lluis Sanchez Gual  <lluis@novell.com>
+
+	* MonoDevelop.Refactoring/RefactoryCommands.cs: Use
+	  ShowCustomDialog (which destroys the dialog when done)
+	  instead of RunCustomDialog (which doesn't).
+
 2010-05-25  Mike Krüger  <mkrueger@novell.com>
 
 	* gtk-gui/gui.stetic:
diff --git a/main/src/addins/MonoDevelop.Refactoring/MonoDevelop.Refactoring/RefactoryCommands.cs b/main/src/addins/MonoDevelop.Refactoring/MonoDevelop.Refactoring/RefactoryCommands.cs
index a8f8b340a9..cf6ee673cb 100644
--- a/main/src/addins/MonoDevelop.Refactoring/MonoDevelop.Refactoring/RefactoryCommands.cs
+++ b/main/src/addins/MonoDevelop.Refactoring/MonoDevelop.Refactoring/RefactoryCommands.cs
@@ -1051,7 +1051,7 @@ namespace MonoDevelop.Refactoring
 				editor.BeginAtomicUndo ();
 			
 			try {
-				MessageService.RunCustomDialog (new OverridesImplementsDialog ((IType)item));
+				MessageService.ShowCustomDialog (new OverridesImplementsDialog ((IType)item));
 			} finally {
 				if (editor != null)
 					editor.EndAtomicUndo ();
diff --git a/main/src/addins/MonoDevelop.WebReferences/ChangeLog b/main/src/addins/MonoDevelop.WebReferences/ChangeLog
index a3a5140362..995d05c35a 100644
--- a/main/src/addins/MonoDevelop.WebReferences/ChangeLog
+++ b/main/src/addins/MonoDevelop.WebReferences/ChangeLog
@@ -1,3 +1,8 @@
+2010-05-26  Lluis Sanchez Gual  <lluis@novell.com>
+
+	* MonoDevelop.WebReferences.Commands/WebReferenceCommandHandler.cs:
+	  Properly destroy the web reference dialog.
+
 2010-05-22  Michael Hutchinson  <mhutchinson@novell.com>
 
 	* MonoDevelop.WebReferences.Dialogs/WebReferenceDialog.cs:
diff --git a/main/src/addins/MonoDevelop.WebReferences/MonoDevelop.WebReferences.Commands/WebReferenceCommandHandler.cs b/main/src/addins/MonoDevelop.WebReferences/MonoDevelop.WebReferences.Commands/WebReferenceCommandHandler.cs
index 1453ab1eb3..c293256959 100644
--- a/main/src/addins/MonoDevelop.WebReferences/MonoDevelop.WebReferences.Commands/WebReferenceCommandHandler.cs
+++ b/main/src/addins/MonoDevelop.WebReferences/MonoDevelop.WebReferences.Commands/WebReferenceCommandHandler.cs
@@ -37,15 +37,16 @@ namespace MonoDevelop.WebReferences.Commands
 			WebReferenceDialog dialog = new WebReferenceDialog (project);
 			dialog.NamespacePrefix = project.Name;
 			
-			if (MessageService.RunCustomDialog (dialog) == (int)Gtk.ResponseType.Ok) {
-				try {
+			try {
+				if (MessageService.RunCustomDialog (dialog) == (int)Gtk.ResponseType.Ok) {
 					dialog.SelectedService.GenerateFiles (project, dialog.Namespace, dialog.ReferenceName);
 					IdeApp.ProjectOperations.Save(project);
 				}
-				catch(Exception exception)
-				{
-					MessageService.ShowException (exception);
-				}
+			} finally {
+				dialog.Destroy ();
+			}
+			catch(Exception exception) {
+				MessageService.ShowException (exception);
 			}
 		}
 		
diff --git a/main/src/addins/NUnit/ChangeLog b/main/src/addins/NUnit/ChangeLog
index 506eecb6a9..1fdb7b34c7 100644
--- a/main/src/addins/NUnit/ChangeLog
+++ b/main/src/addins/NUnit/ChangeLog
@@ -1,3 +1,9 @@
+2010-05-26  Lluis Sanchez Gual  <lluis@novell.com>
+
+	* Services/NUnitService.cs: Use ShowCustomDialog (which
+	  destroys the dialog when done) instead of RunCustomDialog
+	  (which doesn't).
+
 2010-05-22  Michael Hutchinson  <mhutchinson@novell.com>
 
 	* Services/NUnitService.cs: More dialog placing.
diff --git a/main/src/addins/NUnit/Services/NUnitService.cs b/main/src/addins/NUnit/Services/NUnitService.cs
index e0d5bf3aed..a4e319aed9 100644
--- a/main/src/addins/NUnit/Services/NUnitService.cs
+++ b/main/src/addins/NUnit/Services/NUnitService.cs
@@ -252,7 +252,7 @@ namespace MonoDevelop.NUnit
 		{
 			Properties properties = new Properties ();
 			properties.Set ("UnitTest", test);
-			MessageService.RunCustomDialog (new UnitTestOptionsDialog (IdeApp.Workbench.RootWindow, properties));
+			MessageService.ShowCustomDialog (new UnitTestOptionsDialog (IdeApp.Workbench.RootWindow, properties));
 		}
 		
 		void NotifyTestSuiteChanged ()
diff --git a/main/src/core/MonoDevelop.Ide/ChangeLog b/main/src/core/MonoDevelop.Ide/ChangeLog
index 7ed57ed93e..8c511d55a0 100644
--- a/main/src/core/MonoDevelop.Ide/ChangeLog
+++ b/main/src/core/MonoDevelop.Ide/ChangeLog
@@ -1,3 +1,10 @@
+2010-05-26  Lluis Sanchez Gual  <lluis@novell.com>
+
+	* MonoDevelop.Ide.Gui/DefaultWorkbench.cs:
+	* MonoDevelop.Components.PropertyGrid.Editors/CollectionEditor.cs:
+	  Use ShowCustomDialog (which destroys the dialog when done)
+	  instead of RunCustomDialog (which doesn't).
+
 2010-05-26  Michael Hutchinson  <mhutchinson@novell.com>
 
 	* MonoDevelop.Ide.Commands/FileCommands.cs:
diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.PropertyGrid.Editors/CollectionEditor.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.PropertyGrid.Editors/CollectionEditor.cs
index 397647b924..850e6a14f1 100644
--- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.PropertyGrid.Editors/CollectionEditor.cs
+++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.PropertyGrid.Editors/CollectionEditor.cs
@@ -269,7 +269,7 @@ namespace MonoDevelop.Components.PropertyGrid.PropertyEditors
 			#endregion

 			

 			//if 'OK' put items back in collection

-			if (MonoDevelop.Ide.MessageService.RunCustomDialog (dialog, toplevel) == (int)ResponseType.Ok)

+			if (MonoDevelop.Ide.MessageService.ShowCustomDialog (dialog, toplevel) == (int)ResponseType.Ok)

 			{
 				DesignerTransaction tran = CreateTransaction (Instance);
 				object old = collection;
diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/DefaultWorkbench.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/DefaultWorkbench.cs
index 8832e17bcc..8e97a94588 100644
--- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/DefaultWorkbench.cs
+++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui/DefaultWorkbench.cs
@@ -657,7 +657,7 @@ namespace MonoDevelop.Ide.Gui
 			if (showDirtyDialog) {
 				DirtyFilesDialog dlg = new DirtyFilesDialog ();
 				dlg.Modal = true;
-				if (MessageService.RunCustomDialog (dlg, this) != (int)Gtk.ResponseType.Ok)
+				if (MessageService.ShowCustomDialog (dlg, this) != (int)Gtk.ResponseType.Ok)
 					return false;
 			}