diff options
author | therzok <marius.ungureanu@xamarin.com> | 2017-10-17 19:16:03 +0300 |
---|---|---|
committer | Marius Ungureanu <teromario@yahoo.com> | 2017-10-27 14:43:43 +0300 |
commit | 7f1dfbcdbfadec40681f4c1de5309c6560f6566c (patch) | |
tree | 99b55f57c1a7c35c665013436df928f65adb556e /main | |
parent | 103c9cd0f2dbd6369e6104ec2ed3fadd16808009 (diff) |
Fix missing base.Dispose()
CID113109
CID113124
CID113125
CID113128
CID113138
CID113141
CID113163
CID113174
CID113177
CID167841
CID167848
CID167867
CID167873
CID168029
CID168067
Diffstat (limited to 'main')
14 files changed, 38 insertions, 0 deletions
diff --git a/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.NodeBuilders/DependenciesNodeBuilderExtension.cs b/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.NodeBuilders/DependenciesNodeBuilderExtension.cs index 3d0d807c76..737f0e749c 100644 --- a/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.NodeBuilders/DependenciesNodeBuilderExtension.cs +++ b/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.NodeBuilders/DependenciesNodeBuilderExtension.cs @@ -40,6 +40,8 @@ namespace MonoDevelop.DotNetCore.NodeBuilders protected override void Initialize () { + base.Initialize (); + packageManagementEvents = PackageManagementServices.PackageManagementEvents; packageManagementEvents.PackageOperationsFinished += PackageOperationsFinished; @@ -52,6 +54,8 @@ namespace MonoDevelop.DotNetCore.NodeBuilders packageManagementEvents.PackageOperationsFinished -= PackageOperationsFinished; IdeApp.Workspace.ReferenceAddedToProject -= OnReferencesChanged; IdeApp.Workspace.ReferenceRemovedFromProject -= OnReferencesChanged; + + base.Dispose (); } public override bool CanBuildNode (Type dataType) diff --git a/main/src/addins/MonoDevelop.GtkCore/MonoDevelop.GtkCore.NodeBuilders/ProjectNodeBuilder.cs b/main/src/addins/MonoDevelop.GtkCore/MonoDevelop.GtkCore.NodeBuilders/ProjectNodeBuilder.cs index b662ff382a..28b187f62b 100644 --- a/main/src/addins/MonoDevelop.GtkCore/MonoDevelop.GtkCore.NodeBuilders/ProjectNodeBuilder.cs +++ b/main/src/addins/MonoDevelop.GtkCore/MonoDevelop.GtkCore.NodeBuilders/ProjectNodeBuilder.cs @@ -50,6 +50,8 @@ namespace MonoDevelop.GtkCore.NodeBuilders protected override void Initialize () { + base.Initialize (); + lock (typeof (ProjectNodeBuilder)) instance = this; } @@ -58,6 +60,8 @@ namespace MonoDevelop.GtkCore.NodeBuilders { lock (typeof (ProjectNodeBuilder)) instance = null; + + base.Dispose (); } public override void BuildChildNodes (ITreeBuilder builder, object dataObject) diff --git a/main/src/addins/MonoDevelop.PackageManagement/MonoDevelop.PackageManagement.Gui/PackageSourcesOptionsPanel.cs b/main/src/addins/MonoDevelop.PackageManagement/MonoDevelop.PackageManagement.Gui/PackageSourcesOptionsPanel.cs index 40b46a884b..3cfaa190a9 100644 --- a/main/src/addins/MonoDevelop.PackageManagement/MonoDevelop.PackageManagement.Gui/PackageSourcesOptionsPanel.cs +++ b/main/src/addins/MonoDevelop.PackageManagement/MonoDevelop.PackageManagement.Gui/PackageSourcesOptionsPanel.cs @@ -192,6 +192,7 @@ namespace MonoDevelop.PackageManagement.Gui if (packageSourcesWidget != null) {
packageSourcesWidget.Dispose ();
}
+ base.Dispose ();
}
string GetGlobalNuGetConfigFileName ()
diff --git a/main/src/addins/MonoDevelop.PackageManagement/MonoDevelop.PackageManagement.NodeBuilders/ProjectPackagesProjectNodeBuilderExtension.cs b/main/src/addins/MonoDevelop.PackageManagement/MonoDevelop.PackageManagement.NodeBuilders/ProjectPackagesProjectNodeBuilderExtension.cs index e5a7b107ba..42e261f80a 100644 --- a/main/src/addins/MonoDevelop.PackageManagement/MonoDevelop.PackageManagement.NodeBuilders/ProjectPackagesProjectNodeBuilderExtension.cs +++ b/main/src/addins/MonoDevelop.PackageManagement/MonoDevelop.PackageManagement.NodeBuilders/ProjectPackagesProjectNodeBuilderExtension.cs @@ -105,6 +105,8 @@ namespace MonoDevelop.PackageManagement.NodeBuilders packageManagementEvents.PackageOperationsFinished -= PackageOperationsFinished;
packageManagementEvents.PackageOperationError -= PackageOperationError;
packageManagementEvents.UpdatedPackagesAvailable -= UpdatedPackagesAvailable;
+
+ base.Dispose ();
}
public override bool CanBuildNode (Type dataType)
diff --git a/main/src/addins/MonoDevelop.Packaging/MonoDevelop.Packaging.Gui/GtkCrossPlatformLibraryProjectTemplateWizardPageWidget.cs b/main/src/addins/MonoDevelop.Packaging/MonoDevelop.Packaging.Gui/GtkCrossPlatformLibraryProjectTemplateWizardPageWidget.cs index 20bf342324..ad4b94ac11 100644 --- a/main/src/addins/MonoDevelop.Packaging/MonoDevelop.Packaging.Gui/GtkCrossPlatformLibraryProjectTemplateWizardPageWidget.cs +++ b/main/src/addins/MonoDevelop.Packaging/MonoDevelop.Packaging.Gui/GtkCrossPlatformLibraryProjectTemplateWizardPageWidget.cs @@ -169,6 +169,8 @@ namespace MonoDevelop.Packaging.Gui { Dispose (nameTooltip); Dispose (backgroundImage); + + base.Dispose (); } void Dispose (IDisposable disposable) diff --git a/main/src/addins/MonoDevelop.Packaging/MonoDevelop.Packaging.Gui/GtkPackagingProjectTemplateWizardPageWidget.cs b/main/src/addins/MonoDevelop.Packaging/MonoDevelop.Packaging.Gui/GtkPackagingProjectTemplateWizardPageWidget.cs index 19bea34e70..23eb2f2a09 100644 --- a/main/src/addins/MonoDevelop.Packaging/MonoDevelop.Packaging.Gui/GtkPackagingProjectTemplateWizardPageWidget.cs +++ b/main/src/addins/MonoDevelop.Packaging/MonoDevelop.Packaging.Gui/GtkPackagingProjectTemplateWizardPageWidget.cs @@ -135,6 +135,8 @@ namespace MonoDevelop.Packaging.Gui { Dispose (idTooltip); Dispose (backgroundImage); + + base.Dispose (); } void Dispose (IDisposable disposable) diff --git a/main/src/addins/MonoDevelop.Refactoring/MonoDevelop.AnalysisCore/Gui/ResultsEditorExtension.cs b/main/src/addins/MonoDevelop.Refactoring/MonoDevelop.AnalysisCore/Gui/ResultsEditorExtension.cs index 480641fd64..cb8f1e63d7 100644 --- a/main/src/addins/MonoDevelop.Refactoring/MonoDevelop.AnalysisCore/Gui/ResultsEditorExtension.cs +++ b/main/src/addins/MonoDevelop.Refactoring/MonoDevelop.AnalysisCore/Gui/ResultsEditorExtension.cs @@ -82,6 +82,7 @@ namespace MonoDevelop.AnalysisCore.Gui while (markers.Count > 0) Editor.RemoveMarker (markers.Dequeue ()); disposed = true; + base.Dispose (); } bool enabled; diff --git a/main/src/addins/MonoDevelop.SourceEditor2/MonoDevelop.SourceEditor/SourceEditorView.cs b/main/src/addins/MonoDevelop.SourceEditor2/MonoDevelop.SourceEditor/SourceEditorView.cs index 1e38d1e5c1..696a5415b8 100644 --- a/main/src/addins/MonoDevelop.SourceEditor2/MonoDevelop.SourceEditor/SourceEditorView.cs +++ b/main/src/addins/MonoDevelop.SourceEditor2/MonoDevelop.SourceEditor/SourceEditorView.cs @@ -1111,6 +1111,8 @@ namespace MonoDevelop.SourceEditor RemoveMarkerQueue (); widget.Dispose (); this.Project = null; + + base.Dispose (); } bool CheckReadOnly (int line) diff --git a/main/src/core/MonoDevelop.Core/MonoDevelop.Core.Execution/MultipleOperationConsoles.cs b/main/src/core/MonoDevelop.Core/MonoDevelop.Core.Execution/MultipleOperationConsoles.cs index 5d3eebddf1..7e552f6899 100644 --- a/main/src/core/MonoDevelop.Core/MonoDevelop.Core.Execution/MultipleOperationConsoles.cs +++ b/main/src/core/MonoDevelop.Core/MonoDevelop.Core.Execution/MultipleOperationConsoles.cs @@ -88,6 +88,8 @@ namespace MonoDevelop.Core.Execution foreach (var console in consoles) { console.Dispose (); } + + base.Dispose (); } class MultipleTextWriters : TextWriter diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor.Extension/BraceMatcherTextEditorExtension.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor.Extension/BraceMatcherTextEditorExtension.cs index b95e323c55..8f788490c1 100644 --- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor.Extension/BraceMatcherTextEditorExtension.cs +++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor.Extension/BraceMatcherTextEditorExtension.cs @@ -106,6 +106,8 @@ namespace MonoDevelop.Ide.Editor.Extension DocumentContext.DocumentParsed -= HandleDocumentParsed; isSubscribed = false; } + + base.Dispose (); } void HandleDocumentParsed (object sender, EventArgs e) diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor.TextMate/TextMateIndentationTextEditorExtension.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor.TextMate/TextMateIndentationTextEditorExtension.cs index 11de6fb5c6..be8f590b2f 100644 --- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor.TextMate/TextMateIndentationTextEditorExtension.cs +++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor.TextMate/TextMateIndentationTextEditorExtension.cs @@ -32,6 +32,8 @@ namespace MonoDevelop.Ide.Editor.TextMate { protected override void Initialize () { + base.Initialize (); + Editor.MimeTypeChanged += Editor_MimeTypeChanged; Editor_MimeTypeChanged (this, EventArgs.Empty); } @@ -47,6 +49,8 @@ namespace MonoDevelop.Ide.Editor.TextMate public override void Dispose () { Editor.MimeTypeChanged -= Editor_MimeTypeChanged; + + base.Dispose (); } public override bool KeyPress (KeyDescriptor descriptor) diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ProjectNodeBuilder.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ProjectNodeBuilder.cs index f0e3b25b4c..f3de0ea42a 100644 --- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ProjectNodeBuilder.cs +++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ProjectNodeBuilder.cs @@ -55,6 +55,8 @@ namespace MonoDevelop.Ide.Gui.Pads.ProjectPad protected override void Initialize () { + base.Initialize (); + IdeApp.Workspace.FileAddedToProject += OnAddFile; IdeApp.Workspace.FileRemovedFromProject += OnRemoveFile; IdeApp.Workspace.FileRenamedInProject += OnRenameFile; @@ -71,6 +73,8 @@ namespace MonoDevelop.Ide.Gui.Pads.ProjectPad IdeApp.Workspace.FilePropertyChangedInProject -= OnFilePropertyChanged; IdeApp.Workspace.ActiveConfigurationChanged -= IdeAppWorkspaceActiveConfigurationChanged; FileService.FileRemoved -= OnSystemFileDeleted; + + base.Dispose (); } public override void OnNodeAdded (object dataObject) diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ProjectReferenceFolderNodeBuilder.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ProjectReferenceFolderNodeBuilder.cs index 0f2ba3af5f..e1f87cfd47 100644 --- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ProjectReferenceFolderNodeBuilder.cs +++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ProjectReferenceFolderNodeBuilder.cs @@ -55,6 +55,8 @@ namespace MonoDevelop.Ide.Gui.Pads.ProjectPad protected override void Initialize () { + base.Initialize (); + IdeApp.Workspace.ReferenceAddedToProject += OnAddReference; IdeApp.Workspace.ReferenceRemovedFromProject += OnRemoveReference; } @@ -63,6 +65,8 @@ namespace MonoDevelop.Ide.Gui.Pads.ProjectPad { IdeApp.Workspace.ReferenceAddedToProject -= OnAddReference; IdeApp.Workspace.ReferenceRemovedFromProject -= OnRemoveReference; + + base.Dispose (); } public override void BuildNode (ITreeBuilder treeBuilder, object dataObject, NodeInfo nodeInfo) diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ShowAllFilesBuilderExtension.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ShowAllFilesBuilderExtension.cs index 6bced26ac0..bed4ca3c4f 100644 --- a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ShowAllFilesBuilderExtension.cs +++ b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads.ProjectPad/ShowAllFilesBuilderExtension.cs @@ -57,6 +57,8 @@ namespace MonoDevelop.Ide.Gui.Pads.ProjectPad protected override void Initialize () { + base.Initialize (); + IdeApp.Workspace.FileAddedToProject += OnAddFile; IdeApp.Workspace.FileRemovedFromProject += OnRemoveFile; @@ -72,6 +74,8 @@ namespace MonoDevelop.Ide.Gui.Pads.ProjectPad FileService.FileRenamed -= OnSystemFileRenamed; FileService.FileRemoved -= OnSystemFileDeleted; FileService.FileCreated -= OnSystemFileAdded; + + base.Dispose (); } public override void OnNodeAdded (object dataObject) |