[F#] Fix Android project template compile tests

The tests that create Android projects and compile them were failing
with 'The OutputPath property is not set for project'. This was
because the projects were saved after NuGet packages were installed.
The new Android projects use the Xamarin.Build.Download NuGet package
which adds a .props Import at the start of the project file. Saving
the Android project after this NuGet package was added would result
in the Xamarin.Android.FSharp.targets Import being added at the top
of the project file, since similar elements are grouped together.
The Xamarin.Android.FSharp.targets Import needs to be at the end of
the project file. Saving the project before adding the NuGet
packages fixes this problem.

1 files changed, 8 insertions, 2 deletions

diff --git a/main/external/fsharpbinding/MonoDevelop.FSharp.Tests/TemplateTests.fs b/main/external/fsharpbinding/MonoDevelop.FSharp.Tests/TemplateTests.fs
index b4e8820784..5b10ccab5f 100644
--- a/main/external/fsharpbinding/MonoDevelop.FSharp.Tests/TemplateTests.fs
+++ b/main/external/fsharpbinding/MonoDevelop.FSharp.Tests/TemplateTests.fs
@@ -99,9 +99,15 @@ type ``Template tests``() =
 
             let projects = sln.Items |> Seq.filter(fun i -> i :? DotNetProject) |> Seq.cast<DotNetProject> |> List.ofSeq
 
-
-            do! NuGetPackageInstaller.InstallPackages (sln, projectTemplate.PackageReferencesForCreatedProjects)
+            // Save solution before installing NuGet packages to prevent any Imports from being added
+            // in the wrong place. Android projects now use the Xamarin.Build.Download NuGet package which
+            // will add its own .props Import at the top of the project file. Saving the project the first time
+            // after installing this NuGet package results in the Xamarin.Android.FSharp.targets Import being
+            // added at the top of the project which causes a compile error about the OutputType not being defined.
+            // This is because the Import is grouped with the Xamarin.Build.Download .props Import which is inserted
+            // at the top of the project file.
             do! sln.SaveAsync(monitor)
+            do! NuGetPackageInstaller.InstallPackages (sln, projectTemplate.PackageReferencesForCreatedProjects)
 
             let getErrorsForProject (projects: DotNetProject list) =
                 asyncSeq {