diff options
| author | Javier Suárez Ruiz <javiersuarezruiz@hotmail.com> | 2019-03-04 15:42:22 +0300 |
|---|---|---|
| committer | monojenkins <jo.shields+jenkins@xamarin.com> | 2019-03-08 11:21:13 +0300 |
| commit | fbf6c39da8c2ce41b539a79c3e248621224dc287 (patch) | |
| tree | dabf0fd1cd2a05962d8ffb31d268c8b8608221a0 /main | |
| parent | 177c098d4abe09abf043e3ec9a2bb380680e92f8 (diff) | |
Changes based on PR feedback
Diffstat (limited to 'main')
2 files changed, 5 insertions, 20 deletions
diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlService.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlService.cs index a6b82a5023..4d636d5501 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlService.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlService.cs @@ -113,7 +113,7 @@ namespace MonoDevelop.VersionControl if (args.Change == ExtensionChange.Add) { IComparer<VersionControlSystem> compare = new CompareVersionControlSystem (); - handlers.Sort (compare.Compare); + int search = handlers.BinarySearch (vcs, compare); if (search < 0) diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlSystem.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlSystem.cs index 5f46d8a233..46a42844ab 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlSystem.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlSystem.cs @@ -134,31 +134,16 @@ namespace MonoDevelop.VersionControl if (ReferenceEquals (vcs1, vcs2)) { result = 0; } else { - if (vcs1 == null) { + if (vcs1 is null) { result = 1; - } else if (vcs2 == null) { + } else if (vcs2 is null) { result = -1; } else { - result = StringCompare (vcs1.Name, vcs2.Name); + result = string.Compare(vcs1.Name, vcs2.Name, StringComparison.InvariantCultureIgnoreCase); } } return result; } - - int StringCompare (string strFirstString, string secondString) - { - int result; - if (strFirstString == null) { - if (secondString == null) { - result = 0; - } else { - result = 1; - } - } else { - result = string.Compare(strFirstString, secondString, StringComparison.InvariantCultureIgnoreCase); - } - return result; - } } -} +}
\ No newline at end of file |