| Age | Commit message (Collapse) | Author |
|---|
|
[Mac] Improve startup reason detection
|
|
|
|
.. after use.
Fixes VSTS #1050360 - `MultiTargetFramework_ReloadProject_TargetFrameworksChanged`
In the test, the project file `multi-target.csproj` was loaded in
`using (var sol = (Solution)await Services.ProjectService.ReadWorkspaceItem (Util.GetMonitor (), solFile))`
.. `main/src/core/MonoDevelop.Core/MonoDevelop.Projects/SdkProjectReader.cs`,
- but the StreamReader for the file was not disposed
- causing a subsequent attempt to overwrite the file to fail
with a sharing violation error.
```
1) MultiTargetFramework_ReloadProject_TargetFrameworksChanged (MonoDevelop.Ide.TypeSystem.TypeSystemServiceTests.MultiTargetFramework_ReloadProject_TargetFrameworksChanged)
System.IO.IOException : Sharing violation on path /Users/runner/runners/2.164.1/work/r1/a/VS for Mac/drop/tests/tmp/multi-target.sln-18/multi-target.csproj
at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize, System.Boolean anonymous, System.IO.FileOptions options) [0x00259] in /Users/builder/jenkins/workspace/build-package-osx-mono/2019-12/external/bockbuild/builds/mono-x64/mcs/class/corlib/System.IO/FileStream.cs:274
at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize, System.IO.FileOptions options) [0x00000] in /Users/builder/jenkins/workspace/build-package-osx-mono/2019-12/external/bockbuild/builds/mono-x64/mcs/class/corlib/System.IO/FileStream.cs:106
at (wrapper remoting-invoke-with-check) System.IO.FileStream..ctor(string,System.IO.FileMode,System.IO.FileAccess,System.IO.FileShare,int,System.IO.FileOptions)
at System.IO.StreamWriter..ctor (System.String path, System.Boolean append, System.Text.Encoding encoding, System.Int32 bufferSize) [0x00055] in /Users/builder/jenkins/workspace/build-package-osx-mono/2019-12/external/bockbuild/builds/mono-x64/external/corefx/src/Common/src/CoreLib/System/IO/StreamWriter.cs:151
at System.IO.StreamWriter..ctor (System.String path) [0x00000] in /Users/builder/jenkins/workspace/build-package-osx-mono/2019-12/external/bockbuild/builds/mono-x64/external/corefx/src/Common/src/CoreLib/System/IO/StreamWriter.cs:126
at (wrapper remoting-invoke-with-check) System.IO.StreamWriter..ctor(string)
at System.IO.File.WriteAllText (System.String path, System.String contents) [0x00026] in /Users/builder/jenkins/workspace/build-package-osx-mono/2019-12/external/bockbuild/builds/mono-x64/external/corefx/src/System.IO.FileSystem/src/System/IO/File.cs:314
at MonoDevelop.Ide.TypeSystem.TypeSystemServiceTests.MultiTargetFramework_ReloadProject_TargetFrameworksChanged () [0x00258] in /Users/runner/runners/2.164.1/work/1/s/monodevelop/main/tests/Ide.Tests/MonoDevelop.Ide.TypeSystem/TypeSystemServiceTests.cs:278
at MonoDevelop.Ide.TypeSystem.TypeSystemServiceTests.MultiTargetFramework_ReloadProject_TargetFrameworksChanged () [0x002a4] in /Users/runner/runners/2.164.1/work/1/s/monodevelop/main/tests/Ide.Tests/MonoDevelop.Ide.TypeSystem/TypeSystemServiceTests.cs:282
```
Debugged+resolved with: Matt Ward (@mrward)
Debugged in https://github.com/mono/monodevelop/pull/9540
This was also consistently seen with the mono 6.10.0x bump in
https://github.com/xamarin/md-addins/pull/6037 .
|
|
|
|
|
|
[Ide] Improve ImageService.CustomImageLoader
|
|
Added a feature switch to allow the license acceptance dialog
to be disabled. This can be done by setting the environment
variable:
MD_FEATURES_DISABLED=NuGetLicenseAcceptanceDialog
By default the license acceptance dialog will be displayed. The
feature switch can be used by automation tests to disable the
dialog and the license acceptance for the NuGet package will
occur without the user being prompted.
Fixes VSTS #1036006 - Disable license acceptance dialog with
feature switch
|
|
Switch ConditionedPropertyCollection to use ImmutableArray
|
|
Remove various references to NRefactory that are not used
|
|
Fixes VSTS Bug 1027415: [FATAL] SigTerm signal in MonoDevelop.VersionControl.Git.dll!MonoDevelop.VersionControl.Git.GitRepository::Dispose+49
|
|
|
|
* [Mac] Set Marshal*Exception modes
This should prevent hard crashing when working with exception handling in xammac
* Remove these
* Modify tests
|
|
[NuGet] Register credential providers coming from secure plugins
|
|
Deleting a file from the Solution pad would sometimes add a Remove
item for that file which should only happen if the file was excluded
from the project. A way to reproduce this is to start the IDE,
create a new .NET Standard project, then right click the Class1.cs
file in the Solution pad, and select Delete. Loading an existing
solution does not seem to reproduce this.
The problem is that the file is deleted from disk after the file is
removed from the Project.Files collection. The removal of the file
causes the type system service to request updated project information.
This can then cause the project file to be updated in memory before
the file is deleted from disk. Since the file exists on disk the
Project.SaveProjectItems method adds a Remove item since it is
treating the file as been excluded. This Remove item will not be
removed when the file is deleted from disk and the project is saved
later since it is not possible to distinguish this case from the case
where a file has been explicitly excluded.
To fix this the simplest approach is to delete the file before
modifying the project's Files collection. Also fixed this problem
that can occur when deleting a folder.
Fixes VSTS #593642 - Deleting file from SDK style project adds
unnecessary data into csproj file
|
|
|
|
Switch to Task.CompletedTask where applicable
|
|
To log errors in case the readers throw
|
|
|
|
|
|
|
|
Also switched collections to List<T>, CollectionBase does not deserialize properly
|
|
|
|
MonoDevelop.VersionControl.Git.dll!MonoDevelop.VersionControl.Git.GitRepository::Dispose+49
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1027415
Hard to reproduce the issue (only 4 Hits). The GitConfigurationDialog
does some long running operations where the cancellation token isn't
passed to these. That got fixed.
But the main issue is the Dispose that could dead lock on the
GitRepository. Since destroy is done on the dedicated operation thread
it may dead lock in some situations.
That can only happen if something long running blocks the
DedicatedOperationFactory. Now the DedicatedOperationFactory
operations get linked to the disposeToken which should cancel these
operations.
But all actions need to get the combined token and use that for their
cancellations.
|
|
mono/intellisense-broken-after-adding-multi-frameworks-to-project
[Ide] Fix intellisense not updated after adding target frameworks
|
|
[Core] Stop using obsolete Counter++/-- and use Inc(1) or Dec(1) instead
|
|
[VCS] Add a11y titles to Diff view
|
|
* sort resources by name, to ensure same sequence for all icons
* use a global static dictionary for loaded resources
* filter by requested name to avoid Xwt.Image parser scanning all resources over and over again
|
|
The file watcher seems to sometimes produce strange events which
look like a directory being renamed to a file. This can cause the
IDE to believe the solution file has been deleted since the file
service will raise a FileRemoved event for a rename. To avoid this
check that the directory does not exist and if it does the FileRemoved
event is not fired with this type of rename.
Fixes VSTS #1027550 - VSMac keeps closing my solution
|
|
|
|
|
|
With the enabling of launchSettings.json support for Worker services,
we added support, by mistake, to run it on the user's installed
browsers, which is wrong, as Worker services are just console
applications.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1050466
|
|
|
|
|
|
Fixes VSTS 1005823: Adds icon for Go To Line navigation UI.
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1005823
|
|
If a multi-run configuration is selected in the main toolbar and a
project is reloaded a crash can occur since the main toolbar has not
updated its project mappings. Exception thrown:
System.Collections.Generic.KeyNotFoundException: The given key
'MonoDevelop.CSharp.Project.CSharpProject' was not present in the
dictionary.
System.ThrowHelper.GetKeyNotFoundException(Object)
System.ThrowHelper.ThrowKeyNotFoundException(Object)
System.Collections.Generic.Dictionary`2[[MonoDevelop.Projects.SolutionItem],[MonoDevelop.Components.MainToolbar.ConfigurationMerger]].get_Item(SolutionItem)
MonoDevelop.Components.MainToolbar.MainToolbarController.FillRuntimesForProject(List`1,SolutionItem,Int32&)
MonoDevelop.Components.MainToolbar.MainToolbarController.FillRuntimes()
MonoDevelop.Components.MainToolbar.MainToolbarController.NotifyConfigurationChange()
MonoDevelop.Components.MainToolbar.MainToolbarController.HandleRuntimeChanged(Object,HandledEventArgs)
The problem was that on reloading the main toolbar's configurationMerger
dictionary was not updated. It still contained the old disposed project
so the dictionary lookup would fail for the new reloaded project. To
fix this when a project is reloaded the main toolbar's dictionary is
now refreshed.
Repro:
1. Create a solution with two projects.
2. Create a multiple startup run configuration with both projects.
3. Select the multi run configuration in the toolbar.
4. Edit one of the project files in the editor and save a change.
5. Change from Debug to Release in the main toolbar.
Fixes VSTS #944654 - [FATAL] System.Collections.Generic.KeyNotFoundException
exception in System.ThrowHelper.GetKeyNotFoundException()
|
|
The AppDelegate always knows the startup reason, so check if it there as a
fallback if we missed the startup notification
Fixes VSTS #984249
|
|
Fix 822175: Exception adornment scrolled outside of view
|
|
Update BinaryCompatBaseline.txt
|
|
bumped debugger-libs for fixes to the stepping timers
|
|
Fixes VSTS Bug 1042154: Wrong accessibility translations
|
|
Fixes VSTS #810330
|
|
With check for updates enabled, and the NuGet command line credential
provider using the session token cache, when the Manage Packages dialog
was opened the dialog asking for a username and password would be
displayed. The problem was that the NuGet credential service puts itself
into retry mode when it is used. The retry flag is then set to true and
was passed to the credential provider. The credential provider sees this
is a retry and clears the session token cache so the token for the
package source is not used. This then results in the credential prompt.
To fix this the retry cache is reset on opening the dialog. It looks
like this change was lost on switching to the manage packages dialog:
ec92ab06b697236ed8e3ec43bb8fd9b8a428fe1a
|
|
Update Binary Compatibility Check to reflect the changes in Xamarin.Mac due to the import of HttpClient implementation from CoreFX https://github.com/xamarin/xamarin-macios/commit/5d4ada34c798ca6d84023b42f2bb7e5dfa77dede#diff-450d8ab830620cd9e57f8be5c8f2c625L361-R361
|
|
|
|
|
|
[DotNetCore] Ignore unsupported SDKs in template wizard
|
|
mono/jstedfast-debugger-vscode-logging-getalllocals
[VsCodeDebugger] Log errors for GetAllLocals
|
|
An object that derives from CustomTypeDescriptor would not show the
custom properties in the new native property editor but would with
the old property editor.
The problem was that the type was being passed to the TypeDescriptor's
GetProperties method instead of the object providing the properties.
Fixes VSTS #1047889 - New Property Editor does not support
CustomTypeDescriptors
|
|
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1042154
|
