| Age | Commit message (Collapse) | Author |
|---|
|
[C#] Support CodeAnalysisRuleSet file
|
|
Remove various references to NRefactory that are not used
|
|
Switch to Task.CompletedTask where applicable
|
|
|
|
|
|
Adding a new project to an existing solution would trigger a null
reference exception in the CSharpCompilerParameters when the type
system service tried to use the project's configuration. This was then
breaking code completion for the NUnit library project when it was
added to an existing solution.
This was due to a change 18cf33d1855592cbdb2f54e7e0a4870f99a11485 where
the OutputType was only being set if the project file was read from disk
which is not the case when adding a new project from a template to an
existing solution.
Fixes VSTS #1048443 - No intellisense for NUnit types when adding a new
NUnit project to an existing solution
|
|
NoWarn settings for suppressing warnings was not overridding the
configuration defined in the ruleset. This was incorrect based on the
Visual Studio on Windows behaviour.
|
|
If the CodeAnalysisRuleSet MSBuild property points to a file then
the ruleset information is applied to the project configuration's
compilater options.
Fixes VSTS #1040606 - StyleCop rules are ignored
Fixes VSTS #577079 - [Diagnostics] Implement RuleSet file support
|
|
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1010683
|
|
This reverts commit d0ec47952e2d2beadf1176e4be69cea35720a2c7.
It broke some normal usage of Go To Definition for C# files.
|
|
|
|
Fixes AB#1018498
Context: http://sourceroslyn.io/#Microsoft.CodeAnalysis.CSharp/CommandLine/CSharpCommandLineParser.cs,f777bd5ac8b781b5,references
Context: https://docs.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2019
The previous strategy used a project model extension mechanism which was not accurate in a couple of scenarios like plain .NET library project where it would erroneously results in OutputKind.Exe being used.
This new logic instead leverages MSBuild directly in the same fashion than other implementations of Roslyn's workspaces do to get the most accurate information.
|
|
Introduce IDynamicDocumentInfoProvider.
|
|
|
|
Add period to template description.
|
|
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/984256/
|
|
[Debugger] Handle case when the text snapshot has less lines than the breakpoint location
|
|
breakpoint location
Fixes VSTS 958245
System.ArgumentOutOfRangeException exception in Microsoft.VisualStudio.Text.Implementation.BinaryStringRebuilder.GetLineFromLineNumber()
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/958245
|
|
See https://github.com/dotnet/roslyn/commit/40a73bde3269f7837f61be4a50788a3bb2fc3b8c
|
|
This was only used by old webtools. Now it's the only user of some
obsolete Roslyn API.
|
|
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/999640
|
|
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/947132/
|
|
|
|
DropDownListBox is actually a Window, so use that as the type when adding to the table, not plain Control.
This prevents duplicates from being added to the map, and ensures the right type is added for this widget.
Fixes VSTS #976424 - Unhandled argument exception adding to ConditionalWeakTable in Components.Control
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/970026
|
|
[CSharp] Don't hide formatting dialog in ctor
|
|
The issue has already been fixed in MessageDialog, nevertheless
Hide, Show and ShowAll should never be called in the ctor
of a Gtk Dialog or Window. Even Hide will realize the window
and make it the key window on mac for the current UI iteration,
which will confuse MessageService and probably other logic
relying on a valid focused key window.
Fixes VSTS #943186
|
|
|
|
Allow users to set Preview in the C# compiler options panel, which
had previously been disabled as part of #816208.
Fixes VSTS #950743
|
|
Update code after review. Seal class and implement IEquatable.
|
|
Use Roslyn Project information when adding projects to the text editor's
path bar. This allows multi-target framework projects to be supported.
Currently an extra project is being added to the path bar which has no
associated target framework. Visual Studio on Windows just shows a path
bar item for each target framework
Fixes VSTS #572342 - Support picking target framework for intellisense
|
|
Fixes https://vsmac.dev/948416/.
|
|
In Preferences - Source Code - Code Formatting - C# when the Edit
button was clicked in the Format tab the IDE would crash. The problem
was that the dialog being displayed was being used as its own parent
in MessageService. Which was causing a stack overflow.
Stack overflow: IP: 0x7fff57f71b9c, fault addr: 0x7ffeed8e6ff8
Stacktrace:
at <unknown> <0xffffffff>
at AppKit.NSWindow.AddChildWindow (AppKit.NSWindow,AppKit.NSWindowOrderingMode) [0x00032] in /Library/Frameworks/Xamarin.Mac.framework/Versions/5.14.0.83/src/Xamarin.Mac/AppKit/NSWindow.g.cs:2089
<...>
at MonoDevelop.Ide.MessageService.ShowCustomModalDialog (Gtk.Window,MonoDevelop.Components.Window) [0x00042] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/MessageService.cs:398
at MonoDevelop.Ide.MessageService/<>c__DisplayClass34_0.<RunCustomDialog>b__0 () [0x0006a] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/MessageService.cs:361
at MonoDevelop.Core.Runtime.RunInMainThread (System.Action) [0x0000d] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Core/MonoDevelop.Core/Runtime.cs:334
at MonoDevelop.Ide.MessageService.RunCustomDialog (MonoDevelop.Components.Dialog,MonoDevelop.Components.Window) [0x000d6] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/MessageService.cs:348
at MonoDevelop.Ide.MessageService.ShowCustomDialog (MonoDevelop.Components.Dialog,MonoDevelop.Components.Window) [0x00007] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/MessageService.cs:306
at MonoDevelop.Ide.MessageService.ShowCustomDialog (MonoDevelop.Components.Dialog) [0x00000] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/MessageService.cs:299
at MonoDevelop.CSharp.Formatting.CSharpFormattingPolicyPanelWidget.HandleButtonEditClicked (object,System.EventArgs) [0x0000c] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/addins/CSharpBinding/MonoDevelop.CSharp.Formatting/CSharpFormattingPolicyPanelWidget.cs:99
To fix this the dialog does not show itself before MessageService's
ShowCustomDialog is called. Note that setting an explicit parent
in the call to ShowCustomDialog to be the TopLevel of the
CSharpFormattingPolicyPanelWidget also fixed the problem but this
resulted in the dialog not being centered on the screen. Instead it was
placed so its left edge and top edge were inside the options panel.
Fixes VSTS #942740 - Crash when trying to change C# formatting settings
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/935126/
|
|
Fix 935181: TryGetBreakpointSpan called with invalid position
|
|
Opening a C# file from a shared project would sometimes not show
the owner projects in the path bar. Also affects multi-target
projects. The WorkspaceRegistration.WorkspaceChanged event would
sometimes not be generated on opening the text editor so the
owner projects were not added. To prevent the code is run on
creating the CSharpPathedDocumentExtension so that the owner
projects have been added in case the WorkspaceChanged event does
not fire.
Fixes VSTS #934792 - Editor path bar sometimes does not list
project information
|
|
|
|
I also added logic to fallback to whole line breakpoint in case Roslyn fails to find matching statement to place breakpoint on.
|
|
[C#] Fix unhandled exception that is thrown when completion is canceled
|
|
Fixes VSTS 896684: Override keyword does not show protocol completions
|
|
Add a OnlyOnRanRanToCompletion option and execute synchronously.
Fixes VSTS #798074 - Unobserved exception in CSharpCompletionTextEditorExtension
|
|
This change will ensure our completion data will get surfaced *alongisde* completion suggestions from the other exclusive provider, which is the actual override provider. There was a recent Roslyn change, starting from 16.2.P4 where exclusivity simply means grouping - showing all exclusive ones, not just whoever gets there first. Additionally, we are now ensuring our provider also gets called when there is an insertion/deletion going on (i.e. after the user writes override).
|
|
|
|
* ShowCompletionItemFilters (new UI landing in editor)
* TriggerOnDeletion (forced in old editor, configurable in new)
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/914033
|
|
Roslyn implemented this feature as a per-language setting, not a global
intellisense setting like MonoDevelop has. In the future, we should
reorganize this setting to reflect that (and match Windows).
Ensure that the Roslyn feature is disabled in old editor completion. The
items show up correctly in the list, but insertion fails to actually add
the `using` statement. The old editor can continue using its existing
implementation of this feature.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/756548
|
|
[CSharpBinding] Allow choosing C# 8
|
|
Fixes new editor debugger tooltip not showing errors
|
