| Age | Commit message (Collapse) | Author |
|---|
|
Analyzer items were not being resolved so no analyzers were being
passed to the type system for SDK style projects. Non-SDK style
PackageReference projects were resolving Analyzer items. Projects
that use a packages.config have to explicitly use Analzyer items
in the project file.
To fix this the CoreCompileDependsOn targets is changed to include
the ResolveLockFileAnalyzers which resolves the Analyzer items.
This was already working for non-SDK style PackageReference projects
since the NuGet addin was adding the ResolveNuGetPackageAssets
target to the CoreCompileDependsOn targets and that resolves the
Analyzer items.
Fixes VSTS #1047893 - Analyzers not used by SDK style projects
|
|
[NuGet] Fix requests bypassing the native HTTP handler
|
|
[NuGet] Use a custom label to allow tab focus in package management
|
|
A regular label does not allow focus unless it's selectable or a link
and there is no simple workaround for that.
Fixes VSTS #1021581
|
|
Restoring or installing a NuGet package into a project that uses
PackageReferences would bypass the native HTTP handler. This was due
to NuGet's CachingSourceProvider creating its own set of
INuGetResourceProviders when it creates a set of new SourceRepository
instances. This resulted in the default HttpSourceResourceProvider
being used when uses Mono's HttpClientHandler. This would happen
when the .nupkg was downloaded.
NuGet 5.4 allows a custom NuGetResourceProvider factory to be
configured instead of only when creating instances of SourceRepository.
This is now used by the Package Management addin so all HTTP requests
use the native HTTP handler.
Fixes VSTS #918815 - Fixes NuGet requests bypassing native Http Handler
|
|
Added a feature switch to allow the license acceptance dialog
to be disabled. This can be done by setting the environment
variable:
MD_FEATURES_DISABLED=NuGetLicenseAcceptanceDialog
By default the license acceptance dialog will be displayed. The
feature switch can be used by automation tests to disable the
dialog and the license acceptance for the NuGet package will
occur without the user being prompted.
Fixes VSTS #1036006 - Disable license acceptance dialog with
feature switch
|
|
Remove various references to NRefactory that are not used
|
|
[NuGet] Register credential providers coming from secure plugins
|
|
|
|
With check for updates enabled, and the NuGet command line credential
provider using the session token cache, when the Manage Packages dialog
was opened the dialog asking for a username and password would be
displayed. The problem was that the NuGet credential service puts itself
into retry mode when it is used. The retry flag is then set to true and
was passed to the credential provider. The credential provider sees this
is a retry and clears the session token cache so the token for the
package source is not used. This then results in the credential prompt.
To fix this the retry cache is reset on opening the dialog. It looks
like this change was lost on switching to the manage packages dialog:
ec92ab06b697236ed8e3ec43bb8fd9b8a428fe1a
|
|
The PluginResourceProvider uses PluginManager.Instance by default.
We want this to use the custom PluginManager that handles running
providers with Mono instead of the default one that NuGet provides.
|
|
NuGet's PluginFactory does not launch a .NET Framework .exe with Mono
which causes the IDE to run launch another instance of itself when
run from the Mac bundle. To workaround this the command line
arguments are modified if an .exe is being run so it is launched with
the current Mono.
|
|
This will do a barebone registration of available, plugin-based credential providers (like the Azure DevOps one) without implementing any authentication flow. The idea is that users can pre-authenticate via another mean (manual MSBuild invocation or NuGet binary) and the IDE will, at least, be able to retrieve those cached credentials.
|
|
plugins"
This reverts commit 09fe44563ef01c059dda3008cc194703259340d0.
|
|
This will do a barebone registration of available, plugin-based credential providers (like the Azure DevOps one) without implementing any authentication flow. The idea is that users can pre-authenticate via another mean (manual MSBuild invocation or NuGet binary) and the IDE will, at least, be able to retrieve those cached credentials.
|
|
|
|
Fixes VSTS #1021688
|
|
[NuGet][1021556] Make tab labels behave like real tabs with VO
|
|
Fixes VSTS #1021556
|
|
The status message that is displayed with the spinner is now
announced by Voice Over. When the status message is removed another
message is announced by Voice Over to say the loading has completed
or, if a search filter was entered, search was completed. If no
packages are found when searching this message is also announced
by Voice Over.
Fixes VSTS #1022830 - Accessibility: NuGet Packages: VoiceOver is
not announcing the status message.
|
|
Using ID allows Voice Over to announce it as I.D instead of a single
word. Note that some Voice Over voices, such as English UK still
announce the text incorrectly. Without changing the text to be "I.D."
there does not seem to be a way of fixing this in the IDE. System
Preferences on the Mac can be used to change the pronounciation for
certain words if required.
Fixes VSTS #1021636 - Accessibility: NuGet: Improper announcement for
the "ID" word.
|
|
Instead of using new text for the accessibility label for the projects
and versions list view re-use the existing consolidate label.
|
|
Combine project name and check box in Consolidate tab. This fixes the
problem where the check box has a column with no name. Now the check
box and the project name are in the same column so Voice Over reads
the column header name, the project name and the checkbox state which
makes it easier to understand what the list view is displaying.
Fixes VSTS #1021702 - Accessibility: NuGet Packages: Column Header
name is not present for the first column.
|
|
Previously the download count was read by Voice Over when on the
Installed tab but the version installed was displayed. Now the version
is read by Voice Over. Download count is read by Voice Over on the
Browse tab as before.
|
|
The search text box now shows 'Search' as placeholder text.
Fixes VSTS #1022836 - Manage NuGet Packages_Usability: Unable to
identify the instructions about search criteria.
|
|
Manage Packages dialog changes:
1. Associate labels with all combo boxes.
2. Workaround Xwt.ComboBox.Accessible.Label not working by adding an
invisible label for the Package Sources combo box which has no visible
label. This label is assigned to the ComboBox.Accessible.LabelWidget
which works.
3. Add accessibility label for the packages list and the projects and
versions list.
4. Associate package information with their corresponding labels.
Fixes VSTS #1021638 - Accessibility: NuGet Packages: VoiceOver is not
announcing the label for all the combo box and edit box present on
the screen.
Fixes VSTS #1021699 - Manage NuGet Packages_ConsolidateTab_ScreenReader:
Voice Over is not announcing the table name
|
|
[a11y] NuGet Package Management
|
|
|
|
Xwt.GtkBackend.SearchEntry is a copy of Components.SearchEntry,
but without accessibility features on macOS. Since we use that widget
in PackageManagement only anway, let's just use the original widget
that is accessible. We can review this once we get an updated
SearchWidget backend in Xwt.Gtk.
Fixes VSTS #750371
|
|
|
|
Fixes VSTS #750376
|
|
* Use regular check box cell view to select packages
* Remove custom background rendering
|
|
XwtRootWindow
Fixes VSTS #961624 - "System.ObjectDisposedException: Cannot access a disposed object" error when trying to access nuget license dialog
|
|
Updating a package for multiple projects in one step results in the
NuGet package restore that is done at the end being a no-op. This
means that the project is not re-evaluated which can mean that the
AvailableItemNames are not updated. Updating a single NuGet package
does not have the same problem.
Also fixed a problem where a PackageReference project (non-sdk) was
not re-evaluated on restoring. This could also result in the
AvailableItemNames not being available to the project if the project
was missing its obj/project.assets.json file on being opened in the
IDE.
|
|
Updating two NuGet package references that have a strict dependency
on a single version of another NuGet package not explicitly added
to the project would fail in the Manage NuGet Packages dialog. This
was because the update would be done one package at a time. Doing
the update of the two NuGet packages together allows NuGet to
update both so they then use the new strict dependency.
Note that updating all packages in the project from the Solution
window does not have this problem since there the packages are
updated together in a batch.
Fixes VSTS #986960 - Solution nuget updater fails to update a set of
packages that all have a related dependency update
|
|
In Preferences - NuGet - Sources, the Add Package Source dialog
would lose focus when the Browse button was used. A way to reproduce
this is to tab to the Add button, press space, then tab to the
Browse button in the Add Package Source dialog, press space, then
press escape. The Add Package Source dialog then no longer has focus
and tabbing does not work.
Fixed this by explicitly setting focus back to the parent dialog
when a child dialog is closed.
Fixes VSTS #1003430 - Accessibility: NuGet add package source dialog
browse button loses dialog focus
|
|
mono/nuget-null-reference-getting-package-reference-info
[NuGet] Handle NuGet addin API used when project disposed
|
|
Handle a null Project.MSBuildProject when the NuGet addin's
GetInstalledPackages API is called.
System.NullReferenceException
Object reference not set to an instance of an object
MonoDevelop.PackageManagement.DotNetProjectExtensions.GetDotNetCoreTargetFrameworks(Project)
MonoDevelop.PackageManagement.ProjectPackageReference.GetFramework()
MonoDevelop.PackageManagement.ProjectPackageReference.CreatePackageReference()
MonoDevelop.PackageManagement.PackageReferenceNuGetProject.<>c.<GetPackageReferences>b__XXX(ProjectPackageReference)
System.Linq.Enumerable.SelectEnumerableIterator`2[[MonoDevelop.PackageManagement.ProjectPackageReference, MonoDevelop.PackageManagement, Version=1.0.0.0, Culture=neutral, PublicKeyToken=3ead7498f347467b],[NuGet.Packaging.PackageReference, NuGet.Packaging, Version=5.2.0.3, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].ToList()
System.Linq.Enumerable.ToList[PackageReference](IEnumerable`1)
MonoDevelop.PackageManagement.PackageReferenceNuGetProject.GetPackageReferences()
MonoDevelop.PackageManagement.PackageReferenceNuGetProject.GetInstalledPackagesAsync(CancellationToken)
MonoDevelop.PackageManagement.PackageManagementProjectOperations.<>c__XXX.<GetInstalledPackages>b__XXX()
System.Threading.Tasks.Task`1[[System.Threading.Tasks.Task`1[[System.Collections.Generic.IEnumerable`1[[NuGet.Packaging.PackageReference, NuGet.Packaging, Version=5.2.0.3, Culture=neutral, PublicKeyToken=31bf3856ad364e35]], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].InnerInvoke()
System.Threading.Tasks.Task.Execute()
Gtk.Application.Run()
MonoDevelop.Ide.IdeStartup.Run(MonoDevelopOptions)
MonoDevelop.Ide.IdeStartup.Main(String[],IdeCustomizer)
Fixes VSTS #987260 - System.NullReferenceException exception in
MonoDevelop.PackageManagement.DotNetProjectExtensions.GetDotNetCoreTargetFrameworks()
|
|
|
|
1. Change "Edit References" to "Add References"
2. Drop the add prefix from the Add sub menu
3. Change "Add files" to "Existing Files"
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/974919/
|
|
|
|
Matches the version included with MSBuild in Mono 6.4.0.179
Fixes VSTS #972633 Update NuGet to 5.3.0-rtm.6192 to match mono's
msbuild
|
|
mono/nuget-manage-packages-checkbox-selection-via-keyboard
[NuGet] Allow checkboxes to be selected by keyboard in packages dialog
|
|
|
|
|
|
No longer installing the selected package in the Manage NuGet Packages
dialog when the enter key is pressed. This has caused a bit of
confusion and can cause a package to be installed when the user is
trying to run the search. Note that the search is a search as you type
so pressing the enter key has no affect.
Fixes VSTS #968790 - Hitting return in a search field installs a package
|
|
Previously pressing space or enter would cause the selected package,
or multiple packages if checked, to be installed. Now pressing space
or enter checks or unchecks the package.
Fixes VSTS #750399 - Accessibility: Onfocus issue has been observed
while selecting packages from the list
Fixes VSTS #750407 - Accessibility: Checkboxes for selecting multiple
packages are not accessible through keyboard
|
|
[NuGet] Fix duplicate projects in select projects dialog
|
|
Checking more than one NuGet package in the Manage NuGet packages
dialog when that NuGet package is installed in multiple projects
could result in projects being listed multiple times in the Select
Projects dialog. This was because each checked package id was
being checked against all the packages installed in the project and
for each match the project was being returned. This would result
in the same project being listed multiple times in the dialog which
was confusing.
Fixes VSTS #966636 - NuGet Package Manager dialog after selecting
multiple packages to uninstall unclear
|
|
Ignore package references that have no version specified in the
project. This fixes a null reference exception displayed in the
Updates tab of the Manage NuGet packages dialog for an ASP.NET Core
web project.
Fixes VSTS #965689 - Manage NuGet Package has yellow bar with
"Object reference not set to an instance of an object"
|
