Age | Commit message (Collapse) | Author |
|
Switch to Task.CompletedTask where applicable
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1005823
|
|
|
|
|
|
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1010385
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Green ones for now
|
|
|
|
|
|
|
|
Depends on an upcoming editor update to actually handle this command.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1001949
|
|
|
|
1. I have theoretical issues with assuming the native guest control
should be forcefully Disposed via Gtk.Destroy due to this being
a GTK/NSView interop boundary - the GTK host shouldn't make
life-cycle assumptions about its native guest by default.
2. We do not want to break other users of the host. They _probably_
want the native-Dispose-on-GTK-Destroy behavior but they too should
double check and opt-in.
|
|
|
|
|
|
|
|
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/984248
|
|
This must be specified at launch.
|
|
Co-Authored-By: Marius Ungureanu <marius.ungureanu@xamarin.com>
|
|
|
|
|
|
On Mac, remove legacy editor's display binding. Do all work through
modern editor's display binding. Now "open with" submenu will only show
"Source Code Editor", which will either be legacy or modern based on
whatever's picked by the display binding.
It is no longer possible to edit C# with legacy editor.
|
|
In order to be automatically opened in the legacy editor, file types
must explicitly register via LegacyEditorSupport.
For file types like C#, where both editors are supported, simply provide
the list of extensions to be supported, and the selected editor will be
determined by the "Use the legacy text editor where available" pref.
For file types like F#, where only the legacy editor is supported, just
add `legacyOnly="true"`. Then the legacy editor will be used regardless
of preference.
For file types like XML, where support must be determined dynamically
(because users can manually register file types), specify a
`providerType` that implements `ILegacyEditorSupportProvider`. This
provider will be queried to determine where the legacy editor is
preferred.
For file types like Android XML, continue using the old
`SupportedFileType` extension point to signify that the modern editor
is always preferred over the legacy editor. This will override any
"base" LegacyEditorSupport (again, like XML).
Users will continue to be able to use the "Open With" menu to pick the
editor they prefer at that time. Of course when they pick unsupported
pairings, they may not have the best experience (missing features, etc).
|
|
* Refer to new editor as "modern editor", and fix several places where
it was still called the "experimental new editor".
* Refer to old editor as "legacy editor".
* Remove link to "learn more about the New Editor", as the aka has not
been maintained and there is no useful documentation page right now.
* Change the "Open C# files in the New Editor" preference to read
"Use the legacy text editor where available (not recommended)", and
invert its effect. Move this preference to the end of its section.
In an upcoming commit, this will be the only way to enable the legacy
editor in preferences, and it will only work for file types that
explicitly maintain legacy editor support.
Users will continue to be able to use the "Open With" menu to pick the
editor they prefer at that time.
|
|
Allows various keyboard commands to continue working if, for example,
an editor margin contains a view that accepts input.
|
|
This commit also enables using the navigate to issues and errors in the
document by remapping the old commands to the new handlers.
Fixes https://vsmac.dev/946718.
|
|
Fix 980541: Switching themes in Preferences corrupts colors in editor
|
|
Fix 934342: When I press shift+tab, the selected code lines don't get un-indented
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/980541
|
|
un-indented
Problem was that TextBuffer still had default `TabSize` of `4` so when indentions were calculated it it was wrong in some cases.
|
|
Visual Studio Editor has 2 commands to show code completion `CommitUniqueCompletionListItemCommandArgs` and `InvokeCompletionListCommandArgs` there are 2 differences between two..
1) If there is unique item in list just complete it without showing code completion
2) At least for web-tools difference is also, filter or not list of items
Since Cmd/Ctrl+Space on Windows but also in old editor behaved as `CommitUniqueCompletionListItemCommandArgs` this mapping is much more correct.
|
|
Since MonoDevelop doesn't have JSON colors we map type this color is always different from plain text color and its always meaningful color
|
|
|
|
This is now handled by `ICocoaMouseProcessorEvents` implementors. From
the perspective of mouse _processors_, this is now a standard right
click on Mac.
|
|
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/962445
|
|
|
|
1. Rename "Use Selection for *" commands to have proper macOS labels
2. Move cmd+e keybinding from `FindNextSelection` command to
`UseSelectionForFind`.
3. Add `UseSelectionForFind` command to main menu.
4. Add support for missing find commands to new editor.
It's unfortunate that we have two similar commands here but it's
important that cmd+e behaves as the user expects (it should not have
"find next" behavior...it just sets search text and keeps focus in
editor).
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/947125
|
|
Fixes VSTS 950315: Code Folding menu toggle does not work in new editor
|
|
Build: Use a property to access the vs-editor-api directory
|
|
|
|
We used to rely on the command being remapped to a handler in VSEC, but
that caused a few additional problems, like the menu text not always being
in sync. This fixes https://vsmac.dev/950315.
|
|
This should make it easier for us to have all vs-editor-api references
point to vs-editor-core when available. There are some blockers to that
change, so for now just take this one preparatory step.
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/918990
|