| Age | Commit message (Collapse) | Author |
|---|
|
|
|
On Mac, remove legacy editor's display binding. Do all work through
modern editor's display binding. Now "open with" submenu will only show
"Source Code Editor", which will either be legacy or modern based on
whatever's picked by the display binding.
It is no longer possible to edit C# with legacy editor.
|
|
* Refer to new editor as "modern editor", and fix several places where
it was still called the "experimental new editor".
* Refer to old editor as "legacy editor".
* Remove link to "learn more about the New Editor", as the aka has not
been maintained and there is no useful documentation page right now.
* Change the "Open C# files in the New Editor" preference to read
"Use the legacy text editor where available (not recommended)", and
invert its effect. Move this preference to the end of its section.
In an upcoming commit, this will be the only way to enable the legacy
editor in preferences, and it will only work for file types that
explicitly maintain legacy editor support.
Users will continue to be able to use the "Open With" menu to pick the
editor they prefer at that time.
|
|
This should help investigate issues like #980470 - Deadlock in FileWatcherService.WatchDirectories
From the looks of the code, there is no way for a deadlock to happen, as the async code is not
re-entrant.
|
|
MonoDevelop.Ide.Editor.TextEditor.get_FileName()
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/958254
|
|
|
|
Bump Roslyn to 3.2.0-beta4-19324-01
|
|
See https://github.com/dotnet/roslyn/pull/36584
|
|
The controller for the old editor didn't properly synchronize the value of HasUnsavedChanges with the internal textEditor dirty flag.
This would cause normal saves of the model to perpetuate a state where the editor controller's HasUnsavedChanges flag would never get reset to true because the internal dirty state would have been kept back.
|
|
Prefer new `rulers` value from editorconfig, which allows setting
multiple vertical rulers (like in vscode).
Then, check `max_line_length` like the old editor does.
Finally, use the VSmac preference/policy system.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/798040
|
|
|
|
Formatting settings may be messed up - this sets the correct ones on
load. The new document model changes caused to set wrong editor
settings on load.
|
|
Encoding needs to be == null for encoding auto detection to work. The
doc model change forced to be every file UTF-8 with bom.
|
|
|
|
for reloaded file
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/897623
This patch profits from the changes made for bug 866898 therefore
adding it to that PR.
|
|
Setting that on the lower levels in the editor layers works.
|
|
VB.NET highlighting broke - the creation of the VB.NET type system &
extension chain broke. I fixed that but syntax highlighting is not
working. Syntax highlighting is now done with our new editor
implementation.
The IAccurateClassifier implemenatiton doesn't work with VB.NET files
as it used to. It's Part of Bug #858121: [Feedback] Unable to change
font colors for vb.net by Visual Studio Community 2019 (ver8.0.2) for
Mac
|
|
* TextViewContent.TextViewNavigationPoint.cs: Avoid NRE when
BuildNavigationPoint is called before the text view is loaded.
* TextEditorViewContent.cs: Fixed possible leak. The policy change
event always needs to be unsbuscribed, even if the editor has not
been yet created. Also removed unused code.
|
|
|
|
* TextViewContent.TextViewNavigationPoint.cs: Avoid NRE when
BuildNavigationPoint is called before the text view is loaded.
* TextEditorViewContent.cs: Fixed possible leak. The policy change
event always needs to be unsbuscribed, even if the editor has not
been yet created. Also removed unused code.
* DesktopService.cs: Initialize the NativeToolkit in the UI thread. In
some unit test scenarios the desktop service may be initialized from
a background thread.
|
|
|
|
|
|
Zoom: Persist in new editor, sync with old
|
|
|
|
Zooming in either editor impacts the same configuration setting. Each
editor now listens to the setting changing, so it can update in response
to changes in the other editor.
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/824320
|
|
|
|
|
|
And fix an NRE.
|
|
This fixes the default for the editor line number margin being false
Fixes VSTS #830060 - [Regression] Default preference for line number margin changed to "off"
|
|
Open documents are not automatically registered/unregistered on
DocumentOpen/Close. Text editor implementations must explicitly call the new
RegisterOpenDocument method to register open documents, and dispose the
returned registration when done. Registration can be done at any time, even
before a solution is loaded. The type system will take care of informing about
open documents when a solution is loaded. Document registrations are
refcounted, so different views using the same buffer can register an open
document twice and the type system will unregister it after the last reference
is disposed.
Remove all ad-hoc handling code. The old editor now uses the miscellaneous
workspace.
Also removed some unused code.
|
|
|
|
Added Focused/Unfocused events, and ContentShown/Hidden events to DocumentView
and DocumentController.
|
|
Make sure the new editor extension is registered before the legacy editor.
|
|
|
|
|
|
|
|
JavaScript files
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/806781
This does not really fix the problem - it shadows it a bit. The line
is 1.8MB long - highlighting that with the current text mate engine is
problematic.
However even sublime text refuses to try to highlight such long lines.
But it shows a pango rendering error as well which can't be fixed.
But it no longer breaks the VS4MAC editor in a dead-lock like
situation.
However may be a good test for the new editor.
|
|
It is ambiguous and not really necessary.
|
|
Fix some issues with HasUnsavedChanges property. Models now have an event
to detected changes in that property. However, that event is not used in the old
editor since it is not reliable due to how undo/redo operations are implemented.
Properly implemented ShowNotification property.
|
|
Fixed issues with OnContentChanged and OnOwnerChanged. Those methods
are now properly called when changes happen in the controller. Also added
and fixed tests.
Fixed several issues in the GTK designer.
|
|
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/807807
The former implementation did not only respect the Indent/TabSize setting correcttly - it did overwrite configuration properties with policy style settings.
|
|
And add unit tests
|
|
Use the new completion in the new editor and old completion in the old editor. We have to hack into Roslyn's IAsyncCompletionService to set the private field accordingly because they don't support setting it per view.
See related https://github.com/dotnet/roslyn/issues/33807
|
|
The old editor apparently still attempts to do something when WrapLines
returned true. When we introduced word wrapping in the new editor, the
property changed from a boolean to a flags enum. For compatibility we
plumbed the old WrapLines property through to the new WordWrapStyle
property. This was a bad assumption and introduced VSTS #801818.
Apparently the old editor may have at some point tried to implement word
wrapping and has been respecting the preference all along but it has
been dormant for 6 years since it was disabled in the preferences UI.
The deprecated WrapLines property will again always return false, fully
disconnecting it from the preferences UI.
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/801818
|
|
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/790220
|
|
When toggling the new editor on or off, if there are files open in
the workbench, offer to close them all.
Hook up the preview commands for disabling the editor, learning more
about the new editor, and reporting issues.
|
|
|
|
|
|
Map settings and colors for Indention guides
|
|
|
