| Age | Commit message (Collapse) | Author |
|---|
|
[Core] Fix remote project builder deadlock
|
|
The change make the call to RemoteBuildEngine.UnloadProject meant
that the engine in the RemoteProjectBuilder was being set to null
and the RemoteBuildEngineManager.ReleaseProjectBuilder was being
called with this null engine. Reworked the code so that if the
builder is being disposed then the call to ReleaseProjectBuilder
is done after the UnloadProject.
Also modified a builder test so it waits a while for the engine
count to be reduced since that is now done asynchronously.
|
|
UI hang can occur when the UI thread and a background thread are
updating the remote project builders at the same time due to two locks
being accessed in a different order.
Background thread:
RemoteBuildEngine.GetRemoteProjectBuilder - locks remoteProjectBuilders
RemoteProjectBuilder.AddReference - locks usageLock
UI thread:
RemoteProjectBuilder.Shutdown - locks usageLock
RemoteProjectBuilder.Dispose
RemoteBuildEngine.UnloadProject
RemoteBuildEngine.RemoveBuilder - locks remoteProjectBuilders
To avoid this the RemoteBuildEngine.UnloadProject is not done
synchronously in the RemoteProjectBuilder's Dispose method.
Fixes VSTS #1030374 - [FATAL] SigTerm signal in MonoDevelop.Core.dll!
MonoDevelop.Projects.MSBuild.RemoteBuildEngine::RemoveBuilder+9
|
|
|
|
Fixes squiggles in Razor/Blazor files after project reload
|
|
Fixes 1026106 - in some cases, NSEvent seems to have been null
|
|
* [Ide[ Configure Gtk# for slim startup
* Fix up startup tracker slices.
Xamarin.Mac is init as part of gtk init, skewing info
|
|
* [Ide] Load AddinManager data on the UI thread.
We need to run this on the UI thread since AddinManager is not thread safe.
Invoking extension changed handlers on non-UI thread can lead to weird results
Fixes VSTS #1027414 - [FATAL] SigTerm signal in Mono.Addins.dll!Mono.Addins.RuntimeAddin::LoadModule+82"
Synchronously run the OnInitialize of the service to load the addin assemblies on the UI thread, then dispatch the actual composing to a background task.
This should prevent deadlock issues, and ensure that the first init is called on the UI thread
* Use Runtime.RunInMainThread
Some tests (i.e. MD.Core) cannot initialize the composition manager in the UI thread. The Razor extension ends up calling CompositionManager.Instance in the constructor, thus the init will throw and the Core test suite hangs.
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1010385
|
|
[Core] Add Microsoft.CodeAnalysis.Workspaces.MSBuild nuget
|
|
[Debugger] Exception caught dialog accessibility
|
|
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/753577
|
|
Co-Authored-By: Marius Ungureanu <marius.ungureanu@xamarin.com>
|
|
This introduces a null check, and also introduces additional debug level
checks for others, just to make sure if we do run into this while debugging,
that we are aware.
|
|
Added accessibility titles to the buttons and images that are displayed
in the debugger tree view in the Exception Caught dialog and the
Locals and Watch pad. The visualizer buttons now have a descriptive
name read by Voice Over. Images now have a descriptive name read by
Voice Over.
|
|
Fix warning images not associated with a label.
Fix tree views not being named.
Fix inner exception tree view not reading tree node item text.
|
|
The expanders are preventing Voice Over from accessing the child
UI elements of the expanders.
|
|
|
|
[Debugger] Implemented code-completion for the new MacObjectValueTree…
|
|
|
|
[Ide] Let the references search be a child of the notebook
|
|
[NuGet][1021556] Make tab labels behave like real tabs with VO
|
|
[NuGet] Manage packages dialog accessibility
|
|
Scaffolding is enabled for Project + Folder
|
|
We don't need a completion source when already on the UI thread, so optimize the implementation a bit
|
|
[Debugger] Handle NRE when adding a watch when not debugging
|
|
mono/jstedfast-debugger-load-children-incrementally
[Debugger] Incrementally load new children rather than remove-all and…
|
|
|
|
Fixes VSTS #1021556
|
|
|
|
[master] Update translations
|
|
[AspNet*] Add a group for ASP.NET Core Browser execution targets
|
|
Changed from Folder + File
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1027657
|
|
|
|
The status message that is displayed with the spinner is now
announced by Voice Over. When the status message is removed another
message is announced by Voice Over to say the loading has completed
or, if a search filter was entered, search was completed. If no
packages are found when searching this message is also announced
by Voice Over.
Fixes VSTS #1022830 - Accessibility: NuGet Packages: VoiceOver is
not announcing the status message.
|
|
|
|
Make sure dynamic files are added to the project info every time the project is reloaded.
Also double-check that the document we're about to reload still exists in the current solution.
|
|
Allow wizard to reopen. Fixes https://devdiv.visualstudio.com/DevDiv/…
|
|
Fixes VSTS 1025766
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1025766
|
|
bumped debugger-libs
|
|
Using ID allows Voice Over to announce it as I.D instead of a single
word. Note that some Voice Over voices, such as English UK still
announce the text incorrectly. Without changing the text to be "I.D."
there does not seem to be a way of fixing this in the IDE. System
Preferences on the Mac can be used to change the pronounciation for
certain words if required.
Fixes VSTS #1021636 - Accessibility: NuGet: Improper announcement for
the "ID" word.
|
|
|
|
Fix 1023494: Unsaved new documents have `/` added to begining of file name
|
|
Instead of using new text for the accessibility label for the projects
and versions list view re-use the existing consolidate label.
|
|
Combine project name and check box in Consolidate tab. This fixes the
problem where the check box has a column with no name. Now the check
box and the project name are in the same column so Voice Over reads
the column header name, the project name and the checkbox state which
makes it easier to understand what the list view is displaying.
Fixes VSTS #1021702 - Accessibility: NuGet Packages: Column Header
name is not present for the first column.
|
|
Previously the download count was read by Voice Over when on the
Installed tab but the version installed was displayed. Now the version
is read by Voice Over. Download count is read by Voice Over on the
Browse tab as before.
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/945598
|
|
The search text box now shows 'Search' as placeholder text.
Fixes VSTS #1022836 - Manage NuGet Packages_Usability: Unable to
identify the instructions about search criteria.
|
|
Manage Packages dialog changes:
1. Associate labels with all combo boxes.
2. Workaround Xwt.ComboBox.Accessible.Label not working by adding an
invisible label for the Package Sources combo box which has no visible
label. This label is assigned to the ComboBox.Accessible.LabelWidget
which works.
3. Add accessibility label for the packages list and the projects and
versions list.
4. Associate package information with their corresponding labels.
Fixes VSTS #1021638 - Accessibility: NuGet Packages: VoiceOver is not
announcing the label for all the combo box and edit box present on
the screen.
Fixes VSTS #1021699 - Manage NuGet Packages_ConsolidateTab_ScreenReader:
Voice Over is not announcing the table name
|
