| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
[release-8.2] Bump fantomas
|
|
|
|
a url's path property might be null if the referenced resource no longer exists
Fixes VSTS #940763
|
|
[8.2][Debugger] Fixed VSCodeDebuggerSession.OnNextInstruction
|
|
|
|
|
|
I previously "fixed" this to do StepInRequest but I was wrong.
|
|
|
|
|
|
https://github.com/mono/monodevelop/commit/ef5ea322347547cb6d971b6097b41965312178e6 introduced a regression where we would load the children on a background thread.
That seems to race with debugger suspending/resuming. Go back to running on the UI thread. Also, fix up usage of the token source.
|
|
[release-8.2] [C#] Fix unhandled exception that is thrown when completion is canceled
|
|
[release-8.2] [Mac] Don't hang when terminating through the dock icon
|
|
[release-8.2] [CSharpBinding] Fix crash on opening C# format profile dialog
|
|
[release-8.2] [Ide] Add WelcomeWindow shown/hidden events
|
|
It turns out the answer to
// FIXME: could this block in rare cases?
was "No, it blocks every time", so make the delegate async and await on the call instead.
Also remove the old Carbon handler and move the important bits into the Cocoa handler instead as it hasn't been deprecated for at least a decade
Fixes VSTS #942401
|
|
In Preferences - Source Code - Code Formatting - C# when the Edit
button was clicked in the Format tab the IDE would crash. The problem
was that the dialog being displayed was being used as its own parent
in MessageService. Which was causing a stack overflow.
Stack overflow: IP: 0x7fff57f71b9c, fault addr: 0x7ffeed8e6ff8
Stacktrace:
at <unknown> <0xffffffff>
at AppKit.NSWindow.AddChildWindow (AppKit.NSWindow,AppKit.NSWindowOrderingMode) [0x00032] in /Library/Frameworks/Xamarin.Mac.framework/Versions/5.14.0.83/src/Xamarin.Mac/AppKit/NSWindow.g.cs:2089
<...>
at MonoDevelop.Ide.MessageService.ShowCustomModalDialog (Gtk.Window,MonoDevelop.Components.Window) [0x00042] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/MessageService.cs:398
at MonoDevelop.Ide.MessageService/<>c__DisplayClass34_0.<RunCustomDialog>b__0 () [0x0006a] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/MessageService.cs:361
at MonoDevelop.Core.Runtime.RunInMainThread (System.Action) [0x0000d] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Core/MonoDevelop.Core/Runtime.cs:334
at MonoDevelop.Ide.MessageService.RunCustomDialog (MonoDevelop.Components.Dialog,MonoDevelop.Components.Window) [0x000d6] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/MessageService.cs:348
at MonoDevelop.Ide.MessageService.ShowCustomDialog (MonoDevelop.Components.Dialog,MonoDevelop.Components.Window) [0x00007] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/MessageService.cs:306
at MonoDevelop.Ide.MessageService.ShowCustomDialog (MonoDevelop.Components.Dialog) [0x00000] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/MessageService.cs:299
at MonoDevelop.CSharp.Formatting.CSharpFormattingPolicyPanelWidget.HandleButtonEditClicked (object,System.EventArgs) [0x0000c] in /Users/vsts/agent/2.153.2/work/1/s/monodevelop/main/src/addins/CSharpBinding/MonoDevelop.CSharp.Formatting/CSharpFormattingPolicyPanelWidget.cs:99
To fix this the dialog does not show itself before MessageService's
ShowCustomDialog is called. Note that setting an explicit parent
in the call to ShowCustomDialog to be the TopLevel of the
CSharpFormattingPolicyPanelWidget also fixed the problem but this
resulted in the dialog not being centered on the screen. Instead it was
placed so its left edge and top edge were inside the options panel.
Fixes VSTS #942740 - Crash when trying to change C# formatting settings
|
|
Mono.MHex.HexEditor.Dispose()
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/942353
Can't really determine the cause - Options should always be != null
but it's the only thing that can throw a null ref exception. But in
any case Dispose shouldn't cause a fatal exception.
|
|
[Backport] Fixes VSTS 917028: Calling ScrollToRequestedCaretLocation with an invalid line number caused an exception
|
|
[release-8.2] Fixes VSTS Bug 938343: [Feedback] Diff Option in Version Control not
|
|
|
|
In some cases (like a deletion of code from the document, then trying to double click an existing Search Result), this method might have been called with a line number that no longer exists. This resulted in a call to the API that threw an exception. Now, the method checks the line count in the snapshot, and aborts. Both cases (a graceful failure, and an exception) are logged, so we can see if this continues to happen.
|
|
[release-8.2] Adds a ZOrder system based in GtkNSViewHost
|
|
[release-8.2] Fixes VSTS Bug 937036: [FATAL] System.NullReferenceException exception in MonoDevelop.Ide.Gui.DefaultWorkbench.get_Memento()
|
|
[release-8.2] Fixes VSTS Bug 935201: System.ArgumentOutOfRangeException exception in
|
|
[release-8.2] Fixes VSTS Bug 776934: TreeBuilderContext.GetTreeBuilder() null
|
|
[release-8.2] Fix 935197: Exception in TextFileNavigationPoint.OnDocumentClosing
|
|
[release-8.2] Fixes VSTS 935137: Null Reference Exceptions when disposing TextViewContent
|
|
[release-8.2] Fixes VSTS 915954: "Rename File to {NewClassName}.cs" code action does not work
|
|
|
|
[release-8.2] Update translations
|
|
Fix 935181: TryGetBreakpointSpan called with invalid position
|
|
I'm not exactly sure how that exception happened(maybe TextBuffer of TextView changed). But with this change problem of snapshots coming from different textbuffers can't happen again.
|
|
[release-8.2] Fix 923058: ArgumentOutOfRangeException in GetCharacterBounds
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/938534
|
|
Microsoft.VisualStudio.Text.SnapshotPoint..ctor()
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/935201
line.Start + Column - 1 will throw if Column is at EOL the - 1 is
interpreted as (Start + Column) - 1. Using brackets to evaluate it
differently : Start + (Column - 1) would fix the issue but I added the
bounds check to prevent the exeception from happening in all cases.
|
|
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/935126/
|
|
|
|
[release-8.2] [A11y] Only show the VoiceOver notification once.
|
|
behaviour of GtkNSViewHost
|
|
problem with the zorder in adding views to the GtkQuartz window. Because this, we where having some problems in drag and drop and clicking over views. To fix this we added a new mechanism to order the position of the views, and fix if there are other views not well calculated. Fixed VSTS #935567 - [Shell] Mouse click and resize in Splitters sometimes fails to complete the operation
|
|
I also added logic to fallback to whole line breakpoint in case Roslyn fails to find matching statement to place breakpoint on.
|
|
[release-8.2] [Core] Fix null ref in DotNetProject.OnGetReferencedAssemblies
|
|
SavePreferences was called twice in Workbench.Close () and missed an
await on SavePreferences on the individual items. That's now fixed.
|
|
MonoDevelop.Ide.Gui.DefaultWorkbench.get_Memento()
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/937036
Not sure why that happens but a Memento crash shouldn't cause a fatal
exception. I assumed that GdkWindow can be null in some cases there.
Doesn't make sense to store the Memento in that case.
Result is tha the ide would open with the workbench preferences from
the start before. A better option than falling back to some defaults.
|
|
|
|
roslyn document context
After debugging with @avodovnik, we found out that 2 registrations were done for the same document,
one still pointing to the old path.
Subscribing to the file document controller events on initialization fixes this, as the handler
that was checking renames is subscribed there.
Avoid manually saving a project, as there is a method that does that in TryApplyChanges.
The Freeze/Thaw events are required because the roslyn file associations need to happen before the
text buffer registration, otherwise the text buffer is associated with the miscellaneous files workspace
as our workspace does not contain the new document file path yet.
|
|
|
|
The project file is now saved. I've extracted the method that used DispatchService
to pump events while waiting on the async method to finish, and put it into
the DispatchService itself as I needed it in two places.
|
