Using namespace std in a header file pollutes the global namespace.

Using directives should be put into the implementation files.

1 files changed, 4 insertions, 6 deletions

diff --git a/mert/BleuScorer.h b/mert/BleuScorer.h
index 1927183a9..2e5a0f54c 100644
--- a/mert/BleuScorer.h
+++ b/mert/BleuScorer.h
@@ -16,9 +16,7 @@ namespace MosesTuning
 const int kBleuNgramOrder = 4;
 
 class NgramCounts;
-class Reference;  
-
-using namespace std;
+class Reference;
 
 /**
  * Bleu scoring
@@ -34,9 +32,9 @@ public:
 
   explicit BleuScorer(const std::string& config = "");
   ~BleuScorer();
-  
-  static vector<float> ScoreNbestList(string scoreFile, string featureFile);
-  static float sentenceLevelBleuPlusOne(const vector<float>& stats);
+
+  static std::vector<float> ScoreNbestList(const std::string& scoreFile, const std::string& featureFile);
+  static float sentenceLevelBleuPlusOne(const std::vector<float>& stats);
 
   virtual void setReferenceFiles(const std::vector<std::string>& referenceFiles);
   virtual void prepareStats(std::size_t sid, const std::string& text, ScoreStats& entry);