From e7f0bc8c0f1c4a8731eb1c33cb013296a0555538 Mon Sep 17 00:00:00 2001 From: Andrey Utkin Date: Sun, 5 Feb 2012 00:14:15 +0200 Subject: drawtext: add missing braces around an if() block. Prevents uninitialized read. Signed-off-by: Anton Khirnov --- libavfilter/vf_drawtext.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'libavfilter/vf_drawtext.c') diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index dcde542118..c5a6ffe60f 100644 --- a/libavfilter/vf_drawtext.c +++ b/libavfilter/vf_drawtext.c @@ -492,9 +492,11 @@ static int dtext_prepare_text(AVFilterContext *ctx) /* get glyph */ dummy.code = code; glyph = av_tree_find(dtext->glyphs, &dummy, glyph_cmp, NULL); - if (!glyph) + if (!glyph) { ret = load_glyph(ctx, &glyph, code); - if (ret) return ret; + if (ret) + return ret; + } y_min = FFMIN(glyph->bbox.yMin, y_min); y_max = FFMAX(glyph->bbox.yMax, y_max); -- cgit v1.2.3