From cb7c4f73e5e3debe2646279eaa7cfb493573118b Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Wed, 13 May 2015 00:22:03 +0200 Subject: cafdec: free extradata before allocating it This fixes a memleak if read_kuki_chunk is executed more than once. Reviewed-by: Carl Eugen Hoyos Signed-off-by: Andreas Cadhalpun --- libavformat/cafdec.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'libavformat/cafdec.c') diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c index abbb3538d7..cc6ed0ce9f 100644 --- a/libavformat/cafdec.c +++ b/libavformat/cafdec.c @@ -134,6 +134,7 @@ static int read_kuki_chunk(AVFormatContext *s, int64_t size) return AVERROR_INVALIDDATA; } + av_freep(&st->codec->extradata); if (ff_alloc_extradata(st->codec, ALAC_HEADER)) return AVERROR(ENOMEM); @@ -166,6 +167,7 @@ static int read_kuki_chunk(AVFormatContext *s, int64_t size) avio_skip(pb, size - ALAC_NEW_KUKI); } } else { + av_freep(&st->codec->extradata); if (ff_get_extradata(st->codec, pb, size) < 0) return AVERROR(ENOMEM); } -- cgit v1.2.3