From 5aad4c1f4c966a3bd8a36895a7d2a2862f8c1c40 Mon Sep 17 00:00:00 2001 From: Dominik George Date: Fri, 18 Nov 2016 14:16:37 +0100 Subject: Rename misleading and wrong group_cn option to group_dn. --- Authenticators/LDAP/LDAPauth.ini | 2 +- Authenticators/LDAP/LDAPauth.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Authenticators/LDAP/LDAPauth.ini b/Authenticators/LDAP/LDAPauth.ini index a0b22f5..05f8c7b 100644 --- a/Authenticators/LDAP/LDAPauth.ini +++ b/Authenticators/LDAP/LDAPauth.ini @@ -27,7 +27,7 @@ discover_dn = false username_attr = uid number_attr = roomNumber display_attr = displayName -group_cn = cn=mumble,ou=Groups,dc=example,dc=com +group_dn = cn=mumble,ou=Groups,dc=example,dc=com group_attr = uniqueMember ; Uncomment and set below to provide more info from LDAP ; provide_info = True diff --git a/Authenticators/LDAP/LDAPauth.py b/Authenticators/LDAP/LDAPauth.py index 04c62de..0598d03 100644 --- a/Authenticators/LDAP/LDAPauth.py +++ b/Authenticators/LDAP/LDAPauth.py @@ -140,7 +140,7 @@ default = { 'ldap':(('ldap_uri', str, 'ldap://127.0.0.1'), ('username_attr', str, 'uid'), ('number_attr', str, 'RoomNumber'), ('display_attr', str, 'displayName'), - ('group_cn', str, 'ou=Groups,dc=example,dc=org'), + ('group_dn', str, 'ou=Groups,dc=example,dc=org'), ('group_attr', str, 'member'), ('provide_info', x2bool, False), ('mail_attr', str, 'mail'), @@ -519,11 +519,11 @@ def do_main_program(): debug('User match found, display "' + displayName + '" with UID ' + repr(uid)) # Optionally check groups. - if cfg.ldap.group_cn != "" : + if cfg.ldap.group_dn != "" : debug('Checking group membership for ' + name) #Search for user in group - res = ldap_conn.search_s(cfg.ldap.group_cn, ldap.SCOPE_SUBTREE, '(%s=%s)' % (cfg.ldap.group_attr, user_dn), [cfg.ldap.number_attr, cfg.ldap.display_attr]) + res = ldap_conn.search_s(cfg.ldap.group_dn, ldap.SCOPE_SUBTREE, '(%s=%s)' % (cfg.ldap.group_attr, user_dn), [cfg.ldap.number_attr, cfg.ldap.display_attr]) # Check if the user is a member of the group if len(res) < 1: -- cgit v1.2.3