Merge PR #4936: CI: Add check for source-code formatting

This is to make sure that new patches will actually follow the code
formatting rules that we set up. The used check will make the CI fail if
that was not the case.

3 files changed, 49 insertions, 30 deletions

diff --git a/.github/workflows/check_commit_style.py b/.github/workflows/check_commit_style.py
index c19713488..e0805d298 100755
--- a/.github/workflows/check_commit_style.py
+++ b/.github/workflows/check_commit_style.py
@@ -25,7 +25,7 @@ def main():
         cmd(["git", "remote", "add", remoteName, "https://github.com/mumble-voip/mumble.git"])
 
         # Fetch remote
-        cmd(["git", "fetch", remoteName])
+        cmd(["git", "fetch", "--no-recurse-submodules", remoteName])
 
         # get new commits
         commitHashes = [x for x in cmd(["git", "rev-list", "{}/master..HEAD".format(remoteName)]).split("\n") if x]
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
deleted file mode 100644
index 6a6dcaf9e..000000000
--- a/.github/workflows/checks.yml
+++ /dev/null
@@ -1,29 +0,0 @@
-name: Checks
-
-on: [pull_request]
-
-jobs:
-  commit-check:
-    runs-on: ubuntu-20.04
-
-    steps:
-
-    - name: Install Python
-      run: sudo apt install python3
-      shell: bash
-
-    - uses: actions/checkout@v2
-      with:
-          # Assume that there are not >200 new commits that need checking
-          fetch-depth: 200
-          # Don't checkout submodules
-          submodules: 'false'
-          # Don't create a merge commit
-          ref: ${{ github.event.pull_request.head.sha }}
-
-    - name: Check commit style
-      run: $GITHUB_WORKSPACE/.github/workflows/check_commit_style.py
-      shell: bash
-
-    - name: Check line endings
-      uses: erclu/check-crlf@v1
diff --git a/.github/workflows/pr-checks.yml b/.github/workflows/pr-checks.yml
new file mode 100644
index 000000000..cc6151542
--- /dev/null
+++ b/.github/workflows/pr-checks.yml
@@ -0,0 +1,48 @@
+name: PR-Checks
+
+on: [pull_request]
+
+jobs:
+  pr-checks:
+    runs-on: ubuntu-20.04
+
+    steps:
+
+    - name: Install Python
+      run: sudo apt install python3
+      shell: bash
+
+    - uses: actions/checkout@v2
+      with:
+          # Assume that there are not >200 new commits that need checking
+          fetch-depth: 200
+          # Don't checkout submodules
+          submodules: 'recursive'
+          # Don't create a merge commit
+          ref: ${{ github.event.pull_request.head.sha }}
+
+    - name: Check commit style
+      run: $GITHUB_WORKSPACE/.github/workflows/check_commit_style.py
+      shell: bash
+
+    - name: Check line endings
+      uses: erclu/check-crlf@v1
+      with:
+          exclude: '3rdparty/'
+
+    - uses: ./.github/actions/install-dependencies
+      with:
+          type: shared
+          os: ubuntu-20.04
+          arch: 64bit
+
+    - name: Generate compile-command DB
+      run: mkdir build; cd build; cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON ..; cd ..; ln -s build/compile_commands.json .
+      shell: bash
+
+    - name: Check code formatting
+      uses: jidicula/clang-format-action@v3.3.0
+      with:
+          clang-format-version: '10'
+          check-path: '.'
+          exclude-regex: '(3rdparty/*|build/*)'