diff options
| author | Davide Beatrici <git@davidebeatrici.dev> | 2020-04-04 08:48:46 +0300 |
|---|---|---|
| committer | Davide Beatrici <git@davidebeatrici.dev> | 2020-04-04 08:48:46 +0300 |
| commit | a48aea18b6c7ee534cd21f7febfe253e31b33eda (patch) | |
| tree | 5756941fcea908e6aa002780884b5d1d32837a49 /src/murmur/Server.cpp | |
| parent | f85b4f0d97cfdc94031631ec7d2eb3dfaaa561df (diff) | |
src/murmur/Server.cpp: implement workaround for critical QSslSocket issue
A severe bug was introduced in qt/qtbase@93a803a6de27d9eb57931c431b5f3d074914f693: q_SSL_shutdown() causes Qt to emit "error()" from unrelated QSslSocket(s), in addition to the correct one.
The issue causes Server::connectionClosed() to disconnect random authenticated clients.
The workaround consists in ignoring a specific OpenSSL error:
"Error while reading: error:140E0197:SSL routines:SSL_shutdown:shutdown while in init [20]"
Definitely not ideal, but it fixes a critical vulnerability. Details on how to trigger it are deliberately omitted.
Diffstat (limited to 'src/murmur/Server.cpp')
| -rw-r--r-- | src/murmur/Server.cpp | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/src/murmur/Server.cpp b/src/murmur/Server.cpp index cac75e4fe..055ad96d9 100644 --- a/src/murmur/Server.cpp +++ b/src/murmur/Server.cpp @@ -1422,6 +1422,19 @@ void Server::sslError(const QList<QSslError> &errors) { } void Server::connectionClosed(QAbstractSocket::SocketError err, const QString &reason) { + if (reason.contains(QLatin1String("140E0197"))) { + // A severe bug was introduced in qt/qtbase@93a803a6de27d9eb57931c431b5f3d074914f693. + // q_SSL_shutdown() causes Qt to emit "error()" from unrelated QSslSocket(s), in addition to the correct one. + // The issue causes this function to disconnect random authenticated clients. + // + // The workaround consists in ignoring a specific OpenSSL error: + // "Error while reading: error:140E0197:SSL routines:SSL_shutdown:shutdown while in init [20]" + // + // Definitely not ideal, but it fixes a critical vulnerability. + qWarning("Ignored OpenSSL error 140E0197 for %p", sender()); + return; + } + Connection *c = qobject_cast<Connection *>(sender()); if (! c) return; |