Age | Commit message (Collapse) | Author |
|
7439bc4fe6b423ff0d36d3b1d529e474c14e9b01 introduced the ability for
clients to query for their permissions in any given channel. Since that
commit also added an automatic permissions broadcast for channels that a
client enters (and also its parent channel), it also introduced a
system to keep track of whether a given permission set has already been
broadcast to a given client. Supposedly this was meant as to not flood
the client with PermissionQuery messages if it just keeps switching
between the same channels (and thus already knows about the respective
permissions after having joined a channel for the first time).
Oddly enough though, when a client explicitly requests to be informed
about a channel's permissions, the cache would also be consolidated and
if the server was under the impression that the client already knows
about these permissions, its explicit query would simply be ignored.
This is of course nonsense, since ultimately it is the client who knows
whether it wants to be informed about those permissions (again) or not.
Therefore, this commit ensures that explicit queries are always
answered. No need to consolidate the cache and decide on whether the
server feels like answering or not.
Fixes #5699
|
|
|
|
Previously the shortcut engine on Unix could not be disabled. Therefore,
the bEnableShortcut setting effectively had no effect on these systems,
making the change of its default value on Wayland (in order to prevent
CPU intensive polling) as done in 13c7ff5dd394d73bffde0e68fe0499ee7596ac6e
pointless.
This commit extends the engine's implementation such that it is now able
to disable shortcuts. This will automatically expose the enable shortcut
setting in the settings page. Thus, users can now explicitly re-enabled
the shortcut engine on Wayland systems.
|
|
In #5307 we disabled global shortcuts on Wayland, but we did it in a way
that would prevent anyone from re-enabling the support.
Since we have received reports of some users actually making use of the
shortcut system on Wayland, even without proper Wayland support, we
decided to remove the hard-lock and allow these users to re-enable the
shortcuts, if they so want.
Fixes #5454
|
|
|
|
|
|
Add the ability to press Ctrl+Enter to send a plain text message while
preserving line breaks. This adds an easy way of preserving messages
with line breaks without having to resort to using Markdown.
Implements #5707
|
|
Add the ability to press Ctrl+Enter to send a plain text message while
preserving line breaks. This adds an easy way of preserving messages
with line breaks without having to resort to using Markdown.
Implements #5707
|
|
Currently translated at 100.0% (2088 of 2088 strings)
TRANSLATION: Update German translation
Currently translated at 100.0% (2088 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Jan Klass <kissaki@posteo.de>
Co-authored-by: Kris <git@k118.de>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/de/
Translation: Mumble/Mumble Client
|
|
Currently translated at 100.0% (2088 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: John Doe <thraex@numericable.fr>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/fr/
Translation: Mumble/Mumble Client
|
|
Currently translated at 99.9% (2087 of 2088 strings)
Co-authored-by: AHOHNMYC <lqwh2h2cwa@protonmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ru/
Translation: Mumble/Mumble Client
|
|
Currently translated at 99.8% (2085 of 2088 strings)
Co-authored-by: Athanasios Plastiras <admin@plastiras.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/el/
Translation: Mumble/Mumble Client
|
|
Currently translated at 97.2% (2030 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Kristoffer Grundström <swedishsailfishosuser@tutanota.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/sv/
Translation: Mumble/Mumble Client
|
|
Currently translated at 93.9% (1962 of 2088 strings)
TRANSLATION: Update Portuguese (Brazil) translation
Currently translated at 93.9% (1962 of 2088 strings)
TRANSLATION: Update Portuguese (Brazil) translation
Currently translated at 93.9% (1962 of 2088 strings)
TRANSLATION: Update Portuguese (Brazil) translation
Currently translated at 93.9% (1962 of 2088 strings)
Co-authored-by: Daimar Stein <570cxat11@relay.firefox.com>
Co-authored-by: Egberto Garcia Fante Junior <egberto.g.f.junior@gmail.com>
Co-authored-by: Felipe <teadesu@disroot.org>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Kett Lovahr <vagnerlunes@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/pt_BR/
Translation: Mumble/Mumble Client
|
|
Currently translated at 100.0% (2089 of 2089 strings)
TRANSLATION: Update Turkish translation
Currently translated at 100.0% (2088 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Oğuz Ersen <oguz@ersen.moe>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/tr/
Translation: Mumble/Mumble Client
|
|
Currently translated at 91.1% (1904 of 2088 strings)
Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/nb_NO/
Translation: Mumble/Mumble Client
|
|
Currently translated at 100.0% (2089 of 2089 strings)
TRANSLATION: Update Polish translation
Currently translated at 100.0% (2088 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Matthaiks <kitynska@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/pl/
Translation: Mumble/Mumble Client
|
|
Currently translated at 98.2% (2052 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Sergio Varela <sergitroll9@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/es/
Translation: Mumble/Mumble Client
|
|
Currently translated at 100.0% (2089 of 2089 strings)
TRANSLATION: Update Chinese (Simplified) translation
Currently translated at 100.0% (2088 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: deluxghost <deluxghost@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/zh_Hans/
Translation: Mumble/Mumble Client
|
|
The "Addresses" field in the ServerItem tooltip shows both ipv4 and ipv6
addresses. The order of addresses in this field is not determined.
In the wild it is randomized. As discussed in #5696 it is better to implement
a concrete ordering to prevent user confusion. To further improve the
readability of the addresses we split the addresses field in two fields
called "IPv4 address" and "IPv6 address". The ipv4 address is now always
shown above the ipv6 address.
Implements #5696
|
|
The removed code was part of some logic introduced in
f6d9c4f7b57bc8163f392bdf50bda520f107b72f but the functional parts have
been removed when getting rid of all Qt4-specific code parts.
This left a few now unused variables in the code which in more recent
compiler versions would cause a warning (and thus in the default
settings a build error).
Since the code doesn't do anything anymore, this commit fully removes
the remaining parts of this code snippet.
Fixes #5724
|
|
In theory these changes should cause the server to no longer silently
ignore encountered INI syntax errors.
In practice however, it seems that it is pretty much impossible to
create an INI file that Qt actually considers erroneous and thus this
code essentially doesn't work. But in case Qt ever fixes this weird
behavior, at least in theory Mumble users should immediately profit from
it.
Fixes #5749
|
|
In theory these changes should cause the server to no longer silently
ignore encountered INI syntax errors.
In practice however, it seems that it is pretty much impossible to
create an INI file that Qt actually considers erroneous and thus this
code essentially doesn't work. But in case Qt ever fixes this weird
behavior, at least in theory Mumble users should immediately profit from
it.
Fixes #5749
|
|
Previously, Mumble would always use the original hostname when verifying a server certificate. When the actual server hostname (resolved through an SRV record) differs from the original hostname, it should be used instead.
Fixes #3563
|
|
Prior to the implementaiton of raw mouse input, a low-level mouse hook was used for capturing mouse events. Windows would emit a single WM_* event per button state change. With the move to capturing raw mouse input events, it was expected that this behavior remained, despite now needing to listen for WM_INPUT events.
However, unlike when using the low-level hook, WM_INPUT events can contain data for multiple simultaneous mouse state changes. If this occurred, Mumble would register none of the state changes.
Changing the logic to account for multiple state changes in a single event correctly allows for all states changes to be registered.
Fixes mumble-voip#5706
|
|
|
|
The "Addresses" field in the ServerItem tooltip shows both ipv4 and ipv6
addresses. The order of addresses in this field is not determined.
In the wild it is randomized. As discussed in #5696 it is better to implement
a concrete ordering to prevent user confusion. To further improve the
readability of the addresses we split the addresses field in two fields
called "IPv4 address" and "IPv6 address". The ipv4 address is now always
shown above the ipv6 address.
Implements #5696
Co-Authored-By: Thomas Pawelek <thomas.pawelek@stud.uni-hannover.de>
|
|
|
|
Use full word directory instead of less expressive ‘dir’.
|
|
|
|
In the 1.4.230 release, we enabled RNNoise by default as there have been
lots of reports of how well it works. However, after the release we saw
numerous reports complaining about bad audio quality, which was traced
back to having RNNoise enabled.
For some reason the outcome of having RNNoise enabled is very different
in different scenarios. Sometimes it works miraculously well and other
times it worsens the audio quality to an unbearable level.
There seems to be a higher chance of RNNoise messing up, when using
Windows, but the same effect has also been observed on Linux. It might
also depend on the quality of the used microphone (better quality = less
noise => RNNoise starts doing weird stuff), but we don't have any
definitive clues yet.
Because of this, we will change the default noise cancelling mode back
to Speex so that everyone for whom RNNoise actually works, cna enable
it, but we don't kill the experience for many folks by using an
unsuitable default value.
Fixes #5448
|
|
Currently translated at 99.9% (2087 of 2088 strings)
TRANSLATION: Update Russian translation
Currently translated at 99.9% (2087 of 2088 strings)
TRANSLATION: Update Russian translation
Currently translated at 99.9% (2087 of 2088 strings)
TRANSLATION: Update Russian translation
Currently translated at 99.9% (2087 of 2088 strings)
TRANSLATION: Update Russian translation
Currently translated at 99.9% (2087 of 2088 strings)
TRANSLATION: Update Russian translation
Currently translated at 99.9% (2087 of 2088 strings)
TRANSLATION: Update Russian translation
Currently translated at 99.9% (2087 of 2088 strings)
TRANSLATION: Update Russian translation
Currently translated at 99.9% (2087 of 2088 strings)
TRANSLATION: Update Russian translation
Currently translated at 99.9% (2087 of 2088 strings)
TRANSLATION: Update Russian translation
Currently translated at 99.9% (2087 of 2088 strings)
Co-authored-by: Alexey Dobrovolsky <dobrovolskiy.alexey@gmail.com>
Co-authored-by: Game one <denis.melnyk.2006@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Konstantin Goncharik <botankras@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ru/
Translation: Mumble/Mumble Client
|
|
See individual commits for details
Fixes #5606
|
|
Since version 0.3.51, PipeWire has support for buffers with a size of 0
being passed in the process callback. More specifically, this feature
was added in commit 96286fb8b11658a0fdaa61194504a3f9541b25e6 ("resample:
use a -1 buffer size to drain") in PipeWire [1].
Unfortunately, this causes an endless loop, because we try to destroy
the PipeWire stream, but it keeps waiting for the node to be completely
drained, which now never happens because it keeps calling
processCallback() where we feed buffers with a size of 0 to it.
To fix this problem, we do not longer pass 0-size buffers to PipeWire.
Instead we now push silence, if we don't have any data available. This
is what PipeWire prefers anyway, the process callback wants a buffer to
be filled. If we don't do that, the node will stay in
SPA_STATUS_NEED_DATA state and even if we ignore the obvious endless
loop error, this can cause other problems.
For example above mentioned commit was fixed in PipeWire with
32e957345d63a6d6e3d223057d764ff661f5d101 ("audioadapter: don't loop
forever") [2], which is better than the endless loop but still
preventable.
So in order to avoid unnecessary xruns, we push silence instead of empty
buffers.
Fixes #5647
[1] https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/96286fb8b11658a0fdaa61194504a3f9541b25e7
[2] https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/32e957345d63a6d6e3d223057d764ff661f5d101
|
|
The previous implementation of rememberchannelduration (#4147)
acknowledged the unreliability of the last_disconnect database
field. It used a workaround to set the last_disconnect field
to NULL for every user on every start of the mumble server.
However, with a default behavior for NULL, this created the
unintended side-effect that rememberchannel was erroneously
used for every user on their first connection after a server
restart.
This new implementation reverts the workaround of #4147 and
uses the last_active database field to check if last_disconnect
is reliable. If last_disconnect is unreliable, it will now use
the server uptime and compare it to rememberchanneduration.
We expect last_disconnect to be unreliable when the server
was shut down while clients are still connected.
Fixes #5639
|
|
Currently translated at 99.9% (2087 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Robert Adam <dev@robert-adam.de>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/de/
Translation: Mumble/Mumble Client
|
|
Currently translated at 23.2% (485 of 2088 strings)
TRANSLATION: Update Catalan translation
Currently translated at 22.6% (473 of 2088 strings)
TRANSLATION: Update Catalan translation
Currently translated at 22.4% (469 of 2088 strings)
TRANSLATION: Update Catalan translation
Currently translated at 22.3% (466 of 2088 strings)
TRANSLATION: Update Catalan translation
Currently translated at 20.8% (436 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Omar Macías Molina <omar.maciasmolina@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ca/
Translation: Mumble/Mumble Client
|
|
Currently translated at 100.0% (2088 of 2088 strings)
Co-authored-by: John Doe <thraex@numericable.fr>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/fr/
Translation: Mumble/Mumble Client
|
|
Currently translated at 97.1% (2029 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Kristoffer Grundström <swedishsailfishosuser@tutanota.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/sv/
Translation: Mumble/Mumble Client
|
|
Currently translated at 93.0% (1942 of 2088 strings)
TRANSLATION: Update Portuguese (Brazil) translation
Currently translated at 93.0% (1942 of 2088 strings)
TRANSLATION: Update Portuguese (Brazil) translation
Currently translated at 92.9% (1941 of 2088 strings)
Co-authored-by: Daimar Stein <570cxat11@relay.firefox.com>
Co-authored-by: Gabriel Bueno da Silva <rio234oas@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/pt_BR/
Translation: Mumble/Mumble Client
|
|
Currently translated at 5.5% (115 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Tymofii Lytvynenko <till.svit@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/uk/
Translation: Mumble/Mumble Client
|
|
Currently translated at 100.0% (2088 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: 이정희 <daemul72@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ko/
Translation: Mumble/Mumble Client
|
|
Currently translated at 100.0% (2088 of 2088 strings)
TRANSLATION: Update Turkish translation
Currently translated at 100.0% (2088 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Oğuz Ersen <oguz@ersen.moe>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/tr/
Translation: Mumble/Mumble Client
|
|
Currently translated at 91.2% (1905 of 2088 strings)
TRANSLATION: Update Norwegian Bokmål translation
Currently translated at 91.2% (1905 of 2088 strings)
Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/nb_NO/
Translation: Mumble/Mumble Client
|
|
Currently translated at 99.9% (2087 of 2088 strings)
Co-authored-by: Gert-dev <qnyasgjhapqyuhoibr@kiabws.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/nl/
Translation: Mumble/Mumble Client
|
|
Currently translated at 100.0% (2088 of 2088 strings)
TRANSLATION: Update Chinese (Simplified) translation
Currently translated at 100.0% (2088 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: deluxghost <deluxghost@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/zh_Hans/
Translation: Mumble/Mumble Client
|
|
Currently translated at 100.0% (2088 of 2088 strings)
TRANSLATION: Update Polish translation
Currently translated at 100.0% (2088 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Matthaiks <kitynska@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/pl/
Translation: Mumble/Mumble Client
|
|
Currently translated at 97.8% (2043 of 2088 strings)
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Iago <iagrivmoa@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/es/
Translation: Mumble/Mumble Client
|
|
When building on a Mac -Doverlay=OFF, the compiler would produce a
warning about an unused variable in the macOS shortcut implementation.
This commit silences the warning, by explicitly marking the variable in
question as unused.
Fixes #5636
|
|
1d45d991aa4d53b6c1bd7d7cae0126a21f3991e1 refactored the audio processing
on the server and introduced the new AudioReceiverBuffer class. In the
function that is responsible for obtaining the current range of
receivers that shall obtain the identical audio packet, the passed begin
iterator was always dereferenced. However, in the case in which the
receiver list is actually empty begin == end and therefore dereferencing
the begin iterator is undefined behavior.
This could lead to the entire server crashing (or could work just fine -
UB is great at this) but in any case, this is a severe problem.
The fix consists of a simple check for this specific situation and an
early return in that case.
Co-Authored-By: Irak Rigia <tarakrigia@gmail.com>
|