From 93019fd0cca61693edd0b81d526204f18e9a1d55 Mon Sep 17 00:00:00 2001 From: Robert Adam Date: Mon, 19 Sep 2022 09:33:32 +0200 Subject: FIX(server, rpc): Don't send useless UserState message As it was, the sent UserState message would have only contained the user's session ID, which in and of itself is absolutely useless. Thus, it is better to not send a UserState message in this case. --- src/murmur/RPC.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/murmur/RPC.cpp b/src/murmur/RPC.cpp index 2cc62da66..3ef6b6b19 100644 --- a/src/murmur/RPC.cpp +++ b/src/murmur/RPC.cpp @@ -408,10 +408,6 @@ void Server::setListenerVolumeAdjustment(ServerUser *user, const Channel *cChann MumbleProto::UserState mpus; mpus.set_session(user->uiSession); - if (!broadcastListenerVolumeAdjustments) { - sendExcept(user, mpus); - } - MumbleProto::UserState::VolumeAdjustment *volume_adjustment = mpus.add_listening_volume_adjustment(); volume_adjustment->set_listening_channel(cChannel->iId); volume_adjustment->set_volume_adjustment(volumeAdjustment.factor); -- cgit v1.2.3