From b4e0989937d97338e295ae95031298c587711f06 Mon Sep 17 00:00:00 2001
From: Robert Adam <dev@robert-adam.de>
Date: Mon, 8 Nov 2021 16:28:52 +0100
Subject: CHANGE(client, ui): Recording disabled by default

The recording button is now disabled by default. It gets enabled only
when connected to a server (that allows recording). This is done because
the recording feature can't be used without a server connection anyway
(doing so will result in an error popup). Thus this restriction is now
reflected in the UI as well.
---
 src/mumble/MainWindow.cpp | 3 +++
 src/mumble/MainWindow.ui  | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/src/mumble/MainWindow.cpp b/src/mumble/MainWindow.cpp
index 4acb6e259..65d1f090c 100644
--- a/src/mumble/MainWindow.cpp
+++ b/src/mumble/MainWindow.cpp
@@ -3329,6 +3329,9 @@ void MainWindow::serverDisconnected(QAbstractSocket::SocketError err, QString re
 	qmUser_aboutToShow();
 	on_qmConfig_aboutToShow();
 
+	// We can't record without a server anyway, so we disable the functionality here
+	enableRecording(false);
+
 	if (!Global::get().sh->qlErrors.isEmpty()) {
 		foreach (QSslError e, Global::get().sh->qlErrors)
 			Global::get().l->log(Log::Warning, tr("SSL Verification failed: %1").arg(e.errorString().toHtmlEscaped()));
diff --git a/src/mumble/MainWindow.ui b/src/mumble/MainWindow.ui
index ce58b1a39..72b38b7f5 100644
--- a/src/mumble/MainWindow.ui
+++ b/src/mumble/MainWindow.ui
@@ -916,6 +916,9 @@ the channel's context menu.</string>
    </property>
   </action>
   <action name="qaRecording">
+   <property name="enabled">
+    <bool>false</bool>
+   </property>
    <property name="icon">
     <iconset>
      <normaloff>skin:actions/media-record.svg</normaloff>skin:actions/media-record.svg</iconset>
-- 
cgit v1.2.3