From 73adfce79f0d1a9045034ddbdf6a6623420495bc Mon Sep 17 00:00:00 2001 From: Robert Adam Date: Wed, 11 May 2022 08:02:01 +0200 Subject: CHANGE(client): Disable RNNoise by default In the 1.4.230 release, we enabled RNNoise by default as there have been lots of reports of how well it works. However, after the release we saw numerous reports complaining about bad audio quality, which was traced back to having RNNoise enabled. For some reason the outcome of having RNNoise enabled is very different in different scenarios. Sometimes it works miraculously well and other times it worsens the audio quality to an unbearable level. There seems to be a higher chance of RNNoise messing up, when using Windows, but the same effect has also been observed on Linux. It might also depend on the quality of the used microphone (better quality = less noise => RNNoise starts doing weird stuff), but we don't have any definitive clues yet. Because of this, we will change the default noise cancelling mode back to Speex so that everyone for whom RNNoise actually works, cna enable it, but we don't kill the experience for many folks by using an unsuitable default value. Fixes #5448 --- src/mumble/Settings.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'src') diff --git a/src/mumble/Settings.cpp b/src/mumble/Settings.cpp index 4d2a95510..947b5d398 100644 --- a/src/mumble/Settings.cpp +++ b/src/mumble/Settings.cpp @@ -499,9 +499,6 @@ Settings::Settings() { qRegisterMetaType< Search::SearchDialog::ChannelAction >("SearchDialog::ChannelAction"); -#ifdef USE_RNNOISE - noiseCancelMode = NoiseCancelRNN; -#endif #ifdef Q_OS_MACOS // The echo cancellation feature on macOS is experimental and known to be able to cause problems // (e.g. muting the user instead of only cancelling echo - https://github.com/mumble-voip/mumble/issues/4912) -- cgit v1.2.3