diff options
author | Michael Schuster <michael@schuster.ms> | 2020-05-29 19:12:36 +0300 |
---|---|---|
committer | Michael Schuster <michael@schuster.ms> | 2020-05-29 19:12:36 +0300 |
commit | efdef8535f59511797b2430e87de7e82ff29feea (patch) | |
tree | 30580843ce6076c1efa3954337695af4566837af /src/gui/sharedialog.cpp | |
parent | b579b49a5ca97e8864bc1696cd772129aef66309 (diff) |
ShareDialog: Fix crash, properly init member pointers
_manager ptr only got initialized in the constructor when sharingPossible was set to true
Changes:
- Move member ptr inits from constructor to the header file's class definition
- Init _manager: set to nullptr too
- Add check for _manager to avoid crash in showSharingUi()
Signed-off-by: Michael Schuster <michael@schuster.ms>
Diffstat (limited to 'src/gui/sharedialog.cpp')
-rw-r--r-- | src/gui/sharedialog.cpp | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/gui/sharedialog.cpp b/src/gui/sharedialog.cpp index 91081e057..13f437c0a 100644 --- a/src/gui/sharedialog.cpp +++ b/src/gui/sharedialog.cpp @@ -52,10 +52,6 @@ ShareDialog::ShareDialog(QPointer<AccountState> accountState, , _maxSharingPermissions(maxSharingPermissions) , _privateLinkUrl(accountState->account()->deprecatedPrivateLinkUrl(numericFileId).toString(QUrl::FullyEncoded)) , _startPage(startPage) - , _linkWidgetList({}) - , _emptyShareLinkWidget(nullptr) - , _userGroupWidget(nullptr) - , _progressIndicator(nullptr) { setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint); setAttribute(Qt::WA_DeleteOnClose); @@ -295,7 +291,9 @@ void ShareDialog::showSharingUi() } if (theme->linkSharing()) { - _manager->fetchShares(_sharePath); + if(_manager != nullptr) { + _manager->fetchShares(_sharePath); + } } } @@ -378,4 +376,4 @@ void ShareDialog::changeEvent(QEvent *e) QDialog::changeEvent(e); } -} +} // namespace OCC |