SslButton: Improve speed (especially on macOS) #6031

From 1+n*450msec to 1*450msec

1 files changed, 3 insertions, 3 deletions

diff --git a/src/gui/sslbutton.cpp b/src/gui/sslbutton.cpp
index 71433aef4..3f8d979da 100644
--- a/src/gui/sslbutton.cpp
+++ b/src/gui/sslbutton.cpp
@@ -58,7 +58,7 @@ static bool isSelfSigned(const QSslCertificate &certificate)
 }
 
 QMenu *SslButton::buildCertMenu(QMenu *parent, const QSslCertificate &cert,
-    const QList<QSslCertificate> &userApproved, int pos)
+    const QList<QSslCertificate> &userApproved, int pos, const QList<QSslCertificate> &systemCaCertificates)
 {
     QString cn = QStringList(cert.subjectInfo(QSslCertificate::CommonName)).join(QChar(';'));
     QString ou = QStringList(cert.subjectInfo(QSslCertificate::OrganizationalUnitName)).join(QChar(';'));
@@ -129,7 +129,7 @@ QMenu *SslButton::buildCertMenu(QMenu *parent, const QSslCertificate &cert,
 
     QString certId = cn.isEmpty() ? ou : cn;
 
-    if (QSslConfiguration::systemCaCertificates().contains(cert)) {
+    if (systemCaCertificates.contains(cert)) {
         txt += certId;
     } else {
         if (isSelfSigned(cert)) {
@@ -232,7 +232,7 @@ void SslButton::slotUpdateMenu()
         it.toBack();
         int i = 0;
         while (it.hasPrevious()) {
-            _menu->addMenu(buildCertMenu(_menu, it.previous(), account->approvedCerts(), i));
+            _menu->addMenu(buildCertMenu(_menu, it.previous(), account->approvedCerts(), i, systemCerts));
             i++;
         }
     }