| Age | Commit message (Collapse) | Author |
|---|
|
This is the same approach used on the server side. Turns out I quite
like it, this avoids popping up a dialog to the user and since she won't
know the password she'll have to set a new one anyway or disable it.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
|
|
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
|
|
Signed-off-by: Camila San <hello@camila.codes>
|
|
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
_manager ptr only got initialized in the constructor when sharingPossible was set to true
Changes:
- Move member ptr inits from constructor to the header file's class definition
- Init _manager: set to nullptr too
- Add check for _manager to avoid crash in showSharingUi()
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
|
|
Fixes #1485
This was missed when creating the new share dialog.
Now it pops up with a nice share password dialog to enter for your link
share.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
|
Use customizeStyle() to change link colours, icons and pixmaps in the ShareDialog and notify
it's widgets via slots.
TODO - known issue (macOS):
- The background and font colours in the ShareUserLine widget still stay the same.
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
|
|
Also displays the sharees that reshared it via share link.
Signed-off-by: Camila San <hello@camila.codes>
|
|
Signed-off-by: Camila San <hello@camila.codes>
|
|
Signed-off-by: Camila San <hello@camila.codes>
|
|
Signed-off-by: Camila San <hello@camila.codes>
|
|
Because why not :S
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
|
- With the new UI this had to be adapted.
Signed-off-by: Camila San <hello@camila.codes>
|
|
- Adds TODO's in commented out code.
Signed-off-by: Camila San <hello@camila.codes>
|
|
- Adds icons to Share link and to save password on share dialog.
- Changes wording of the menu options for sharing link.
- Adds functionality to the new menu (mostly permissions).
- More widget size and size policy adjustments.
Signed-off-by: Camila San <hello@camila.codes>
|
|
widgets.
- Adds select with permissions to share dialog on the user/group search.
- Changes order of widgets, removes excess of text and do not display empty widgets.
- Share user/group widget: replaces combo box for tool button with permissions.
- Using Fixed as size policy it gives a much smoother user experience
when windows size dinamically changes.
Signed-off-by: Camila San <hello@camila.codes>
|
|
- Removes the tabs: adds items to a vertical layout.
- Fix spacing and alignment.
- Removes extra text.
Signed-off-by: Camila San <hello@camila.codes>
|
|
* The new menu option will fetch shares and create a new link share if
no "context menu share" currently exists.
* Various cleanup of common operations in socketapi happened as well,
in particular there's now FileData::get() that calculates all the
relevant paths that are useful for most socketapi actions.
|
|
|
|
Some servers have non-compliant instance ids (that start with a number)
and thereby make deducing the numeric file id from the full id
unreliable.
To circumvent this problem we retrieve the fileid property from the
server with a PROPFIND.
|
|
This is motivated by the fact that QMetaObject::noralizeSignature takes 7.35%
CPU of the LargeSyncBench. (Mostly from ABstractNetworkJob::setupConnections and
PropagateUploadFileV1::startNextChunk). It could be fixed by using normalized
signature in the connection statement, but i tought it was a good oportunity
to modernize the code.
This commit only contains calls that were automatically converted with clazy.
|
|
* The sharing ui does a propfind anyway: use that to query the new
property as well!
* For the socket api, asynchronously query the server for the right url
when an action that needs it is triggered.
The old, manually generated URL will be used as fallback in case the
server doesn't support the new property or the property can't be
retrieved for some reason.
Depends on owncloud/core#29021
|
|
* SocketAPI has COPL_LOCAL_LINK / EMAIL_LOCAL_LINK commands
* The nautilus and dolphing shell integrations show a submenu from which
one can share as well as access the private link.
* The SocketAPI provides a new GET_STRINGS command to access localized
strings.
* The private link can also be accessed from the user/group sharing
dialog.
* The numeric file id is extracted from the full id to create the
private link url.
|
|
|
|
|
|
|
|
Previously this used up some space when there was no icon, leading
to an oddly indented header.
|
|
|
|
Use qCInfo for anything that has general value for support and
development. Use qCWarning for any recoverable error and qCCritical
for anything that could result in data loss or would identify a serious
issue with the code.
Issue #5647
|
|
This gives more insight about the logs and allow setting fine-tuned
logging rules. The categories are set to only output Info by default
so this allows us to provide more concise logging while keeping the
ability to extract more information for a specific category when
developping or debugging customer issues.
Issue #5647
|
|
|
|
Starting from oC 10.0.0 having several public link shares with
different attributes for a path will be supported. This adds
functionality to create, edit and delete these public link shares.
The behavior is currently gated by server version, but should be
adapted to use a capability as soon as one is introduced, see
owncloud/core#27622.
The UI reduces to a single-share version when talking to older servers.
Testing scenarios:
* Link sharing is disabled (by capability, not by theme)
* Required passwords
* Required expiry
* Forbidden 'allow upload' for folders
* New and old servers
|
|
|
|
|
|
Hex literals don't work well with version 10: 0x100000 doesn't do
the right thing.
|
|
See #5180
|
|
Ticket #5203
|
|
|
|
See https://github.com/owncloud/core/pull/24017
This was done since other services we want to intergrate with don't use
the ownCloud namespace.
|
|
|
|
Users can't reshare with more permissions than they have themselves.
|
|
Fixes #4185
|
|
Fixes #4325
|
|
|
|
Setting default=false was not enough.
|
|
|
|
|
