diff options
| author | Lukas Reschke <lukas@owncloud.com> | 2015-03-10 12:12:01 +0300 |
|---|---|---|
| committer | Lukas Reschke <lukas@owncloud.com> | 2015-03-10 12:16:39 +0300 |
| commit | 9572d74187b8b02e074f93635f1860eaf79caa37 (patch) | |
| tree | 047c6a0cbe79bc17550f8408558ecda7620f5815 /templates | |
| parent | 1e08e0317fbfffdc826d1e196a68e130effe5a5b (diff) | |
Fix share button display
With ownCloud 8 the "Close" button of the PDF Viewer is shown incorrectly and overlaps the "secondary tool bar" button which results in a bad user experience and looks very ugly.
This patch addresses this problem by moving the "Close" button inside the iframe and accessing it using jQuery.
Testplan:
- [ ] Accessing a PDF as logged-in user from the file list works and a Close button is shown.
- [ ] Clicking on the close button closes the file
- [ ] Sharing a single PDF file via link works and no Close button is shown
- [ ] Sharing a folder containing a PDF file via link works and a Close button is shown.
- [ ] Clicking on the close button closes the file
To test this properly you need probably to checkout https://github.com/owncloud/core/pull/14773
Diffstat (limited to 'templates')
| -rw-r--r-- | templates/viewer.php | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/templates/viewer.php b/templates/viewer.php index 317784c..b45f776 100644 --- a/templates/viewer.php +++ b/templates/viewer.php @@ -192,6 +192,10 @@ http://sourceforge.net/adobe/cmap/wiki/License/ <span data-l10n-id="tools_label">Tools</span> </button> + <button id="close" class="toolbarButton" title="Close" tabindex="37" data-l10n-id="Close" style="display:block;padding:0 5px;color:#BBBBBB;font-weight:900;font-size:16px;height:18px;top:4px;"> + X + </button> + </div> <div class="outerCenter"> <div class="innerCenter" id="toolbarViewerMiddle"> |