From f9ef0ef96b2225ac177c69ac2a591618bb5b5d5c Mon Sep 17 00:00:00 2001
From: Julius Haertl <jus@bitgrid.net>
Date: Wed, 1 Feb 2017 17:41:38 +0100
Subject: Fix more key warnings

---
 lib/Settings/Admin.php | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

(limited to 'lib')

diff --git a/lib/Settings/Admin.php b/lib/Settings/Admin.php
index 7a27157..c8b763d 100644
--- a/lib/Settings/Admin.php
+++ b/lib/Settings/Admin.php
@@ -48,6 +48,8 @@ class Admin implements ISettings {
 	private $appManager;
 	/** @var SystemConfig */
 	private $systemConfig;
+	/** @var IDBConnection */
+	private $connection;
 
 	public function __construct(
 								IConfig $config,
@@ -260,12 +262,22 @@ class Admin implements ISettings {
 
 	private function getBrowser() {
 		$browser = @get_browser(null, true);
-		if(!$browser) {
+		$browserString = '';
+		if($browser) {
+			if(array_key_exists('browser', $browser)) {
+				$browserString .= $browser['browser'] . ' ';
+			}
+			if(array_key_exists('version', $browser)) {
+				$browserString .= $browser['version'] . ' ';
+			}
+			if(array_key_exists('plattform', $browser)) {
+				$browserString .= $browser['plattform'] . ' ';
+			}
+		}
+		if(empty($browserString)) {
 			return $_SERVER['HTTP_USER_AGENT'];
-		} else {
-			$string = ' ' . $browser['browser'] . ' ' . $browser['version'] . ' ' . $browser['plattform'];
-			return $string;
 		}
+		return $browserString;
 	}
 
 }
-- 
cgit v1.2.3