From 6d2d36a1982f851aead5acb7a861601e7881ccae Mon Sep 17 00:00:00 2001 From: Christoph Wurst Date: Mon, 3 Feb 2020 14:51:51 +0100 Subject: Detect missing mailbox cache and block access to messages Signed-off-by: Christoph Wurst --- lib/Controller/MessagesController.php | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) (limited to 'lib/Controller/MessagesController.php') diff --git a/lib/Controller/MessagesController.php b/lib/Controller/MessagesController.php index 7e075621e..9a6fc82de 100755 --- a/lib/Controller/MessagesController.php +++ b/lib/Controller/MessagesController.php @@ -33,6 +33,7 @@ namespace OCA\Mail\Controller; use Exception; use OCA\Mail\Contracts\IMailManager; use OCA\Mail\Contracts\IMailSearch; +use OCA\Mail\Exception\ClientException; use OCA\Mail\Exception\ServiceException; use OCA\Mail\Http\AttachmentDownloadResponse; use OCA\Mail\Http\HtmlResponse; @@ -40,7 +41,6 @@ use OCA\Mail\Model\IMAPMessage; use OCA\Mail\Service\AccountService; use OCA\Mail\Service\IMailBox; use OCA\Mail\Service\ItineraryService; -use OCA\Mail\Service\SyncService; use OCP\AppFramework\Controller; use OCP\AppFramework\Db\DoesNotExistException; use OCP\AppFramework\Http; @@ -70,9 +70,6 @@ class MessagesController extends Controller { /** @var ItineraryService */ private $itineraryService; - /** @var SyncService */ - private $syncService; - /** @var string */ private $currentUserId; @@ -108,7 +105,6 @@ class MessagesController extends Controller { IMailManager $mailManager, IMailSearch $mailSearch, ItineraryService $itineraryService, - SyncService $syncService, string $UserId, $userFolder, ILogger $logger, @@ -121,7 +117,6 @@ class MessagesController extends Controller { $this->mailManager = $mailManager; $this->mailSearch = $mailSearch; $this->itineraryService = $itineraryService; - $this->syncService = $syncService; $this->currentUserId = $UserId; $this->userFolder = $userFolder; $this->logger = $logger; @@ -141,6 +136,7 @@ class MessagesController extends Controller { * @param string $filter * * @return JSONResponse + * @throws ClientException * @throws ServiceException */ public function index(int $accountId, string $folderId, int $cursor = null, string $filter = null): JSONResponse { @@ -150,11 +146,6 @@ class MessagesController extends Controller { return new JSONResponse(null, Http::STATUS_FORBIDDEN); } - $this->syncService->ensurePopulated( - $account, - base64_decode($folderId) - ); - $this->logger->debug("loading messages of folder <$folderId>"); return new JSONResponse( -- cgit v1.2.3