1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
|
<?php
/**
* @copyright 2017 Christoph Wurst <christoph@winzerhof-wurst.at>
*
* @author 2017 Christoph Wurst <christoph@winzerhof-wurst.at>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\Mail\Tests\Unit\Http\Middleware;
use ChristophWurst\Nextcloud\Testing\TestCase;
use OCA\Mail\Exception\NotImplemented;
use OCA\Mail\Exception\ServiceException;
use OCA\Mail\Http\Middleware\ErrorMiddleware;
use OCP\AppFramework\Controller;
use OCP\AppFramework\Db\DoesNotExistException;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\JSONResponse;
use OCP\AppFramework\Utility\IControllerMethodReflector;
use OCP\IConfig;
use OCP\ILogger;
use PHPUnit_Framework_MockObject_MockObject;
class ErrorMiddlewareTest extends TestCase {
/** @var IConfig|PHPUnit_Framework_MockObject_MockObject */
private $config;
/** @var ILogger|PHPUnit_Framework_MockObject_MockObject */
private $logger;
/** @var IControllerMethodReflector|PHPUnit_Framework_MockObject_MockObject */
private $reflector;
/** @var ErrorMiddleware */
private $middleware;
protected function setUp(): void {
parent::setUp();
$this->config = $this->createMock(IConfig::class);
$this->logger = $this->createMock(ILogger::class);
$this->reflector = $this->createMock(IControllerMethodReflector::class);
$this->middleware = new ErrorMiddleware($this->config, $this->logger,
$this->reflector);
}
public function testDoesNotChangeSuccessfulResponses() {
$response = new JSONResponse();
$controller = $this->createMock(Controller::class);
$after = $this->middleware->afterController($controller, 'index', $response);
$this->assertSame($response, $after);
}
public function testDoesNotChangeUntaggedMethodResponses() {
$controller = $this->createMock(Controller::class);
$exception = new DoesNotExistException('nope');
$this->reflector->expects($this->once())
->method('hasAnnotation')
->willReturn(false);
$this->expectException(DoesNotExistException::class);
$this->middleware->afterException($controller, 'index', $exception);
}
public function trappedErrorsData() {
return [
[new DoesNotExistException('does not exist'), false, Http::STATUS_NOT_FOUND],
[new ServiceException(), true, Http::STATUS_INTERNAL_SERVER_ERROR],
[new NotImplemented(), false, Http::STATUS_NOT_IMPLEMENTED],
];
}
/**
* @dataProvider trappedErrorsData
*/
public function testTrapsErrors($exception, $shouldLog, $expectedStatus) {
$controller = $this->createMock(Controller::class);
$this->reflector->expects($this->once())
->method('hasAnnotation')
->willReturn(true);
$this->logger->expects($this->exactly($shouldLog ? 1 : 0))
->method('logException')
->with($exception);
$response = $this->middleware->afterException($controller, 'index', $exception);
$this->assertInstanceOf(JSONResponse::class, $response);
$this->assertEquals($expectedStatus, $response->getStatus());
}
}
|