ncp-update-nc: check skip major versionsv1.41.3

Signed-off-by: nachoparker <nacho@ownyourbits.com>

1 files changed, 9 insertions, 2 deletions

diff --git a/bin/ncp-update-nc b/bin/ncp-update-nc
index 530fcc88..382ae96b 100755
--- a/bin/ncp-update-nc
+++ b/bin/ncp-update-nc
@@ -32,8 +32,8 @@ cd "$BASEDIR"
 DATADIR="$( grep datadirectory nextcloud/config/config.php | awk '{ print $3 }' | grep -oP "[^']*[^']" | head -1 )"
 ncc status &>/dev/null          || { echo "Nextcloud is currently down"; exit 1; }
 [[ -d /var/www/nextcloud-old ]] && { echo "Nextcloud backup directory found. Interrupted or already running installation?"; exit 1; }
-[[ -d /var/www/nextcloud     ]] || { echo "Nextcloud directory not found"                              ; exit 1; }
-[[ -d "$DATADIR"             ]] || { echo "Nextcloud data directory not found"                         ; exit 1; }
+[[ -d /var/www/nextcloud     ]] || { echo "Nextcloud directory not found"      ; exit 1; }
+[[ -d "$DATADIR"             ]] || { echo "Nextcloud data directory not found" ; exit 1; }
 
 # check version
 ####################
@@ -41,6 +41,13 @@ ncc status &>/dev/null          || { echo "Nextcloud is currently down"; exit 1;
 [[ ${EUID} -eq 0 ]] && SUDO="sudo -u www-data"
 CURRENT="$( $SUDO php /var/www/nextcloud/occ status | grep "version:" | awk '{ print $3 }' )"
 
+MAJOR_CUR=$( cut -d. -f1 <<<"${CURRENT}" )
+MAJOR_NEW=$( cut -d. -f1 <<<"${VER}" )
+if [[ $((MAJOR_NEW - MAJOR_CUR)) -gt 1 ]]; then
+  echo "Upgrade cannot skip major versions. Please upgrade one major version at a time" >&2
+  exit 1
+fi
+
 grep -qP "\d+\.\d+\.\d+" <<<"$CURRENT" || { echo "Malformed version $CURRENT"; exit 1; }
 grep -qP "\d+\.\d+\.\d+" <<<"$VER"     || { echo "Malformed version $VER"    ; exit 1; }