nc-info: provide suggestionsv0.37.5

2 files changed, 32 insertions, 2 deletions

diff --git a/changelog.md b/changelog.md
index 9fedbef1..3250625f 100644
--- a/changelog.md
+++ b/changelog.md
@@ -1,5 +1,9 @@
 
-[v0.37.3](https://github.com/nextcloud/nextcloudpi/commit/a9fcded) (2017-11-24) build: fix cleanup
+[v0.37.5](https://github.com/nextcloud/nextcloudpi/commit/0a7850c) (2017-11-25) nc-info: provide suggestions
+
+[v0.37.4 ](https://github.com/nextcloud/nextcloudpi/commit/a2b7a7a) (2017-11-25) dnsmasq: improve output
+
+[v0.37.3 ](https://github.com/nextcloud/nextcloudpi/commit/f5219f4) (2017-11-24) build: fix cleanup
 
 [v0.37.2 ](https://github.com/nextcloud/nextcloudpi/commit/529f9de) (2017-11-20) nc-datadir: dont create dir if not exists
 
diff --git a/etc/nextcloudpi-config.d/nc-info.sh b/etc/nextcloudpi-config.d/nc-info.sh
index 12e544f1..aa76e2d1 100644
--- a/etc/nextcloudpi-config.d/nc-info.sh
+++ b/etc/nextcloudpi-config.d/nc-info.sh
@@ -17,7 +17,33 @@ DESCRIPTION="Print NextCloudPi system info"
 
 configure() 
 {
-  ncp-diag | column  -t -s'|'
+  # info
+
+  local OUT="$( ncp-diag )"
+  echo "$OUT" | column -t -s'|'
+
+  # suggestions
+
+  DNSMASQ_ON="$( grep "^ACTIVE_=" /usr/local/etc/nextcloudpi-config.d/dnsmasq.sh | cut -d'=' -f2 )"
+  
+  [[ $DNSMASQ_ON != "yes" ]] && \
+    grep -q "NAT loopback|no" <<<"$OUT" && \
+      echo -e "\nYou should enable dnsmasq to use your domain inside home"
+
+  grep -q "certificates|none" <<<"$OUT" && \
+    echo -e "\nYou should run Lets Encrypt for trusted encrypted access"
+
+  grep -q "port check .*|closed" <<<"$OUT" && \
+      echo -e "\nYou should open your ports for Lets Encrypt and external access"
+
+  grep -q "USB devices|none" <<<"$OUT" || {
+    grep -q "data in SD|yes" <<<"$OUT" && \
+      echo -e "\nYou should use nc-datadir to move your files to your plugged in USB drive"
+
+    grep -q "automount|no" <<<"$OUT" && \
+      echo -e "\nYou should enable automount to uyyse your plugged in USB drive"
+  }
+  return 0
 }
 
 install() { :; }