Remove comment

Fix if statement

Add return

Add return

Remove assignment

1 files changed, 3 insertions, 4 deletions

diff --git a/controller/credentialcontroller.php b/controller/credentialcontroller.php
index cdb8065b..4a6d0a8f 100644
--- a/controller/credentialcontroller.php
+++ b/controller/credentialcontroller.php
@@ -145,7 +145,6 @@ class CredentialController extends ApiController {
 			}
 		}
 		$link = ''; // @TODO create direct link to credential
-		$activity = false;
 		if ($revision_created) {
 			$activity = 'item_apply_revision';
 			$this->activityService->add(
@@ -182,9 +181,9 @@ class CredentialController extends ApiController {
 		try {
 			$acl_list = $this->sharingService->getCredentialAclList($storedCredential->getGuid());
 		} catch (DoesNotExistException $exception) {
-
+			// Just check if we have an acl list
 		}
-		if ($acl_list) {
+		if (!empty($acl_list)) {
 			$params = array();
 			switch ($activity) {
 				case 'item_recovered':
@@ -293,7 +292,7 @@ class CredentialController extends ApiController {
 	public function updateRevision($credential_guid, $revision_id, $credential_data){
 		$revision = null;
 		try {
-			$credential = $this->credentialService->getCredentialByGUID($credential_guid, $this->userId);
+			$this->credentialService->getCredentialByGUID($credential_guid, $this->userId);
 		} catch (DoesNotExistException $e) {
 			return new NotFoundJSONResponse();
 		}