Fix test and typo

1 files changed, 11 insertions, 10 deletions

diff --git a/tests/unit/lib/Db/ShareRequestMapperTest.php b/tests/unit/lib/Db/ShareRequestMapperTest.php
index b56c5617..124d1760 100644
--- a/tests/unit/lib/Db/ShareRequestMapperTest.php
+++ b/tests/unit/lib/Db/ShareRequestMapperTest.php
@@ -249,9 +249,9 @@ class ShareRequestMapperTest extends DatabaseHelperTest {
 	 * @covers ::updatePendinRequestPermissions
 	 */
 	public function testUpdatePendinRequestPermissions() {
-		$this->markTestIncomplete("Check why the fuck the dataset array gets altered when increasing permisions");
-		$this->markTestSkipped("Update works, so skipping the test");
-		if (true) return;
+		//$this->markTestIncomplete("Check why the fuck the dataset array gets altered when increasing permisions");
+		//$this->markTestSkipped("Update works, so skipping the test");
+		//if (true) return;
 
 		$dataset = $this->findInDataset(
 			self::TABLES[0],
@@ -263,8 +263,7 @@ class ShareRequestMapperTest extends DatabaseHelperTest {
 			'target_user_id',
 			$dataset[0]['target_user_id']
 		);
-
-		$this->mapper->updatePendinRequestPermissions(
+		$this->mapper->updatePendingRequestPermissions(
 			$dataset[0]['item_guid'],
 			$dataset[0]['target_user_id'],
 			$dataset[0]['permissions'] + 4
@@ -277,18 +276,20 @@ class ShareRequestMapperTest extends DatabaseHelperTest {
 
 		$this->assertCount(count($dataset), $after_update);
 
-		foreach ($dataset as &$row) $row = ShareRequest::fromRow($row);
+		//foreach ($dataset as &$row) $row = ShareRequest::fromRow($row);
 
 		foreach ($after_update as $row) {
-			if ($dataset[0]->getId() === $row->getId()){
-				$this->assertNotEquals($dataset[0]->getPermissions(), $row->getPermissions());
-				$this->assertSame($dataset[0]->getPermissions() + 4, $row->getPermissions());
-
+			if ($dataset[0]['id'] === $row->getId()){
+				$old_permission = $dataset[0]['permissions'];
+				$newPermission = $row->getPermissions();
+				$this->assertNotEquals($old_permission, $row->getPermissions());
+				$this->assertSame($newPermission, $row->getPermissions());
 				$tmp_data = $row->jsonSerialize();
 				$tmp_compare = $dataset[0]->jsonSerialize();
 
 				unset($tmp_compare['permissions']);
 				unset($tmp_data['permissions']);
+
 				$this->assertSame($tmp_compare, $tmp_data);
 			}
 		}