Merge pull request #365 from nextcloud/backport/363/stable23

[stable23] Shuffle before validating

1 files changed, 3 insertions, 3 deletions

diff --git a/lib/Generator.php b/lib/Generator.php
index ca9ea63..b578b84 100644
--- a/lib/Generator.php
+++ b/lib/Generator.php
@@ -85,6 +85,9 @@ class Generator {
 
 			$password .= $chars = $this->random->generate($length, $chars);
 
+			// Shuffle string so the order is random
+			$password = str_shuffle($password);
+
 			try {
 				$this->validator->validate($password);
 
@@ -108,9 +111,6 @@ class Generator {
 			throw new HintException('Could not generate a valid password');
 		}
 
-		// Shuffle string so the order is random
-		$password = str_shuffle($password);
-
 		return $password;
 	}
 }