diff options
author | dartcafe <github@dartcafe.de> | 2021-10-15 01:09:04 +0300 |
---|---|---|
committer | dartcafe <github@dartcafe.de> | 2021-10-15 01:09:04 +0300 |
commit | eb64a8c6c2b1ee373c81d3751e73ffbfce890496 (patch) | |
tree | 22e3adcacd8b2b62dbcb2f2ea9b93425e4166cb6 | |
parent | 4b84b06e109182afae3980e3cb4961f0c2238cc2 (diff) |
vue/no-unused-properties
Signed-off-by: dartcafe <github@dartcafe.de>
25 files changed, 11 insertions, 208 deletions
diff --git a/.eslintrc.js b/.eslintrc.js index de081f70..95e9885c 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -11,7 +11,6 @@ module.exports = { 'arrow-parens': 'error', 'arrow-body-style': 'error', 'brace-style': 'error', - 'prefer-template': 'error', 'newline-per-chained-call': ['error', { ignoreChainWithDepth: 4 }], 'no-array-constructor': 'error', 'no-continue': 'error', @@ -20,5 +19,11 @@ module.exports = { 'no-negated-condition': 'error', 'no-plusplus': ['error', { allowForLoopAfterthoughts: true }], 'object-curly-spacing': ['error', 'always'], + 'prefer-template': 'error', + 'vue/no-unused-properties': ['error', { + groups: ['props', 'data', 'computed', 'methods'], + deepData: true, + ignorePublicMembers: true, + }], }, } diff --git a/src/js/components/Calendar/CalendarPeek.vue b/src/js/components/Calendar/CalendarPeek.vue index a0e21b86..a2d5adf4 100644 --- a/src/js/components/Calendar/CalendarPeek.vue +++ b/src/js/components/Calendar/CalendarPeek.vue @@ -63,20 +63,6 @@ export default { data() { return { events: [], - event: { - Id: 0, - UID: 0, - calendarKey: '', - calendarName: '', - displayColor: '', - allDay: '', - description: '', - end: '', - location: '', - start: '', - status: '', - summary: '', - }, } }, diff --git a/src/js/components/Comments/CommentItem.vue b/src/js/components/Comments/CommentItem.vue index e566d497..989248c8 100644 --- a/src/js/components/Comments/CommentItem.vue +++ b/src/js/components/Comments/CommentItem.vue @@ -55,14 +55,6 @@ export default { }, }, - data() { - return { - deleteInterval: null, - deleteTimeout: null, - countdown: 7, - } - }, - computed: { ...mapState({ acl: (state) => state.poll.acl, @@ -80,14 +72,6 @@ export default { showError(t('polls', 'Error while deleting the comment')) } }, - - cancelDeleteComment() { - clearTimeout(this.deleteTimeout) - clearInterval(this.deleteInterval) - this.deleteTimeout = null - this.deleteInterval = null - this.countdown = 7 - }, }, } </script> diff --git a/src/js/components/Create/CreateDlg.vue b/src/js/components/Create/CreateDlg.vue index 54da3f81..3c239944 100644 --- a/src/js/components/Create/CreateDlg.vue +++ b/src/js/components/Create/CreateDlg.vue @@ -62,7 +62,6 @@ export default { data() { return { - id: 0, pollType: 'datePoll', title: '', pollTypeOptions: [ @@ -100,6 +99,7 @@ export default { } }, + /** @public */ setFocus() { this.$nextTick(() => { this.$refs.pollTitle.focus() diff --git a/src/js/components/Options/OptionProposals.vue b/src/js/components/Options/OptionProposals.vue index 25482d37..34adf6c1 100644 --- a/src/js/components/Options/OptionProposals.vue +++ b/src/js/components/Options/OptionProposals.vue @@ -55,16 +55,6 @@ export default { proposalsOpen: 'poll/proposalsOpen', proposalsExpireRelative: 'poll/proposalsExpireRelative', }), - - proposalsStatus() { - if (this.proposalsExpirySet && !this.proposalsExpired) { - return t('polls', 'Proposal period ends {timeRelative}.', { timeRelative: this.proposalsExpireRelative }) - } - if (this.proposalsExpirySet && this.proposalsExpired) { - return t('polls', 'Proposal period ended {timeRelative}.', { timeRelative: this.proposalsExpireRelative }) - } - return t('polls', 'You are asked to propose more poll options.') - }, }, } diff --git a/src/js/components/Options/OptionsDate.vue b/src/js/components/Options/OptionsDate.vue index 42f81a6c..c34adb30 100644 --- a/src/js/components/Options/OptionsDate.vue +++ b/src/js/components/Options/OptionsDate.vue @@ -69,7 +69,6 @@ <script> import { mapGetters, mapState } from 'vuex' -import moment from '@nextcloud/moment' import { Actions, ActionButton, EmptyContent, Modal } from '@nextcloud/vue' import ActionDelete from '../Actions/ActionDelete' import OptionCloneDate from './OptionCloneDate' @@ -102,12 +101,6 @@ export default { return { cloneModal: false, optionToClone: {}, - sequence: { - baseOption: {}, - unit: { name: t('polls', 'Week'), value: 'week' }, - step: 1, - amount: 1, - }, } }, @@ -123,10 +116,6 @@ export default { countOptions: 'options/count', pollTypeIcon: 'poll/typeIcon', }), - - dateBaseOptionString() { - return moment.unix(this.sequence.baseOption.timestamp).format('LLLL') - }, }, methods: { diff --git a/src/js/components/Options/OptionsDateShift.vue b/src/js/components/Options/OptionsDateShift.vue index 863ce612..6bf6ccf9 100644 --- a/src/js/components/Options/OptionsDateShift.vue +++ b/src/js/components/Options/OptionsDateShift.vue @@ -44,7 +44,6 @@ import { mapState, mapGetters } from 'vuex' import InputDiv from '../Base/InputDiv' -import moment from '@nextcloud/moment' import { Multiselect } from '@nextcloud/vue' import { dateUnits } from '../../mixins/dateMixins' @@ -60,12 +59,6 @@ export default { data() { return { - sequence: { - baseOption: {}, - unit: { name: t('polls', 'Week'), value: 'week' }, - step: 1, - amount: 1, - }, shift: { step: 1, unit: { name: t('polls', 'Week'), value: 'week' }, @@ -81,15 +74,6 @@ export default { ...mapGetters({ proposalsExist: 'options/proposalsExist', }), - - firstDOW() { - // vue2-datepicker needs 7 for sunday - if (moment.localeData()._week.dow === 0) { - return 7 - } - return moment.localeData()._week.dow - - }, }, methods: { diff --git a/src/js/components/Options/OptionsText.vue b/src/js/components/Options/OptionsText.vue index 8802b5af..e287f9f5 100644 --- a/src/js/components/Options/OptionsText.vue +++ b/src/js/components/Options/OptionsText.vue @@ -88,12 +88,6 @@ export default { removeOption, ], - data() { - return { - newPollText: '', - } - }, - computed: { ...mapState({ options: (state) => state.options.list, @@ -117,15 +111,6 @@ export default { }, }, - - methods: { - async addOption() { - if (this.newPollText) { - await this.$store.dispatch('options/add', { pollOptionText: this.newPollText }) - this.newPollText = '' - } - }, - }, } </script> diff --git a/src/js/components/Poll/PollHeaderButtons.vue b/src/js/components/Poll/PollHeaderButtons.vue index e7d469cb..fd892f4d 100644 --- a/src/js/components/Poll/PollHeaderButtons.vue +++ b/src/js/components/Poll/PollHeaderButtons.vue @@ -61,14 +61,6 @@ export default { UserMenu, }, - data() { - return { - delay: 50, - isLoading: false, - voteSaved: false, - } - }, - computed: { ...mapState({ allowComment: (state) => state.poll.allowComment, diff --git a/src/js/components/Poll/PollInformation.vue b/src/js/components/Poll/PollInformation.vue index 75a657c6..66c95b9e 100644 --- a/src/js/components/Poll/PollInformation.vue +++ b/src/js/components/Poll/PollInformation.vue @@ -169,22 +169,10 @@ export default { }, - voteLimitReached() { - return (this.poll.voteLimit > 0 && this.countVotes('yes') >= this.poll.voteLimit) - }, - dateCreatedRelative() { return moment.unix(this.poll.created).fromNow() }, - dateCreatedString() { - return moment.unix(this.poll.created).format('LLLL') - }, - - dateExpiryString() { - return moment.unix(this.poll.expire).format('LLLL') - }, - dateExpiryRelative() { return moment.unix(this.poll.expire).fromNow() }, diff --git a/src/js/components/Poll/PollTitle.vue b/src/js/components/Poll/PollTitle.vue index a584711d..bdc2d3ee 100644 --- a/src/js/components/Poll/PollTitle.vue +++ b/src/js/components/Poll/PollTitle.vue @@ -123,14 +123,6 @@ export default { return subTexts }, - expiryInfo() { - return { - text: t('polls', 'Proposal period ends {timeRelative}', { timeRelative: this.proposalsExpireRelative }), - icon: 'icon-add', - class: 'proposal', - } - }, - dateCreatedRelative() { return moment.unix(this.pollCreated).fromNow() }, diff --git a/src/js/components/PollList/PollItem.vue b/src/js/components/PollList/PollItem.vue index b77ebb57..1e5147e5 100644 --- a/src/js/components/PollList/PollItem.vue +++ b/src/js/components/PollList/PollItem.vue @@ -120,12 +120,6 @@ export default { }, }, - data() { - return { - openedMenu: false, - } - }, - computed: { closeToClosing() { return (!this.closed && this.poll.expire && moment.unix(this.poll.expire).diff() < 86400000) diff --git a/src/js/components/PollList/PollItemAdmin.vue b/src/js/components/PollList/PollItemAdmin.vue index fe32e24d..2cc1aea9 100644 --- a/src/js/components/PollList/PollItemAdmin.vue +++ b/src/js/components/PollList/PollItemAdmin.vue @@ -104,12 +104,6 @@ export default { }, }, - data() { - return { - openedMenu: false, - } - }, - computed: { ...mapGetters({ closed: 'poll/isClosed', diff --git a/src/js/components/Settings/AdminMisc.vue b/src/js/components/Settings/AdminMisc.vue index 16ba1203..5f113c38 100644 --- a/src/js/components/Settings/AdminMisc.vue +++ b/src/js/components/Settings/AdminMisc.vue @@ -53,13 +53,6 @@ export default { InputDiv, }, - data() { - return { - searchToken: null, - isLoading: false, - } - }, - computed: { ...mapState({ appSettings: (state) => state.appSettings.appSettings, diff --git a/src/js/components/Shares/SharesEffective.vue b/src/js/components/Shares/SharesEffective.vue index eb0d3c5a..3cc37dcd 100644 --- a/src/js/components/Shares/SharesEffective.vue +++ b/src/js/components/Shares/SharesEffective.vue @@ -70,14 +70,6 @@ export default { ConfigBox, }, - data() { - return { - users: [], - isLoading: false, - placeholder: t('polls', 'Enter a name to start the search'), - } - }, - computed: { ...mapGetters({ invitationShares: 'shares/invitation', diff --git a/src/js/components/Shares/SharesPublic.vue b/src/js/components/Shares/SharesPublic.vue index 711be289..3acc5a9a 100644 --- a/src/js/components/Shares/SharesPublic.vue +++ b/src/js/components/Shares/SharesPublic.vue @@ -66,11 +66,6 @@ export default { data() { return { - clippy: { - buttonCaption: t('polls', 'Copy link to clipboard'), - successText: t('polls', 'Link copied to clipboard'), - errorText: t('polls', 'Error while copying link to clipboard'), - }, paramsHint: t('polls', 'Add URL parameters \'name=\' and/or \'email=\' to predefine name and email address. For example: https://example.com/s/aUubZAvweQ6PaX2?name=John Doe&email=johndoe@example.org'), } }, diff --git a/src/js/components/SideBar/SideBarTabShare.vue b/src/js/components/SideBar/SideBarTabShare.vue index 5db8400e..995bd5c7 100644 --- a/src/js/components/SideBar/SideBarTabShare.vue +++ b/src/js/components/SideBar/SideBarTabShare.vue @@ -57,12 +57,6 @@ export default { allowPublicShares: (state) => state.poll.acl.allowPublicShares, }), }, - - methods: { - removeShare(share) { - this.$store.dispatch('shares/delete', { share }) - }, - }, } </script> diff --git a/src/js/components/User/UserItem.vue b/src/js/components/User/UserItem.vue index ee0035b3..52894b9c 100644 --- a/src/js/components/User/UserItem.vue +++ b/src/js/components/User/UserItem.vue @@ -115,13 +115,6 @@ export default { }, }, - data() { - return { - nothidden: false, - circleName: '', - } - }, - computed: { name() { if (this.displayName) { diff --git a/src/js/components/VoteTable/VoteColumn.vue b/src/js/components/VoteTable/VoteColumn.vue index 2ae8a556..9a70d2e1 100644 --- a/src/js/components/VoteTable/VoteColumn.vue +++ b/src/js/components/VoteTable/VoteColumn.vue @@ -86,13 +86,6 @@ export default { }, }, - data() { - return { - modal: false, - userToRemove: '', - } - }, - computed: { ...mapState({ acl: (state) => state.poll.acl, diff --git a/src/js/components/VoteTable/VoteTable.vue b/src/js/components/VoteTable/VoteTable.vue index 17f0f63e..487f233a 100644 --- a/src/js/components/VoteTable/VoteTable.vue +++ b/src/js/components/VoteTable/VoteTable.vue @@ -72,13 +72,6 @@ export default { }, }, - data() { - return { - modal: false, - userToRemove: '', - } - }, - computed: { ...mapState({ acl: (state) => state.poll.acl, diff --git a/src/js/components/VoteTable/VoteTableHeaderItem.vue b/src/js/components/VoteTable/VoteTableHeaderItem.vue index d148bdef..96557a89 100644 --- a/src/js/components/VoteTable/VoteTableHeaderItem.vue +++ b/src/js/components/VoteTable/VoteTableHeaderItem.vue @@ -43,10 +43,6 @@ export default { type: Object, default: undefined, }, - viewMode: { - type: String, - default: 'table-view', - }, }, computed: { @@ -67,18 +63,12 @@ export default { return 'textBox' }, - showNo() { - return (this.viewMode === 'list-view') - }, + isWinner() { // highlight best option until poll is closed and // at least one option is confirmed return this.option.rank === 1 && this.option.yes && !(this.closed && this.confirmedOptions.length) }, - - isConfirmed() { - return this.option.confirmed && this.closed - }, }, } diff --git a/src/js/views/Administration.vue b/src/js/views/Administration.vue index 2b9f8e38..eb1819cd 100644 --- a/src/js/views/Administration.vue +++ b/src/js/views/Administration.vue @@ -154,6 +154,7 @@ export default { return t('polls', 'Administration') }, + /* eslint-disable-next-line vue/no-unused-properties */ windowTitle() { return `${t('polls', 'Polls')} - ${this.title}` }, diff --git a/src/js/views/Navigation.vue b/src/js/views/Navigation.vue index fdd9b014..2ae1a77c 100644 --- a/src/js/views/Navigation.vue +++ b/src/js/views/Navigation.vue @@ -78,7 +78,6 @@ export default { data() { return { - showSettingsDlg: false, createDlg: false, } }, diff --git a/src/js/views/PollList.vue b/src/js/views/PollList.vue index bf31f85f..096a1298 100644 --- a/src/js/views/PollList.vue +++ b/src/js/views/PollList.vue @@ -138,6 +138,7 @@ export default { return this.pollCategories.find((category) => (category.id === this.$route.params.type)).description }, + /* eslint-disable-next-line vue/no-unused-properties */ windowTitle() { return `${t('polls', 'Polls')} - ${this.title}` }, @@ -197,15 +198,6 @@ export default { } }, - callPoll(index, poll, name) { - this.$router.push({ - name, - params: { - id: poll.id, - }, - }) - }, - async toggleArchive(pollId) { try { await this.$store.dispatch('poll/toggleArchive', { pollId }) diff --git a/src/js/views/Vote.vue b/src/js/views/Vote.vue index 070b9071..ff565a35 100644 --- a/src/js/views/Vote.vue +++ b/src/js/views/Vote.vue @@ -67,7 +67,6 @@ </template> <script> -import { showError, showSuccess } from '@nextcloud/dialogs' import { mapState, mapGetters } from 'vuex' import { AppContent, EmptyContent } from '@nextcloud/vue' import { getCurrentUser } from '@nextcloud/auth' @@ -92,9 +91,7 @@ export default { data() { return { - delay: 50, isLoading: false, - voteSaved: false, } }, @@ -117,10 +114,7 @@ export default { safeTable: 'poll/safeTable', }), - showEmailEdit() { - return ['email', 'contact', 'external'].includes(this.share.type) - }, - + /* eslint-disable-next-line vue/no-unused-properties */ windowTitle() { return `${t('polls', 'Polls')} - ${this.poll.title}` }, @@ -172,15 +166,6 @@ export default { this.$router.replace({ name: 'notfound' }) } }, - - async submitEmailAddress(emailAddress) { - try { - await this.$store.dispatch('share/updateEmailAddress', { emailAddress }) - showSuccess(t('polls', 'Email address {emailAddress} saved.', { emailAddress })) - } catch { - showError(t('polls', 'Error saving email address {emailAddress}', { emailAddress })) - } - }, }, } |