diff options
| author | Carl Schwan <carl@carlschwan.eu> | 2022-03-08 15:49:08 +0300 |
|---|---|---|
| committer | Carl Schwan <carl@carlschwan.eu> | 2022-03-09 01:11:08 +0300 |
| commit | 7496bf3461a382c9a93d876b894448b7c4cd28cb (patch) | |
| tree | 1c3d6bad8fff2719c98e0b478fd2dec7e1961ffc /.github | |
| parent | 8a52591335f9fc8ac06002dea17705f860487b09 (diff) | |
Require the secret config to be configured
If it's not configured the instance will look like it is working but
various features will silently break (end to end encryption, setting
alternate email and probably more).
One issue is that changing the secret from empty to something will
break various other stuff (app token). I don't think there is a good way
to solve this issue other than breaking early instead of having to
handle a painful migration later on.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/s3-external.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/workflows/s3-external.yml b/.github/workflows/s3-external.yml index dedab6b0c16..a1d4dcbda22 100644 --- a/.github/workflows/s3-external.yml +++ b/.github/workflows/s3-external.yml @@ -55,7 +55,7 @@ jobs: php -S localhost:8080 & - name: PHPUnit run: | - echo "<?php return ['run' => true,'hostname' => 'localhost','key' => 'minio','secret' => 'minio123', 'bucket' => 'bucket', 'port' => 9000, 'use_ssl' => false, 'autocreate' => true, 'use_path_style' => true];" > apps/${{ env.APP_NAME }}/tests/config.amazons3.php + echo "<?php return ['run' => true, 'secret' => 'actually-not-secret', 'hostname' => 'localhost','key' => 'minio','secret' => 'minio123', 'bucket' => 'bucket', 'port' => 9000, 'use_ssl' => false, 'autocreate' => true, 'use_path_style' => true];" > apps/${{ env.APP_NAME }}/tests/config.amazons3.php phpunit --configuration tests/phpunit-autotest-external.xml apps/files_external/tests/Storage/Amazons3Test.php phpunit --configuration tests/phpunit-autotest-external.xml apps/files_external/tests/Storage/VersionedAmazonS3Test.php - name: S3 logs |