Merge pull request #33786 from nextcloud/backport/33772/stable23

[stable23] Log if cookie login failed with token mismatch or session unavailability

1 files changed, 8 insertions, 0 deletions

diff --git a/lib/private/User/Session.php b/lib/private/User/Session.php
index 8f910113078..d3ccb24fdf8 100644
--- a/lib/private/User/Session.php
+++ b/lib/private/User/Session.php
@@ -880,6 +880,10 @@ class Session implements IUserSession, Emitter {
 		$tokens = $this->config->getUserKeys($uid, 'login_token');
 		// test cookies token against stored tokens
 		if (!in_array($currentToken, $tokens, true)) {
+			$this->logger->error('Tried to log in {uid} but could not verify token', [
+				'app' => 'core',
+				'uid' => $uid,
+			]);
 			return false;
 		}
 		// replace successfully used token with a new one
@@ -891,6 +895,10 @@ class Session implements IUserSession, Emitter {
 			$sessionId = $this->session->getId();
 			$token = $this->tokenProvider->renewSessionToken($oldSessionId, $sessionId);
 		} catch (SessionNotAvailableException $ex) {
+			$this->logger->warning('Could not renew session token for {uid} because the session is unavailable', [
+				'app' => 'core',
+				'uid' => $uid,
+			]);
 			return false;
 		} catch (InvalidTokenException $ex) {
 			\OC::$server->getLogger()->warning('Renewing session token failed', ['app' => 'core']);