diff options
| author | Simon L <szaimen@e.mail.de> | 2022-06-21 14:26:30 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-21 14:26:30 +0300 |
| commit | fb4353b64cb590b28ee3ee2a63a13b8b0ba21511 (patch) | |
| tree | 334f1542d3842ca70d8841f9688826f5d2d62392 | |
| parent | cfc16ac3ee73bca1ef8439e23016bbca403fc3ae (diff) | |
| parent | f8bebb62ca3896c4d32c20ac7a8363e90f2fa0c5 (diff) | |
Merge pull request #32902 from nextcloud/enh/noid/opcache-buffer-size-limit
do not display the buffer_size info if the size is already set to a c…
| -rw-r--r-- | apps/settings/lib/Controller/CheckSetupController.php | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php index d6a9b89fd26..51027c5ad1c 100644 --- a/apps/settings/lib/Controller/CheckSetupController.php +++ b/apps/settings/lib/Controller/CheckSetupController.php @@ -525,7 +525,11 @@ Raw output if ( empty($status['interned_strings_usage']['free_memory']) || - ($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) + ( + ($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) && + // Do not recommend to raise the interned strings buffer size above a quarter of the total OPcache size + ($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') < $this->iniGetWrapper->getNumeric('opcache.memory_consumption') / 4) + ) ) { $recommendations[] = $this->l10n->t('The OPcache interned strings buffer is nearly full. To assure that repeating strings can be effectively cached, it is recommended to apply <code>opcache.interned_strings_buffer</code> to your PHP configuration with a value higher than <code>%s</code>.', [($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') ?: 'currently')]); } |